Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 33698,
    "url": "https://patches.dpdk.org/api/patches/33698/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com",
    "date": "2018-01-14T10:03:37",
    "name": "[dpdk-dev,v3,1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed.",
    "commit_ref": null,
    "pull_url": null,
    "state": "not-applicable",
    "archived": true,
    "hash": "2077b07a7f366bd78b37ac1f7be2fa7a3bf63325",
    "submitter": {
        "id": 834,
        "url": "https://patches.dpdk.org/api/people/834/?format=api",
        "name": "Tonghao Zhang",
        "email": "xiangxia.m.yue@gmail.com"
    },
    "delegate": {
        "id": 24,
        "url": "https://patches.dpdk.org/api/users/24/?format=api",
        "username": "helin_zhang",
        "first_name": "Helin",
        "last_name": "Zhang",
        "email": "helin.zhang@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/33698/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/33698/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E4E32C6E;\n\tSun, 14 Jan 2018 11:05:00 +0100 (CET)",
            "from mail-pl0-f67.google.com (mail-pl0-f67.google.com\n\t[209.85.160.67]) by dpdk.org (Postfix) with ESMTP id 45C2910B7\n\tfor <dev@dpdk.org>; Sun, 14 Jan 2018 11:04:58 +0100 (CET)",
            "by mail-pl0-f67.google.com with SMTP id 62so1743525pld.7\n\tfor <dev@dpdk.org>; Sun, 14 Jan 2018 02:04:58 -0800 (PST)",
            "from local.opencloud.tech.localdomain ([183.240.196.59])\n\tby smtp.gmail.com with ESMTPSA id\n\tv7sm15208761pgs.83.2018.01.14.02.04.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 14 Jan 2018 02:04:56 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=nZYgQCl5iwNzZ+h1WguK54MJQvi3siRU99tpsqcJHFk=;\n\tb=PlYs8yoCnR621YwaTjLl3+LgY3Dmy+VxpdJ3UeMHwNIZPJ8gQhRZJCj5fy4FVA/unc\n\tQq3IBjpkzsGZ2lq+eZQXYJ74x8xQFYg82czMoq0snoRvAgAFi8czih1tSlfZQG1jOVBu\n\tPNzqFvC76CuHtLtRDPRo4ubw0iF/jKVwPxBpTojF2SG1fJD5Jiwde2XYPUaWt+XmgFjj\n\ttbP8CNgXxgtkoWgaQNJwDfQXmgiQZPxd2/Igdtr1RPAuniPBX/WcV779CukfC0JSluh3\n\t2z7WjhagsmPLj5HGd664KW88By3jdMMQTNqGQS5/PskbMQMOhL3D1FpAdHrHmN2f1606\n\tptdQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=nZYgQCl5iwNzZ+h1WguK54MJQvi3siRU99tpsqcJHFk=;\n\tb=afLxHMRZ1W+lE0z85tYUwknxgsmzTqIKaJNoJHtPB1Li0UshsDBKChxRuImqjcm1IN\n\tiHx3nIyozi5QoS+8ECzvKt2cRIC3gy8aC9a3Nve5C2iAn8Xqgxo1FbuwfTAx8K+T9Jvm\n\tcOsIJ2S5NbWIWHGVHrCnQ8bkRNBNHSJM9NJnYAYthRwRvKSCZ4ur4kTGjI1MK3NrcMMH\n\tRBaTos4Ci8RcEADbteLMMzQffV1u6hhaCibnttbtzR2S/DcOwBvs1+uDqrYOKY8hcl3o\n\tIRGOqd+9zTD/a+wCeTyWdeu3CYZKOAhIitPCJ8yJcQDsO8Kaqd2rRv6wZD1AuNhPbktn\n\tdrqA==",
        "X-Gm-Message-State": "AKwxyteVmoNXFBLf2wZ/7TwNoVNIsWH/uf90z+9cXADV8QvU5Egljbzz\n\tKfKp9b50J1MMwde/fV6adw0=",
        "X-Google-Smtp-Source": "ACJfBoscXIBIamvonoJVVMZpTun/03qNkppul3uUf4mRTUtwi5t8sYXNgyENf/T2NE28Z6oOmIzkCw==",
        "X-Received": "by 10.159.202.138 with SMTP id p10mr434953plo.261.1515924297264; \n\tSun, 14 Jan 2018 02:04:57 -0800 (PST)",
        "From": "xiangxia.m.yue@gmail.com",
        "To": "wei.dai@intel.com,\n\tbeilei.xing@intel.com",
        "Cc": "dev@dpdk.org,\n\tTonghao Zhang <xiangxia.m.yue@gmail.com>",
        "Date": "Sun, 14 Jan 2018 02:03:37 -0800",
        "Message-Id": "<1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when\n\tother interrupts not allowed.",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n\nWhen bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the\nrx-interrupt, there will be more than one epoll_wait on intr_handle.fd.\nOne is in \"eal-intr-thread\" thread, and the others are in the thread\nwhich call the \"rte_epoll_wait\". The problem is that sometimes\n\"eal-intr-thread\" thread will process the rx interrupt, and then\nrte_epoll_wait can't get the event anymore, and the packets may be lost.\n\nThe patch unregister the status interrupt handler in \"eal-intr-thread\"\nthread and the ixgbe pf is in the same case.\n\nSigned-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>\nAcked-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex ff19a56..0e056a2 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -5078,6 +5078,15 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \t}\n \tixgbevf_configure_msix(dev);\n \n+\tif (!rte_intr_allow_others(intr_handle)) {\n+\t\trte_intr_callback_unregister(intr_handle,\n+\t\t\t\t\t     ixgbevf_dev_interrupt_handler,\n+\t\t\t\t\t     dev);\n+\t\tif (dev->data->dev_conf.intr_conf.lsc != 0)\n+\t\t\tPMD_INIT_LOG(INFO, \"lsc won't enable because of\"\n+\t\t\t\t     \" no intr multiplex\");\n+\t}\n+\n \t/* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt\n \t * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ).\n \t * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( )\n@@ -5120,6 +5129,12 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tixgbe_dev_clear_queues(dev);\n \n+\tif (!rte_intr_allow_others(intr_handle))\n+\t\t/* resume to the default handler */\n+\t\trte_intr_callback_register(intr_handle,\n+\t\t\t\t\t   ixgbevf_dev_interrupt_handler,\n+\t\t\t\t\t   (void *)dev);\n+\n \t/* Clean datapath event and queue/vec mapping */\n \trte_intr_efd_disable(intr_handle);\n \tif (intr_handle->intr_vec != NULL) {\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "1/6"
    ]
}