Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3357/?format=api
{ "id": 3357, "url": "https://patches.dpdk.org/api/patches/3357/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1423979251-5562-1-git-send-email-cunming.liang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1423979251-5562-1-git-send-email-cunming.liang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1423979251-5562-1-git-send-email-cunming.liang@intel.com", "date": "2015-02-15T05:47:31", "name": "[dpdk-dev,v1] test: add ut for eal flags --lcores", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c773b7bc68caa60a3c3d21558ebc12f668efb800", "submitter": { "id": 46, "url": "https://patches.dpdk.org/api/people/46/?format=api", "name": "Cunming Liang", "email": "cunming.liang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1423979251-5562-1-git-send-email-cunming.liang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3357/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3357/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F0DC8B555;\n\tSun, 15 Feb 2015 06:47:59 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id EE9B4B551\n\tfor <dev@dpdk.org>; Sun, 15 Feb 2015 06:47:57 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 14 Feb 2015 21:40:36 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 14 Feb 2015 21:39:31 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t1F5lgmF029763;\n\tSun, 15 Feb 2015 13:47:42 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t1F5ldN5005604; Sun, 15 Feb 2015 13:47:41 +0800", "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t1F5lY6m005600; \n\tSun, 15 Feb 2015 13:47:34 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,579,1418112000\"; d=\"scan'208\";a=\"527737010\"", "From": "Cunming Liang <cunming.liang@intel.com>", "To": "dev@dpdk.org", "Date": "Sun, 15 Feb 2015 13:47:31 +0800", "Message-Id": "<1423979251-5562-1-git-send-email-cunming.liang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH v1] test: add ut for eal flags --lcores", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The patch add unit test for the new eal option \"--lcores\".\n\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n It depends on the previous patch which enabling EAL \"--lcores\" option.\n http://dpdk.org/ml/archives/dev/2015-February/013204.html\n\n app/test/test_eal_flags.c | 95 ++++++++++++++++++++++++++++++++++++++++-------\n 1 file changed, 81 insertions(+), 14 deletions(-)", "diff": "diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex 0a8269c..0352f87 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -512,47 +512,114 @@ test_missing_c_flag(void)\n \n \t/* -c flag but no coremask value */\n \tconst char *argv1[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-c\"};\n-\t/* No -c or -l flag at all */\n+\t/* No -c, -l or --lcores flag at all */\n \tconst char *argv2[] = { prgname, prefix, mp_flag, \"-n\", \"3\"};\n \t/* bad coremask value */\n-\tconst char *argv3[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-c\", \"error\" };\n+\tconst char *argv3[] = { prgname, prefix, mp_flag,\n+\t\t\t\t\"-n\", \"3\", \"-c\", \"error\" };\n \t/* sanity check of tests - valid coremask value */\n-\tconst char *argv4[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-c\", \"1\" };\n+\tconst char *argv4[] = { prgname, prefix, mp_flag,\n+\t\t\t\t\"-n\", \"3\", \"-c\", \"1\" };\n \t/* -l flag but no corelist value */\n-\tconst char *argv5[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-l\"};\n-\tconst char *argv6[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-l\", \" \" };\n+\tconst char *argv5[] = { prgname, prefix, mp_flag,\n+\t\t\t\t\"-n\", \"3\", \"-l\"};\n+\tconst char *argv6[] = { prgname, prefix, mp_flag,\n+\t\t\t\t\"-n\", \"3\", \"-l\", \" \" };\n \t/* bad corelist values */\n-\tconst char *argv7[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-l\", \"error\" };\n-\tconst char *argv8[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-l\", \"1-\" };\n-\tconst char *argv9[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-l\", \"1,\" };\n-\tconst char *argv10[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-l\", \"1#2\" };\n+\tconst char *argv7[] = { prgname, prefix, mp_flag,\n+\t\t\t\t\"-n\", \"3\", \"-l\", \"error\" };\n+\tconst char *argv8[] = { prgname, prefix, mp_flag,\n+\t\t\t\t\"-n\", \"3\", \"-l\", \"1-\" };\n+\tconst char *argv9[] = { prgname, prefix, mp_flag,\n+\t\t\t\t\"-n\", \"3\", \"-l\", \"1,\" };\n+\tconst char *argv10[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"-l\", \"1#2\" };\n \t/* sanity check test - valid corelist value */\n-\tconst char *argv11[] = { prgname, prefix, mp_flag, \"-n\", \"3\", \"-l\", \"1-2,3\" };\n+\tconst char *argv11[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"-l\", \"1-2,3\" };\n+\n+\t/* --lcores flag but no lcores value */\n+\tconst char *argv12[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\" };\n+\tconst char *argv13[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \" \" };\n+\t/* bad lcores value */\n+\tconst char *argv14[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"1-3-5\" };\n+\tconst char *argv15[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"0-1,,2\" };\n+\tconst char *argv16[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"0-,1\" };\n+\tconst char *argv17[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"(0-,2-4)\" };\n+\tconst char *argv18[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"(-1,2)\" };\n+\tconst char *argv19[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"(2-4)@(2-4-6)\" };\n+\tconst char *argv20[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"(a,2)\" };\n+\tconst char *argv21[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"1-3@(1,3)\" };\n+\tconst char *argv22[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"3@((1,3)\" };\n+\tconst char *argv23[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"(4-7)=(1,3)\" };\n+\tconst char *argv24[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\", \"[4-7]@(1,3)\" };\n+\t/* sanity check of tests - valid lcores value */\n+\tconst char *argv25[] = { prgname, prefix, mp_flag,\n+\t\t\t\t \"-n\", \"3\", \"--lcores\",\n+\t\t\t\t \"0-1,2@(5-7),(3-5)@(0,2),(0,6),7\"};\n \n \tif (launch_proc(argv1) == 0\n \t\t\t|| launch_proc(argv2) == 0\n \t\t\t|| launch_proc(argv3) == 0) {\n-\t\tprintf(\"Error - process ran without error when missing -c flag\\n\");\n+\t\tprintf(\"Error - \"\n+\t\t \"process ran without error when missing -c flag\\n\");\n \t\treturn -1;\n \t}\n \tif (launch_proc(argv4) != 0) {\n-\t\tprintf(\"Error - process did not run ok with valid coremask value\\n\");\n+\t\tprintf(\"Error - \"\n+\t\t \"process did not run ok with valid coremask value\\n\");\n \t\treturn -1;\n \t}\n \n+\t/* start -l test */\n \tif (launch_proc(argv5) == 0\n \t\t\t|| launch_proc(argv6) == 0\n \t\t\t|| launch_proc(argv7) == 0\n \t\t\t|| launch_proc(argv8) == 0\n \t\t\t|| launch_proc(argv9) == 0\n \t\t\t|| launch_proc(argv10) == 0) {\n-\t\tprintf(\"Error - process ran without error with invalid -l flag\\n\");\n+\t\tprintf(\"Error - \"\n+\t\t \"process ran without error with invalid -l flag\\n\");\n \t\treturn -1;\n \t}\n \tif (launch_proc(argv11) != 0) {\n-\t\tprintf(\"Error - process did not run ok with valid corelist value\\n\");\n+\t\tprintf(\"Error - \"\n+\t\t \"process did not run ok with valid corelist value\\n\");\n \t\treturn -1;\n \t}\n+\n+\t/* start --lcores tests */\n+\tif (launch_proc(argv12) == 0 || launch_proc(argv13) == 0 ||\n+\t launch_proc(argv14) == 0 || launch_proc(argv15) == 0 ||\n+\t launch_proc(argv16) == 0 || launch_proc(argv17) == 0 ||\n+\t launch_proc(argv18) == 0 || launch_proc(argv19) == 0 ||\n+\t launch_proc(argv20) == 0 || launch_proc(argv21) == 0 ||\n+\t launch_proc(argv21) == 0 || launch_proc(argv22) == 0 ||\n+\t launch_proc(argv23) == 0 || launch_proc(argv24) == 0) {\n+\t\tprintf(\"Error - \"\n+\t\t \"process ran without error with invalid --lcore flag\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (launch_proc(argv25) != 0) {\n+\t\tprintf(\"Error - \"\n+\t\t \"process did not run ok with valid corelist value\\n\");\n+\t\treturn -1;\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "dpdk-dev", "v1" ] }