Patch Comment List
List patch comments
GET /api/patches/333/comments/?format=api&order=-date
[ { "id": 1428, "web_url": "https://patches.dpdk.org/comment/1428/", "msgid": "<20141006143506.GA22304@hmsreliant.think-freely.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20141006143506.GA22304@hmsreliant.think-freely.org", "date": "2014-10-06T14:35:06", "subject": "Re: [dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error", "submitter": { "id": 32, "url": "https://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "content": "On Sat, Oct 04, 2014 at 07:14:21PM +0100, Nicolás Pernas Maradei wrote:\n> Hi,\n> \n> You are correct, the parameters received in the driver are allocated in\n> devargs_list (char *params variable). However, they already get strdup'd in\n> rte_kvargs_parse(). This newly allocated string is part of kvlist and never\n> freed up. The params variable is never used again so it can be freed by\n> someone else using free_devargs_list(). I'd say it's safe enough to set up\n> pointers in the way it's currently done.\n> \n> Nico.\n> \n\nok, that seems reasonable\nAcked-by: Neil Horman <nhorman@tuxdriver.com>\n\n> On 2014-09-29 15:24, Neil Horman wrote:\n> >On Wed, Sep 10, 2014 at 05:17:05PM -0300, Nicolás Pernas Maradei wrote:\n> >>From: Nicolás Pernas Maradei <nico@emutex.com>\n> >>\n> >>librte_pmd_pcap driver was opening the pcap/interfaces only at init time\n> >>and\n> >>closing them only when the port was being stopped. This behaviour would\n> >>cause\n> >>problems (leading to segfault) if the user closed the port 2 times. The\n> >>first\n> >>time the pcap/interfaces would be normally closed but libpcap would\n> >>throw an\n> >>error causing a segfault if the closed pcaps/interfaces were closed\n> >>again.\n> >>This behaviour is solved by re-openning pcaps/interfaces when the port\n> >>is\n> >>started (only if these weren't open already for example at init time).\n> >>\n> >>Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>\n> >\n> >This patch assigns pointers to strings that are allocated in the\n> >devargs_list.\n> >Given that there exists an api interface free_devargs_list(), I'm not sure\n> >that\n> >whats being done here is consistently safe. It seems like you should dup\n> >the\n> >strings to make sure you always have the storage allocated, or find some\n> >other\n> >method to store the needed information.\n> >\n> >Neil\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D3A413B5;\n\tMon, 6 Oct 2014 16:28:10 +0200 (CEST)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 026953B5\n\tfor <dev@dpdk.org>; Mon, 6 Oct 2014 16:28:07 +0200 (CEST)", "from hmsreliant.think-freely.org\n\t([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1Xb9NT-0001C2-Ui; Mon, 06 Oct 2014 10:35:13 -0400" ], "Date": "Mon, 6 Oct 2014 10:35:06 -0400", "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "=?iso-8859-1?Q?Nicol=E1s?= Pernas Maradei <nico@emutex.com>", "Message-ID": "<20141006143506.GA22304@hmsreliant.think-freely.org>", "References": "<1410380225-13751-1-git-send-email-nico@emutex.com>\n\t<20140929142406.GC26483@hmsreliant.think-freely.org>\n\t<7ab24cf8da0f11aa07b6770883de356a@statler.emutex.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=iso-8859-1", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<7ab24cf8da0f11aa07b6770883de356a@statler.emutex.com>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1413, "web_url": "https://patches.dpdk.org/comment/1413/", "msgid": "<7ab24cf8da0f11aa07b6770883de356a@statler.emutex.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7ab24cf8da0f11aa07b6770883de356a@statler.emutex.com", "date": "2014-10-04T18:14:21", "subject": "Re: [dpdk-dev]\n\t=?utf-8?q?=5BPATCH=5D_Fix_librte=5Fpmd=5Fpcap_driver_d?=\n\t=?utf-8?q?ouble_stop_error?=", "submitter": { "id": 66, "url": "https://patches.dpdk.org/api/people/66/?format=api", "name": "Nicolás Pernas Maradei", "email": "nico@emutex.com" }, "content": "Hi,\n\nYou are correct, the parameters received in the driver are allocated in \ndevargs_list (char *params variable). However, they already get strdup'd \nin rte_kvargs_parse(). This newly allocated string is part of kvlist and \nnever freed up. The params variable is never used again so it can be \nfreed by someone else using free_devargs_list(). I'd say it's safe \nenough to set up pointers in the way it's currently done.\n\nNico.\n\nOn 2014-09-29 15:24, Neil Horman wrote:\n> On Wed, Sep 10, 2014 at 05:17:05PM -0300, Nicolás Pernas Maradei wrote:\n>> From: Nicolás Pernas Maradei <nico@emutex.com>\n>> \n>> librte_pmd_pcap driver was opening the pcap/interfaces only at init \n>> time and\n>> closing them only when the port was being stopped. This behaviour \n>> would cause\n>> problems (leading to segfault) if the user closed the port 2 times. \n>> The first\n>> time the pcap/interfaces would be normally closed but libpcap would \n>> throw an\n>> error causing a segfault if the closed pcaps/interfaces were closed \n>> again.\n>> This behaviour is solved by re-openning pcaps/interfaces when the port \n>> is\n>> started (only if these weren't open already for example at init time).\n>> \n>> Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>\n> \n> This patch assigns pointers to strings that are allocated in the \n> devargs_list.\n> Given that there exists an api interface free_devargs_list(), I'm not \n> sure that\n> whats being done here is consistently safe. It seems like you should \n> dup the\n> strings to make sure you always have the storage allocated, or find \n> some other\n> method to store the needed information.\n> \n> Neil", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F0DF2E82;\n\tSat, 4 Oct 2014 20:07:26 +0200 (CEST)", "from smtp.digiweb.ie (smtp2.digiweb.ie [83.147.160.14])\n\tby dpdk.org (Postfix) with ESMTP id 7CE62212\n\tfor <dev@dpdk.org>; Sat, 4 Oct 2014 20:07:24 +0200 (CEST)", "from statler.emutex.com (unknown [92.51.199.138])\n\tby smtp.digiweb.ie (Postfix) with ESMTP id 46EAE290037;\n\tSat, 4 Oct 2014 19:14:23 +0100 (IST)", "from [91.103.1.99] (helo=www.emutex.com)\n\tby statler.emutex.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.72) (envelope-from <nico@emutex.com>)\n\tid 1XaTqZ-0006Mg-6L; Sat, 04 Oct 2014 19:14:23 +0100" ], "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8;\n format=flowed", "Content-Transfer-Encoding": "8bit", "Date": "Sat, 04 Oct 2014 19:14:21 +0100", "From": "=?UTF-8?Q?Nicol=C3=A1s_Pernas_Maradei?= <nico@emutex.com>", "To": "Neil Horman <nhorman@tuxdriver.com>", "Organization": "Emutex", "Mail-Reply-To": "nico@emutex.com", "In-Reply-To": "<20140929142406.GC26483@hmsreliant.think-freely.org>", "References": "<1410380225-13751-1-git-send-email-nico@emutex.com>\n\t<20140929142406.GC26483@hmsreliant.think-freely.org>", "Message-ID": "<7ab24cf8da0f11aa07b6770883de356a@statler.emutex.com>", "X-Sender": "nico@emutex.com", "User-Agent": "Roundcube Webmail/RCMAIL_VERSION", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev]\n\t=?utf-8?q?=5BPATCH=5D_Fix_librte=5Fpmd=5Fpcap_driver_d?=\n\t=?utf-8?q?ouble_stop_error?=", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "nico@emutex.com", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1234, "web_url": "https://patches.dpdk.org/comment/1234/", "msgid": "<20140929142406.GC26483@hmsreliant.think-freely.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20140929142406.GC26483@hmsreliant.think-freely.org", "date": "2014-09-29T14:24:06", "subject": "Re: [dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error", "submitter": { "id": 32, "url": "https://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "content": "On Wed, Sep 10, 2014 at 05:17:05PM -0300, Nicolás Pernas Maradei wrote:\n> From: Nicolás Pernas Maradei <nico@emutex.com>\n> \n> librte_pmd_pcap driver was opening the pcap/interfaces only at init time and\n> closing them only when the port was being stopped. This behaviour would cause\n> problems (leading to segfault) if the user closed the port 2 times. The first\n> time the pcap/interfaces would be normally closed but libpcap would throw an\n> error causing a segfault if the closed pcaps/interfaces were closed again.\n> This behaviour is solved by re-openning pcaps/interfaces when the port is\n> started (only if these weren't open already for example at init time).\n> \n> Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>\n\nThis patch assigns pointers to strings that are allocated in the devargs_list.\nGiven that there exists an api interface free_devargs_list(), I'm not sure that\nwhats being done here is consistently safe. It seems like you should dup the\nstrings to make sure you always have the storage allocated, or find some other\nmethod to store the needed information.\n\nNeil", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 308A86A99;\n\tMon, 29 Sep 2014 16:17:41 +0200 (CEST)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id E5C676A96\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 16:17:39 +0200 (CEST)", "from hmsreliant.think-freely.org\n\t([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1XYbry-00046a-TB; Mon, 29 Sep 2014 10:24:14 -0400" ], "Date": "Mon, 29 Sep 2014 10:24:06 -0400", "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "=?iso-8859-1?Q?Nicol=E1s?= Pernas Maradei <nico@emutex.com>", "Message-ID": "<20140929142406.GC26483@hmsreliant.think-freely.org>", "References": "<1410380225-13751-1-git-send-email-nico@emutex.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<1410380225-13751-1-git-send-email-nico@emutex.com>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1229, "web_url": "https://patches.dpdk.org/comment/1229/", "msgid": "<1592464.PQabvuCgtP@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/1592464.PQabvuCgtP@xps13", "date": "2014-09-29T13:21:18", "subject": "Re: [dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-09-10 17:17, Nicolás Pernas Maradei:\n> From: Nicolás Pernas Maradei <nico@emutex.com>\n> \n> librte_pmd_pcap driver was opening the pcap/interfaces only at init time and\n> closing them only when the port was being stopped. This behaviour would cause\n> problems (leading to segfault) if the user closed the port 2 times. The first\n> time the pcap/interfaces would be normally closed but libpcap would throw an\n> error causing a segfault if the closed pcaps/interfaces were closed again.\n> This behaviour is solved by re-openning pcaps/interfaces when the port is\n> started (only if these weren't open already for example at init time).\n> \n> Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>\n> ---\n> lib/librte_pmd_pcap/rte_eth_pcap.c | 254 +++++++++++++++++++++++++++++--------\n> 1 file changed, 202 insertions(+), 52 deletions(-)\n\nSomeone to review this patch?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 37D856A95;\n\tMon, 29 Sep 2014 15:14:56 +0200 (CEST)", "from mail-wi0-f175.google.com (mail-wi0-f175.google.com\n\t[209.85.212.175]) by dpdk.org (Postfix) with ESMTP id DB9156893\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 15:14:54 +0200 (CEST)", "by mail-wi0-f175.google.com with SMTP id d1so990101wiv.14\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 06:21:31 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\twm6sm3485399wjb.5.2014.09.29.06.21.29 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 29 Sep 2014 06:21:29 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=pTApUR660Bn3mn4xCmsOf2Jy6hy9Zy8GkFk9Llf8SRg=;\n\tb=FwQMlmPDDOXJjXslmEqQYcz1a9Rx970hi/EuRNQskPF8HJ9LLm1xLIOzeONf3kZOGk\n\tjYSx7sCzJfqtnZIuE5fXY9WX4Urc6Xt/NPWBwdIarRImhPY2uiGVnJeYDke12c/wkGgB\n\ttl1V+i+TnZAkljFl5I2O/ZdbAfsfdMfLAi7Q1a7aoqEdOA/T+9llOcJqhFtM2fI5du0B\n\tdvTEfhP8piPeRBbzfw0fR6NRmuhVM3u7WzUYuQRqVd3nj/NEThE5NoyrAKFOvNk+W2Wc\n\tJicVX4ug6+UL21swzFR0RTy36L2nevqJeMsrnwrumCtq4fjrhq9AGCSYfXei8UxqSPZD\n\tC6sg==", "X-Gm-Message-State": "ALoCoQlYUASOKb7fyMozFbK5CI3OzCNwt2oa0GVOuGMXZqiDrAxBVhZrmIQA9Ap3Xs4u1CIoE7bX", "X-Received": "by 10.194.60.114 with SMTP id g18mr32770888wjr.94.1411996890944; \n\tMon, 29 Sep 2014 06:21:30 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 29 Sep 2014 15:21:18 +0200", "Message-ID": "<1592464.PQabvuCgtP@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1410380225-13751-1-git-send-email-nico@emutex.com>", "References": "<1410380225-13751-1-git-send-email-nico@emutex.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain; charset=\"utf-8\"", "Cc": "=?ISO-8859-1?Q?Nicol=E1s?= Pernas Maradei <nico@emutex.com>", "Subject": "Re: [dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]