Patch Comment List
List patch comments
GET /api/patches/332/comments/?format=api
[ { "id": 714, "web_url": "https://patches.dpdk.org/comment/714/", "msgid": "<E115CCD9D858EF4F90C690B0DCB4D89722614C67@IRSMSX108.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/E115CCD9D858EF4F90C690B0DCB4D89722614C67@IRSMSX108.ger.corp.intel.com", "date": "2014-09-09T15:20:10", "subject": "Re: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson\n> Sent: Tuesday, September 09, 2014 3:41 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n> mbuf struct\n> \n> The vlan_macip structure combined a vlan tag id with l2 and l3 headers\n> lengths for tracking offloads. However, this structure was only used as\n> a unit by the e1000 and ixgbe drivers, not generally.\n> \n> This patch removes the structure from the mbuf header and places the\n> fields into the mbuf structure directly at the required point, without\n> any net effect on the structure layout. This allows us to treat the vlan\n> tags and header length fields as separate for future mbuf changes. The\n> drivers which were written to use the combined structure still do so,\n> using a driver-local definition of it.\n> \n> Changes in V2:\n> * None\n> \n> Changes in V3:\n> * minor comment cleanup following review by Olivier\n> * reduce perf regression caused by splitting vlan_macip field. This is\n> done by providing a single uint16_t value to allow writing/clearing\n> the l2 and l3 lengths together. There is still a small perf hit to the\n> slow path TX due to the reads from vlan_tci and l2/l3 lengths being\n> separated. (<5% in my tests with testpmd with no extra params).\n> Unfortunately, this cannot be eliminated, without restoring the vlan\n> tags and l2/l3 lengths as a combined 32-bit field. This would prevent\n> us from ever looking to move those fields about and is an artificial tie\n> that applies only for performance in igb and ixgbe drivers. Therefore,\n> this patch keeps the vlan_tci field separate from the lengths as the\n> best solution going forward.\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> V2 Acked-by: Olivier Matz <olivier.matz@6wind.com>\n\nV3 Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 28F8DB372;\n\tTue, 9 Sep 2014 17:16:07 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 1613FB368\n\tfor <dev@dpdk.org>; Tue, 9 Sep 2014 17:16:04 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 09 Sep 2014 08:14:08 -0700", "from irsmsx102.ger.corp.intel.com ([163.33.3.155])\n\tby orsmga001.jf.intel.com with ESMTP; 09 Sep 2014 08:20:12 -0700", "from irsmsx155.ger.corp.intel.com (163.33.192.3) by\n\tIRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 9 Sep 2014 16:20:11 +0100", "from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by\n\tIRSMSX155.ger.corp.intel.com ([169.254.14.85]) with mapi id\n\t14.03.0195.001; Tue, 9 Sep 2014 16:20:11 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,491,1406617200\"; d=\"scan'208\";a=\"570608663\"", "From": "\"De Lara Guarch, Pablo\" <pablo.de.lara.guarch@intel.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "Thread-Index": "AQHPzDxNceSRcdpkdkOL/REQp1os/Zv46kpA", "Date": "Tue, 9 Sep 2014 15:20:10 +0000", "Message-ID": "<E115CCD9D858EF4F90C690B0DCB4D89722614C67@IRSMSX108.ger.corp.intel.com>", "References": "<540D71BF.8050006@6wind.com>\n\t<1410273656-4567-1-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1410273656-4567-1-git-send-email-bruce.richardson@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]