List comments

GET /api/patches/332/comments/
Content-Type: application/json
Vary: Accept

        "id": 714,
        "web_url": "",
        "msgid": "<>",
        "date": "2014-09-09T15:20:10",
        "subject": "Re: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct",
        "submitter": {
            "id": 9,
            "url": "",
            "name": "Pablo de Lara",
            "email": ""
        "content": "> -----Original Message-----\n> From: dev [] On Behalf Of Bruce Richardson\n> Sent: Tuesday, September 09, 2014 3:41 PM\n> To:\n> Subject: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n> mbuf struct\n> \n> The vlan_macip structure combined a vlan tag id with l2 and l3 headers\n> lengths for tracking offloads. However, this structure was only used as\n> a unit by the e1000 and ixgbe drivers, not generally.\n> \n> This patch removes the structure from the mbuf header and places the\n> fields into the mbuf structure directly at the required point, without\n> any net effect on the structure layout. This allows us to treat the vlan\n> tags and header length fields as separate for future mbuf changes. The\n> drivers which were written to use the combined structure still do so,\n> using a driver-local definition of it.\n> \n> Changes in V2:\n> * None\n> \n> Changes in V3:\n> * minor comment cleanup following review by Olivier\n> * reduce perf regression caused by splitting vlan_macip field. This is\n>   done by providing a single uint16_t value to allow writing/clearing\n>   the l2 and l3 lengths together. There is still a small perf hit to the\n>   slow path TX due to the reads from vlan_tci and l2/l3 lengths being\n>   separated. (<5% in my tests with testpmd with no extra params).\n>   Unfortunately, this cannot be eliminated, without restoring the vlan\n>   tags and l2/l3 lengths as a combined 32-bit field. This would prevent\n>   us from ever looking to move those fields about and is an artificial tie\n>   that applies only for performance in igb and ixgbe drivers. Therefore,\n>   this patch keeps the vlan_tci field separate from the lengths as the\n>   best solution going forward.\n> \n> Signed-off-by: Bruce Richardson <>\n> V2 Acked-by: Olivier Matz <>\n\nV3 Acked-by: Pablo de Lara <>",
        "headers": {
            "List-Id": "patches and discussions about DPDK <>",
            "From": "\"De Lara Guarch, Pablo\" <>",
            "List-Help": "<>",
            "Date": "Tue, 9 Sep 2014 15:20:10 +0000",
            "X-Mailman-Version": "2.1.15",
            "List-Archive": "<>",
            "Delivered-To": "",
            "Accept-Language": "en-US",
            "X-MS-Has-Attach": "",
            "List-Unsubscribe": "<>,\n\t<>",
            "List-Subscribe": "<>,\n\t<>",
            "X-MS-TNEF-Correlator": "",
            "To": "\"Richardson, Bruce\" <>, \"\"\n\t<>",
            "Errors-To": "",
            "References": "<>\n\t<>",
            "Precedence": "list",
            "Return-Path": "<>",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,491,1406617200\"; d=\"scan'208\";a=\"570608663\"",
            "List-Post": "<>",
            "Received": [
                "from [] (localhost [IPv6:::1])\n\tby (Postfix) with ESMTP id 28F8DB372;\n\tTue,  9 Sep 2014 17:16:07 +0200 (CEST)",
                "from ( [])\n\tby (Postfix) with ESMTP id 1613FB368\n\tfor <>; Tue,  9 Sep 2014 17:16:04 +0200 (CEST)",
                "from ([])\n\tby with ESMTP; 09 Sep 2014 08:14:08 -0700",
                "from ([])\n\tby with ESMTP; 09 Sep 2014 08:20:12 -0700",
                "from ( by\n\ ( with Microsoft SMTP\n\tServer (TLS) id; Tue, 9 Sep 2014 16:20:11 +0100",
                "from ([]) by\n\ ([]) with mapi id\n\t14.03.0195.001; Tue, 9 Sep 2014 16:20:11 +0100"
            "Thread-Index": "AQHPzDxNceSRcdpkdkOL/REQp1os/Zv46kpA",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Sender": "\"dev\" <>",
            "Subject": "Re: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct",
            "In-Reply-To": "<>",
            "MIME-Version": "1.0",
            "Message-ID": "<>",
            "X-ExtLoop1": "1",
            "Content-Language": "en-US",
            "x-originating-ip": "[]",
            "Content-Transfer-Encoding": "quoted-printable",
            "X-BeenThere": "",
            "X-Original-To": "",
            "Thread-Topic": "[dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into\n\tmbuf\tstruct"