Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/329/?format=api
{ "id": 329, "url": "https://patches.dpdk.org/api/patches/329/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1410247299-4365-10-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1410247299-4365-10-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1410247299-4365-10-git-send-email-helin.zhang@intel.com", "date": "2014-09-09T07:21:33", "name": "[dpdk-dev,09/15] i40e: remove code for TPH (TLP Processing Hints)", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9b965cd14f3094f4546473d0a3beb09bbdfa00ce", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1410247299-4365-10-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/329/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/329/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0B34FB3E4;\n\tTue, 9 Sep 2014 09:17:40 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 49B33B3C3\n\tfor <dev@dpdk.org>; Tue, 9 Sep 2014 09:17:38 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 09 Sep 2014 00:16:34 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 09 Sep 2014 00:22:10 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s897M901008879;\n\tTue, 9 Sep 2014 15:22:09 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s897M7v4004488; Tue, 9 Sep 2014 15:22:09 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s897M6Kh004484; \n\tTue, 9 Sep 2014 15:22:06 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,491,1406617200\"; d=\"scan'208\";a=\"600087298\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 9 Sep 2014 15:21:33 +0800", "Message-Id": "<1410247299-4365-10-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1410247299-4365-1-git-send-email-helin.zhang@intel.com>", "References": "<1410247299-4365-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 09/15] i40e: remove code for TPH (TLP Processing\n\tHints)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The code wrapped in '#ifdef I40E_TPH_SUPPORT' was added\nto check if 'TPH' is supported, and enable it. It is not\nused currently and can be removed.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nReviewed-by: Chen Jing <jing.d.chen@intel.com>\n---\n lib/librte_pmd_i40e/i40e/i40e_common.c | 55 ----------------------------------\n 1 file changed, 55 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e/i40e_common.c b/lib/librte_pmd_i40e/i40e/i40e_common.c\nindex 4f11542..7e750ec 100644\n--- a/lib/librte_pmd_i40e/i40e/i40e_common.c\n+++ b/lib/librte_pmd_i40e/i40e/i40e_common.c\n@@ -542,61 +542,6 @@ struct i40e_rx_ptype_decoded i40e_ptype_lookup[] = {\n \tI40E_PTT_UNUSED_ENTRY(255)\n };\n \n-#ifdef I40E_TPH_SUPPORT\n-\n-/**\n- * i40e_tph_present\n- * @hw: pointer to the hw struct\n- *\n- * Check to see if TPH capability is present.\n- **/\n-bool i40e_tph_present(struct i40e_hw *hw)\n-{\n-\tu32 capsup = rd32(hw, I40E_GLPCI_CAPSUP);\n-\n-\treturn capsup & I40E_GLPCI_CAPSUP_TPH_EN_MASK;\n-}\n-\n-/**\n- * i40e_enable_tph\n- * @hw: pointer to the hw struct\n- * @tph_control: contents of TPH Requester Control Register\n- *\n- * Check to see if TPH can be enabled; if so, enable it.\n- **/\n-bool i40e_enable_tph(struct i40e_hw *hw, u32 tph_control)\n-{\n-\tu32 gltph, st_mode, permit;\n-\n-\t/* check that TPH is permitted */\n-\tpermit = (tph_control & I40E_TPH_REQ_ENA_MASK)\n-\t\t >> I40E_TPH_REQ_ENA_SHIFT;\n-\tif (!(permit & I40E_TPH_REQ_PERMIT))\n-\t\treturn false;\n-\n-\t/* check for valid ST mode */\n-\tst_mode = tph_control & I40E_TPH_ST_MODE_MASK;\n-\tif ((st_mode != I40E_TPH_MODE_NOTABLE) &&\n-\t (st_mode != I40E_TPH_MODE_DEVSPEC))\n-\t\treturn false;\n-\n-\t/* TPH may be enabled */\n-\tgltph = rd32(hw, I40E_GLTPH_CTRL);\n-\n-\t/* turn off device-specific */\n-\tif (st_mode != I40E_TPH_MODE_DEVSPEC)\n-\t\tgltph &= ~I40E_GLTPH_CTRL_TPH_DEVSPEC_MASK;\n-\n-\t/* This enables TPH for all queues for the given types of operation.\n-\t * Additional enabling is done per-queue in setup of the queue contexts.\n-\t */\n-\tgltph |= I40E_GLTPH_CTRL_DESC_PH_MASK; /* descriptor reads/writes */\n-\tgltph |= I40E_GLTPH_CTRL_DATA_PH_MASK; /* data reads/writes */\n-\twr32(hw, I40E_GLTPH_CTRL, gltph);\n-\n-\treturn true;\n-}\n-#endif\t/* I40E_TPH_SUPPORT */\n #ifndef VF_DRIVER\n \n /**\n", "prefixes": [ "dpdk-dev", "09/15" ] }