Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3219/?format=api
{ "id": 3219, "url": "https://patches.dpdk.org/api/patches/3219/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1423742468-30404-24-git-send-email-changchun.ouyang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1423742468-30404-24-git-send-email-changchun.ouyang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1423742468-30404-24-git-send-email-changchun.ouyang@intel.com", "date": "2015-02-12T12:00:55", "name": "[dpdk-dev,23/36] ixgbe base codes: API for write i2c combined", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ae546b18d3a295eb66bbc82c75a4103731ecf527", "submitter": { "id": 31, "url": "https://patches.dpdk.org/api/people/31/?format=api", "name": "Ouyang Changchun", "email": "changchun.ouyang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1423742468-30404-24-git-send-email-changchun.ouyang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3219/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3219/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D8CC7ADAC;\n\tThu, 12 Feb 2015 13:02:26 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 8048FAD8E\n\tfor <dev@dpdk.org>; Thu, 12 Feb 2015 13:02:20 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP; 12 Feb 2015 03:54:58 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 12 Feb 2015 04:02:07 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t1CC24qN012443;\n\tThu, 12 Feb 2015 20:02:04 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t1CC20CZ030599; Thu, 12 Feb 2015 20:02:02 +0800", "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t1CC20he030595; \n\tThu, 12 Feb 2015 20:02:00 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,565,1418112000\"; d=\"scan'208\";a=\"651179436\"", "From": "Ouyang Changchun <changchun.ouyang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 12 Feb 2015 20:00:55 +0800", "Message-Id": "<1423742468-30404-24-git-send-email-changchun.ouyang@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1423742468-30404-1-git-send-email-changchun.ouyang@intel.com>", "References": "<1423742468-30404-1-git-send-email-changchun.ouyang@intel.com>", "Subject": "[dpdk-dev] [PATCH 23/36] ixgbe base codes: API for write i2c\n\tcombined", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "New API to perform I2C write combined operation.\n\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c | 16 ++++++++++++++++\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h | 1 +\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 11 +++++++++--\n 3 files changed, 26 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c\nindex ae13adb..8037301 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c\n@@ -1326,6 +1326,7 @@ s32 ixgbe_read_i2c_combined(struct ixgbe_hw *hw, u8 addr, u16 reg, u16 *val)\n * ixgbe_write_i2c_byte - Writes 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to write\n+ * @dev_addr: I2C bus address to write to\n * @data: value to write\n *\n * Performs byte write operation to SFP module's EEPROM over I2C interface\n@@ -1339,6 +1340,21 @@ s32 ixgbe_write_i2c_byte(struct ixgbe_hw *hw, u8 byte_offset, u8 dev_addr,\n }\n \n /**\n+ * ixgbe_write_i2c_combined - Perform I2C write combined operation\n+ * @hw: pointer to the hardware structure\n+ * @addr: I2C bus address to write to\n+ * @reg: I2C device register to write to\n+ * @val: value to write\n+ *\n+ * Returns an error code on error.\n+ */\n+s32 ixgbe_write_i2c_combined(struct ixgbe_hw *hw, u8 addr, u16 reg, u16 val)\n+{\n+\treturn ixgbe_call_func(hw, hw->phy.ops.write_i2c_combined, (hw, addr,\n+\t\t\t reg, val), IXGBE_NOT_IMPLEMENTED);\n+}\n+\n+/**\n * ixgbe_write_i2c_eeprom - Writes 8 bit EEPROM word over I2C interface\n * @hw: pointer to hardware structure\n * @byte_offset: EEPROM byte offset to write\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h\nindex 77ebc64..8386e29 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h\n@@ -174,6 +174,7 @@ s32 ixgbe_read_i2c_byte(struct ixgbe_hw *hw, u8 byte_offset, u8 dev_addr,\n s32 ixgbe_read_i2c_combined(struct ixgbe_hw *hw, u8 addr, u16 reg, u16 *val);\n s32 ixgbe_write_i2c_byte(struct ixgbe_hw *hw, u8 byte_offset, u8 dev_addr,\n \t\t\t u8 data);\n+s32 ixgbe_write_i2c_combined(struct ixgbe_hw *hw, u8 addr, u16 reg, u16 val);\n s32 ixgbe_write_i2c_eeprom(struct ixgbe_hw *hw, u8 byte_offset, u8 eeprom_data);\n s32 ixgbe_get_san_mac_addr(struct ixgbe_hw *hw, u8 *san_mac_addr);\n s32 ixgbe_set_san_mac_addr(struct ixgbe_hw *hw, u8 *san_mac_addr);\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c\nindex d8a0c19..bdf41da 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c\n@@ -787,6 +787,7 @@ s32 ixgbe_setup_sfp_modules_X550em(struct ixgbe_hw *hw)\n {\n \tbool setup_linear;\n \tu16 reg_slice, edc_mode;\n+\ts32 ret_val;\n \n \tDEBUGFUNC(\"ixgbe_setup_sfp_modules_X550em\");\n \n@@ -827,8 +828,14 @@ s32 ixgbe_setup_sfp_modules_X550em(struct ixgbe_hw *hw)\n \t\tedc_mode = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;\n \n \t/* Configure CS4227 for connection type. */\n-\treturn hw->phy.ops.write_i2c_combined(hw, IXGBE_CS4227,\n-\t\t\t\t\t reg_slice, edc_mode);\n+\tret_val = ixgbe_write_i2c_combined(hw, IXGBE_CS4227, reg_slice,\n+\t\t\t\t\t edc_mode);\n+\n+\tif (ret_val != IXGBE_SUCCESS)\n+\t\tret_val = ixgbe_write_i2c_combined(hw, 0x80, reg_slice,\n+\t\t\t\t\t\t edc_mode);\n+\n+\treturn ret_val;\n }\n \n /**\n", "prefixes": [ "dpdk-dev", "23/36" ] }