Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 319,
    "url": "https://patches.dpdk.org/api/patches/319/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1410247299-4365-4-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1410247299-4365-4-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1410247299-4365-4-git-send-email-helin.zhang@intel.com",
    "date": "2014-09-09T07:21:27",
    "name": "[dpdk-dev,03/15] i40e: remove useless code which was written for Solaris",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "efd73082cbb0c6be56f6857f2177d4585b6e1c85",
    "submitter": {
        "id": 14,
        "url": "https://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1410247299-4365-4-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/319/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/319/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7DA6FB3AA;\n\tTue,  9 Sep 2014 09:17:01 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id C3001B3A1\n\tfor <dev@dpdk.org>; Tue,  9 Sep 2014 09:16:55 +0200 (CEST)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 09 Sep 2014 00:21:58 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 09 Sep 2014 00:16:58 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s897LtK1008385;\n\tTue, 9 Sep 2014 15:21:55 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s897Lrpr004446; Tue, 9 Sep 2014 15:21:55 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s897Lr4K004442; \n\tTue, 9 Sep 2014 15:21:53 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"383381611\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue,  9 Sep 2014 15:21:27 +0800",
        "Message-Id": "<1410247299-4365-4-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1410247299-4365-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1410247299-4365-1-git-send-email-helin.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 03/15] i40e: remove useless code which was\n\twritten for Solaris",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The code wrapped in '#ifdef DMA_SYNC_SUPPORT' was written specially\nfor Solaris, it is not needed anymore for others including DPDK.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nReviewed-by: Chen Jing <jing.d.chen@intel.com>\n---\n lib/librte_pmd_i40e/i40e/i40e_adminq.c | 19 -------------------\n 1 file changed, 19 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_i40e/i40e/i40e_adminq.c b/lib/librte_pmd_i40e/i40e/i40e_adminq.c\nindex d078cea..9b5a294 100644\n--- a/lib/librte_pmd_i40e/i40e/i40e_adminq.c\n+++ b/lib/librte_pmd_i40e/i40e/i40e_adminq.c\n@@ -690,9 +690,6 @@ u16 i40e_clean_asq(struct i40e_hw *hw)\n \n \tdesc = I40E_ADMINQ_DESC(*asq, ntc);\n \tdetails = I40E_ADMINQ_DETAILS(*asq, ntc);\n-#ifdef DMA_SYNC_SUPPORT\n-\tI40E_DMA_SYNC(&hw->aq.asq.desc_buf, I40E_SYNC_FORKERNEL);\n-#endif /* DMA_SYNC_SUPPORT */\n \twhile (rd32(hw, hw->aq.asq.head) != ntc) {\n \t\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n \t\t\t   \"%s: ntc %d head %d.\\n\", __FUNCTION__, ntc,\n@@ -866,14 +863,8 @@ enum i40e_status_code i40e_asq_send_command(struct i40e_hw *hw,\n \t\t\t\tCPU_TO_LE32(I40E_HI_DWORD(dma_buff->pa));\n \t\tdesc_on_ring->params.external.addr_low =\n \t\t\t\tCPU_TO_LE32(I40E_LO_DWORD(dma_buff->pa));\n-#ifdef DMA_SYNC_SUPPORT\n-\t\tI40E_DMA_SYNC(dma_buff, I40E_SYNC_FORDEVICE);\n-#endif /* DMA_SYNC_SUPPORT */\n \t}\n \n-#ifdef DMA_SYNC_SUPPORT\n-\tI40E_DMA_SYNC(&hw->aq.asq.desc_buf, I40E_SYNC_FORDEVICE);\n-#endif /* DMA_SYNC_SUPPORT */\n \t/* bump the tail */\n \ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE, \"AQTX: desc and buffer:\\n\");\n \ti40e_debug_aq(hw, I40E_DEBUG_AQ_COMMAND, (void *)desc_on_ring, buff);\n@@ -904,9 +895,6 @@ enum i40e_status_code i40e_asq_send_command(struct i40e_hw *hw,\n \n \t/* if ready, copy the desc back to temp */\n \tif (i40e_asq_done(hw)) {\n-#ifdef DMA_SYNC_SUPPORT\n-\t\tI40E_DMA_SYNC(&hw->aq.asq.desc_buf, I40E_SYNC_FORKERNEL);\n-#endif /* DMA_SYNC_SUPPORT */\n \t\ti40e_memcpy(desc, desc_on_ring, sizeof(struct i40e_aq_desc),\n \t\t\t    I40E_DMA_TO_NONDMA);\n \t\tif (buff != NULL)\n@@ -995,9 +983,6 @@ enum i40e_status_code i40e_clean_arq_element(struct i40e_hw *hw,\n \tu16 datalen;\n \tu16 flags;\n \tu16 ntu;\n-#ifdef DMA_SYNC_SUPPORT\n-\tI40E_DMA_SYNC(&hw->aq.arq.desc_buf, I40E_SYNC_FORKERNEL);\n-#endif /* DMA_SYNC_SUPPORT */\n \n \t/* take the lock before we start messing with the ring */\n \ti40e_acquire_spinlock(&hw->aq.arq_spinlock);\n@@ -1016,10 +1001,6 @@ enum i40e_status_code i40e_clean_arq_element(struct i40e_hw *hw,\n \t/* now clean the next descriptor */\n \tdesc = I40E_ADMINQ_DESC(hw->aq.arq, ntc);\n \tdesc_idx = ntc;\n-#ifdef DMA_SYNC_SUPPORT\n-\tI40E_DMA_SYNC(&hw->aq.arq.r.arq_bi[desc_idx], I40E_SYNC_FORKERNEL);\n-#endif /* DMA_SYNC_SUPPORT */\n-\n \tflags = LE16_TO_CPU(desc->flags);\n \tif (flags & I40E_AQ_FLAG_ERR) {\n \t\tret_code = I40E_ERR_ADMIN_QUEUE_ERROR;\n",
    "prefixes": [
        "dpdk-dev",
        "03/15"
    ]
}