Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/31625/?format=api
{ "id": 31625, "url": "https://patches.dpdk.org/api/patches/31625/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1511505206-97333-11-git-send-email-jingjing.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1511505206-97333-11-git-send-email-jingjing.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1511505206-97333-11-git-send-email-jingjing.wu@intel.com", "date": "2017-11-24T06:33:22", "name": "[dpdk-dev,v2,10/14] net/avf: enable ops to check queue info and status", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "773c5ff5994399012ff33abccc38fad1c5b09ffc", "submitter": { "id": 47, "url": "https://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1511505206-97333-11-git-send-email-jingjing.wu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/31625/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/31625/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BB335A3E;\n\tFri, 24 Nov 2017 07:42:12 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id A445F2BC5\n\tfor <dev@dpdk.org>; Fri, 24 Nov 2017 07:42:02 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Nov 2017 22:42:02 -0800", "from dpdk2.sh.intel.com ([10.67.118.195])\n\tby fmsmga002.fm.intel.com with ESMTP; 23 Nov 2017 22:42:01 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.44,445,1505804400\"; d=\"scan'208\";\n\ta=\"1247879184\"", "From": "Jingjing Wu <jingjing.wu@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com,\n\twenzhuo.lu@intel.com", "Date": "Fri, 24 Nov 2017 14:33:22 +0800", "Message-Id": "<1511505206-97333-11-git-send-email-jingjing.wu@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1511505206-97333-1-git-send-email-jingjing.wu@intel.com>", "References": "<1508488012-82704-1-git-send-email-jingjing.wu@intel.com>\n\t<1511505206-97333-1-git-send-email-jingjing.wu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 10/14] net/avf: enable ops to check queue info\n\tand status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "- rxq_info_get\n - txq_info_get\n - rx_queue_count\n - rx_descriptor_status\n - tx_descriptor_status\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n drivers/net/avf/avf_ethdev.c | 5 ++\n drivers/net/avf/avf_rxtx.c | 120 +++++++++++++++++++++++++++++++++++++++++++\n drivers/net/avf/avf_rxtx.h | 7 +++\n 3 files changed, 132 insertions(+)", "diff": "diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c\nindex d257d2a..8f382ff 100644\n--- a/drivers/net/avf/avf_ethdev.c\n+++ b/drivers/net/avf/avf_ethdev.c\n@@ -134,6 +134,11 @@ static const struct eth_dev_ops avf_eth_dev_ops = {\n \t.reta_query = avf_dev_rss_reta_query,\n \t.rss_hash_update = avf_dev_rss_hash_update,\n \t.rss_hash_conf_get = avf_dev_rss_hash_conf_get,\n+\t.rxq_info_get = avf_dev_rxq_info_get,\n+\t.txq_info_get = avf_dev_txq_info_get,\n+\t.rx_queue_count = avf_dev_rxq_count,\n+\t.rx_descriptor_status = avf_dev_rx_desc_status,\n+\t.tx_descriptor_status = avf_dev_tx_desc_status,\n \t.mtu_set = avf_dev_mtu_set,\n };\n \ndiff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c\nindex 7d48d38..8e79efd 100644\n--- a/drivers/net/avf/avf_rxtx.c\n+++ b/drivers/net/avf/avf_rxtx.c\n@@ -1413,3 +1413,123 @@ avf_set_tx_function(struct rte_eth_dev *dev)\n \tdev->tx_pkt_burst = avf_xmit_pkts;\n \tdev->tx_pkt_prepare = avf_prep_pkts;\n }\n+\n+void\n+avf_dev_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n+\t\t struct rte_eth_rxq_info *qinfo)\n+{\n+\tstruct avf_rx_queue *rxq;\n+\n+\trxq = dev->data->rx_queues[queue_id];\n+\n+\tqinfo->mp = rxq->mp;\n+\tqinfo->scattered_rx = dev->data->scattered_rx;\n+\tqinfo->nb_desc = rxq->nb_rx_desc;\n+\n+\tqinfo->conf.rx_free_thresh = rxq->rx_free_thresh;\n+\tqinfo->conf.rx_drop_en = TRUE;\n+\tqinfo->conf.rx_deferred_start = rxq->rx_deferred_start;\n+}\n+\n+void\n+avf_dev_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n+\t\t struct rte_eth_txq_info *qinfo)\n+{\n+\tstruct avf_tx_queue *txq;\n+\n+\ttxq = dev->data->tx_queues[queue_id];\n+\n+\tqinfo->nb_desc = txq->nb_tx_desc;\n+\n+\tqinfo->conf.tx_free_thresh = txq->free_thresh;\n+\tqinfo->conf.tx_rs_thresh = txq->rs_thresh;\n+\tqinfo->conf.txq_flags = txq->txq_flags;\n+\tqinfo->conf.tx_deferred_start = txq->tx_deferred_start;\n+}\n+\n+/* Get the number of used descriptors of a rx queue */\n+uint32_t\n+avf_dev_rxq_count(struct rte_eth_dev *dev, uint16_t queue_id)\n+{\n+#define AVF_RXQ_SCAN_INTERVAL 4\n+\tvolatile union avf_rx_desc *rxdp;\n+\tstruct avf_rx_queue *rxq;\n+\tuint16_t desc = 0;\n+\n+\trxq = dev->data->rx_queues[queue_id];\n+\trxdp = &(rxq->rx_ring[rxq->rx_tail]);\n+\twhile ((desc < rxq->nb_rx_desc) &&\n+\t\t((rte_le_to_cpu_64(rxdp->wb.qword1.status_error_len) &\n+\t\tAVF_RXD_QW1_STATUS_MASK) >> AVF_RXD_QW1_STATUS_SHIFT) &\n+\t\t\t\t(1 << AVF_RX_DESC_STATUS_DD_SHIFT)) {\n+\t\t/* Check the DD bit of a rx descriptor of each 4 in a group,\n+\t\t * to avoid checking too frequently and downgrading performance\n+\t\t * too much.\n+\t\t */\n+\t\tdesc += AVF_RXQ_SCAN_INTERVAL;\n+\t\trxdp += AVF_RXQ_SCAN_INTERVAL;\n+\t\tif (rxq->rx_tail + desc >= rxq->nb_rx_desc)\n+\t\t\trxdp = &(rxq->rx_ring[rxq->rx_tail +\n+\t\t\t\t\tdesc - rxq->nb_rx_desc]);\n+\t}\n+\n+\treturn desc;\n+}\n+\n+int\n+avf_dev_rx_desc_status(void *rx_queue, uint16_t offset)\n+{\n+\tstruct avf_rx_queue *rxq = rx_queue;\n+\tvolatile uint64_t *status;\n+\tuint64_t mask;\n+\tuint32_t desc;\n+\n+\tif (unlikely(offset >= rxq->nb_rx_desc))\n+\t\treturn -EINVAL;\n+\n+\tif (offset >= rxq->nb_rx_desc - rxq->nb_rx_hold)\n+\t\treturn RTE_ETH_RX_DESC_UNAVAIL;\n+\n+\tdesc = rxq->rx_tail + offset;\n+\tif (desc >= rxq->nb_rx_desc)\n+\t\tdesc -= rxq->nb_rx_desc;\n+\n+\tstatus = &rxq->rx_ring[desc].wb.qword1.status_error_len;\n+\tmask = rte_le_to_cpu_64((1ULL << AVF_RX_DESC_STATUS_DD_SHIFT)\n+\t\t<< AVF_RXD_QW1_STATUS_SHIFT);\n+\tif (*status & mask)\n+\t\treturn RTE_ETH_RX_DESC_DONE;\n+\n+\treturn RTE_ETH_RX_DESC_AVAIL;\n+}\n+\n+int\n+avf_dev_tx_desc_status(void *tx_queue, uint16_t offset)\n+{\n+\tstruct avf_tx_queue *txq = tx_queue;\n+\tvolatile uint64_t *status;\n+\tuint64_t mask, expect;\n+\tuint32_t desc;\n+\n+\tif (unlikely(offset >= txq->nb_tx_desc))\n+\t\treturn -EINVAL;\n+\n+\tdesc = txq->tx_tail + offset;\n+\t/* go to next desc that has the RS bit */\n+\tdesc = ((desc + txq->rs_thresh - 1) / txq->rs_thresh) *\n+\t\ttxq->rs_thresh;\n+\tif (desc >= txq->nb_tx_desc) {\n+\t\tdesc -= txq->nb_tx_desc;\n+\t\tif (desc >= txq->nb_tx_desc)\n+\t\t\tdesc -= txq->nb_tx_desc;\n+\t}\n+\n+\tstatus = &txq->tx_ring[desc].cmd_type_offset_bsz;\n+\tmask = rte_le_to_cpu_64(AVF_TXD_QW1_DTYPE_MASK);\n+\texpect = rte_cpu_to_le_64(\n+\t\t AVF_TX_DESC_DTYPE_DESC_DONE << AVF_TXD_QW1_DTYPE_SHIFT);\n+\tif ((*status & mask) == expect)\n+\t\treturn RTE_ETH_TX_DESC_DONE;\n+\n+\treturn RTE_ETH_TX_DESC_FULL;\n+}\ndiff --git a/drivers/net/avf/avf_rxtx.h b/drivers/net/avf/avf_rxtx.h\nindex 342b577..8e1025c 100644\n--- a/drivers/net/avf/avf_rxtx.h\n+++ b/drivers/net/avf/avf_rxtx.h\n@@ -175,6 +175,13 @@ uint16_t avf_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t uint16_t nb_pkts);\n void avf_set_rx_function(struct rte_eth_dev *dev);\n void avf_set_tx_function(struct rte_eth_dev *dev);\n+void avf_dev_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n+\t\t\t struct rte_eth_rxq_info *qinfo);\n+void avf_dev_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n+\t\t\t struct rte_eth_txq_info *qinfo);\n+uint32_t avf_dev_rxq_count(struct rte_eth_dev *dev, uint16_t queue_id);\n+int avf_dev_rx_desc_status(void *rx_queue, uint16_t offset);\n+int avf_dev_tx_desc_status(void *tx_queue, uint16_t offset);\n \n static inline\n void avf_dump_rx_descriptor(struct avf_rx_queue *rxq,\n", "prefixes": [ "dpdk-dev", "v2", "10/14" ] }