Patch Comment List
List patch comments
GET /api/patches/315/comments/?format=api
[ { "id": 666, "web_url": "https://patches.dpdk.org/comment/666/", "msgid": "<E115CCD9D858EF4F90C690B0DCB4D89722614366@IRSMSX108.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/E115CCD9D858EF4F90C690B0DCB4D89722614366@IRSMSX108.ger.corp.intel.com", "date": "2014-09-05T16:17:35", "subject": "Re: [dpdk-dev] [PATCH v3 4/6] mbuf: remove the rte_pktmbuf structure", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson\n> Sent: Thursday, September 04, 2014 2:26 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH v3 4/6] mbuf: remove the rte_pktmbuf\n> structure\n> \n> From: Olivier Matz <olivier.matz@6wind.com>\n> \n> The rte_pktmbuf structure was initially included in the rte_mbuf\n> structure. This was needed when there was 2 types of mbuf (ctrl and\n> packet). As the control mbuf has been removed, we can merge the\n> rte_pktmbuf into the rte_mbuf structure.\n> \n> Advantages of doing this:\n> - the access to mbuf fields is easier (ex: m->data instead of m->pkt.data)\n> - make the structure more consistent: for instance, there was no reason\n> to have the ol_flags field in rte_mbuf\n> - it will allow a deeper reorganization of the rte_mbuf structure in the\n> next commits, allowing to gain several bytes in it\n> \n> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n> \n> Updated to work with latest code, and to include new example apps.\n> \n> Changes in V2:\n> * Further updates to apply to latest HEAD on master\n> \n> Changes in V3:\n> * Updated to compile cleanly on 1.7.1\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAcked-by Pablo de Lara <pablo.de.lara.guarch@intel.com>", "headers": { "Return-Path": "<pablo.de.lara.guarch@intel.com>", "Received": [ "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 2A96EA547\n\tfor <dev@dpdk.org>; Fri, 5 Sep 2014 18:12:52 +0200 (CEST)", "from azsmga001.ch.intel.com ([10.2.17.19])\n\tby orsmga101.jf.intel.com with ESMTP; 05 Sep 2014 09:17:38 -0700", "from irsmsx103.ger.corp.intel.com ([163.33.3.157])\n\tby azsmga001.ch.intel.com with ESMTP; 05 Sep 2014 09:17:37 -0700", "from irsmsx154.ger.corp.intel.com (163.33.192.96) by\n\tIRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Fri, 5 Sep 2014 17:17:36 +0100", "from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by\n\tIRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id\n\t14.03.0195.001; Fri, 5 Sep 2014 17:17:36 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,474,1406617200\"; d=\"scan'208\";a=\"475485919\"", "From": "\"De Lara Guarch, Pablo\" <pablo.de.lara.guarch@intel.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v3 4/6] mbuf: remove the rte_pktmbuf\n\tstructure", "Thread-Index": "AQHPyEPj+icO2KrCJ0WyC585o96lKZvyuSDw", "Date": "Fri, 5 Sep 2014 16:17:35 +0000", "Message-ID": "<E115CCD9D858EF4F90C690B0DCB4D89722614366@IRSMSX108.ger.corp.intel.com>", "References": "<1409240559-14447-5-git-send-email-bruce.richardson@intel.com>\n\t<1409837138-4401-1-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409837138-4401-1-git-send-email-bruce.richardson@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v3 4/6] mbuf: remove the rte_pktmbuf structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Fri, 05 Sep 2014 16:12:53 -0000" }, "addressed": null }, { "id": 674, "web_url": "https://patches.dpdk.org/comment/674/", "msgid": "<540D68FD.8040602@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/540D68FD.8040602@6wind.com", "date": "2014-09-08T08:29:49", "subject": "Re: [dpdk-dev] [PATCH v3 4/6] mbuf: remove the rte_pktmbuf structure", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "content": "On 09/04/2014 03:25 PM, Bruce Richardson wrote:\n> From: Olivier Matz <olivier.matz@6wind.com>\n> \n> The rte_pktmbuf structure was initially included in the rte_mbuf\n> structure. This was needed when there was 2 types of mbuf (ctrl and\n> packet). As the control mbuf has been removed, we can merge the\n> rte_pktmbuf into the rte_mbuf structure.\n> \n> Advantages of doing this:\n> - the access to mbuf fields is easier (ex: m->data instead of m->pkt.data)\n> - make the structure more consistent: for instance, there was no reason\n> to have the ol_flags field in rte_mbuf\n> - it will allow a deeper reorganization of the rte_mbuf structure in the\n> next commits, allowing to gain several bytes in it\n> \n> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n> \n> Updated to work with latest code, and to include new example apps.\n> \n> Changes in V2:\n> * Further updates to apply to latest HEAD on master\n> \n> Changes in V3:\n> * Updated to compile cleanly on 1.7.1\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nIn app/test/packet_burst_generator.c, there is one remaining reference\nto \"pkt.\" in a comment:\n\n #define RTE_MAX_SEGS_PER_PKT 255 /**< pkt.nb_segs is a 8-bit unsigned\nchar. */\n\n\nAcked-by: Olivier Matz <olivier.matz@6wind.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E82D06886;\n\tMon, 8 Sep 2014 10:25:01 +0200 (CEST)", "from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])\n\tby dpdk.org (Postfix) with ESMTP id ECF50683A\n\tfor <dev@dpdk.org>; Mon, 8 Sep 2014 10:24:59 +0200 (CEST)", "from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]\n\thelo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.80) (envelope-from <olivier.matz@6wind.com>)\n\tid 1XQuND-0007eh-GE; Mon, 08 Sep 2014 10:32:34 +0200" ], "Message-ID": "<540D68FD.8040602@6wind.com>", "Date": "Mon, 08 Sep 2014 10:29:49 +0200", "From": "Olivier MATZ <olivier.matz@6wind.com>", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Icedove/24.5.0", "MIME-Version": "1.0", "To": "Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org", "References": "<1409240559-14447-5-git-send-email-bruce.richardson@intel.com>\n\t<1409837138-4401-1-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409837138-4401-1-git-send-email-bruce.richardson@intel.com>", "Content-Type": "text/plain; charset=ISO-8859-1", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v3 4/6] mbuf: remove the rte_pktmbuf structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]