Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3115/?format=api
{ "id": 3115, "url": "https://patches.dpdk.org/api/patches/3115/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1423579997-22014-1-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1423579997-22014-1-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1423579997-22014-1-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2015-02-10T14:53:17", "name": "[dpdk-dev] testpmd: force user to stop forwarding when changing port/core list", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5cea134407106e3d28df78e99b242fadfc090021", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1423579997-22014-1-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3115/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1DE333208;\n\tTue, 10 Feb 2015 15:53:34 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 0A9EFDE0\n\tfor <dev@dpdk.org>; Tue, 10 Feb 2015 15:53:31 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 10 Feb 2015 06:53:18 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 10 Feb 2015 06:53:18 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt1AErHde021404 for <dev@dpdk.org>; Tue, 10 Feb 2015 14:53:17 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t1AErHCL022051\n\tfor <dev@dpdk.org>; Tue, 10 Feb 2015 14:53:17 GMT", "(from pdelarax@localhost)\n\tby sivswdev02.ir.intel.com with id t1AErHQZ022047\n\tfor dev@dpdk.org; Tue, 10 Feb 2015 14:53:17 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,551,1418112000\"; d=\"scan'208\";a=\"664317647\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 10 Feb 2015 14:53:17 +0000", "Message-Id": "<1423579997-22014-1-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] testpmd: force user to stop forwarding when\n\tchanging port/core list", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Testpmd has the capability of changing the forwarding cores and ports in runtime.\nIf these are changed when forwarding, two issues may be encountered:\n\n- If \"show config fwd\" is used, changes made in the core list are applied.\n Therefore, trying to stop forwarding may hang testpmd,\n since it could be waiting for cores to stop that are not actually running anything\n\n- If the port list is changed, when stopping forwarding,\n it may miss the stats of some of the ports that were actually being used.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n app/test-pmd/cmdline.c | 9 +++++++++\n 1 files changed, 9 insertions(+), 0 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 590e427..46d4bf9 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -2316,6 +2316,11 @@ static void cmd_set_list_parsed(void *parsed_result,\n \t} parsed_items;\n \tunsigned int nb_item;\n \n+\tif (test_done == 0) {\n+\t\tprintf(\"Please stop forwarding first\\n\");\n+\t\treturn;\n+\t}\n+\n \tres = parsed_result;\n \tif (!strcmp(res->list_name, \"corelist\")) {\n \t\tnb_item = parse_item_list(res->list_of_items, \"core\",\n@@ -2370,6 +2375,10 @@ static void cmd_set_mask_parsed(void *parsed_result,\n {\n \tstruct cmd_setmask_result *res = parsed_result;\n \n+\tif (test_done == 0) {\n+\t\tprintf(\"Please stop forwarding first\\n\");\n+\t\treturn;\n+\t}\n \tif (!strcmp(res->mask, \"coremask\"))\n \t\tset_fwd_lcores_mask(res->hexavalue);\n \telse if (!strcmp(res->mask, \"portmask\"))\n", "prefixes": [ "dpdk-dev" ] }