Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/31144/?format=api
{ "id": 31144, "url": "https://patches.dpdk.org/api/patches/31144/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20171103005100.44633-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171103005100.44633-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171103005100.44633-1-ferruh.yigit@intel.com", "date": "2017-11-03T00:51:00", "name": "[dpdk-dev,v2] igb_uio: add config option to control reset", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "d3e73855b73712564cb6301a62c5a0daa87152d2", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20171103005100.44633-1-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/31144/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/31144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D8F31B64E;\n\tFri, 3 Nov 2017 01:51:08 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id A23BA1B3DE;\n\tFri, 3 Nov 2017 01:51:06 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga104.jf.intel.com with ESMTP; 02 Nov 2017 17:51:05 -0700", "from silpixa00372839.ir.intel.com (HELO\n\tsilpixa00372839.ger.corp.intel.com) ([10.237.222.154])\n\tby fmsmga004.fm.intel.com with ESMTP; 02 Nov 2017 17:51:02 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.44,336,1505804400\"; d=\"scan'208\";a=\"331424892\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "Cc": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org,\n\tJianfeng Tan <jianfeng.tan@intel.com>,\n\tJingjing Wu <jingjing.wu@intel.com>, \n\tShijith Thotton <shijith.thotton@caviumnetworks.com>,\n\tGregory Etelson <gregory@weka.io>,\n\tHarish Patil <harish.patil@cavium.com>, \n\tGeorge Prekas <george.prekas@epfl.ch>,\n\tSergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,\n\tRasesh Mody <rasesh.mody@cavium.com>", "Date": "Fri, 3 Nov 2017 00:51:00 +0000", "Message-Id": "<20171103005100.44633-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20171103003005.44339-1-ferruh.yigit@intel.com>", "References": "<20171103003005.44339-1-ferruh.yigit@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] igb_uio: add config option to control reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding a compile time configuration option to control device reset done\nduring DPDK application exit.\n\nConfig option is CONFIG_RTE_EAL_IGB_UIO_RESET and enabled by default,\nso by default reset will happen. Having this reset is safer to be sure\ndevice left in a proper case.\n\nBut for special cases [1] it is possible to disable the config option\nto prevent the device reset.\n\n[1]\nhttp://dpdk.org/ml/archives/dev/2017-November/080927.html\n\nFixes: b58eedfc7dd5 (\"igb_uio: issue FLR during open and release of device file\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: Jianfeng Tan <jianfeng.tan@intel.com>\nCc: Jingjing Wu <jingjing.wu@intel.com>\nCc: Shijith Thotton <shijith.thotton@caviumnetworks.com>\nCc: Gregory Etelson <gregory@weka.io>\nCc: Harish Patil <harish.patil@cavium.com>\nCc: George Prekas <george.prekas@epfl.ch>\nCc: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>\nCc: Rasesh Mody <rasesh.mody@cavium.com>\n\nv2:\n* fix typo in commit log\n---\n config/common_base | 1 +\n config/common_linuxapp | 1 +\n lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 ++\n 3 files changed, 4 insertions(+)", "diff": "diff --git a/config/common_base b/config/common_base\nindex 82ee75456..2a9947420 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -102,6 +102,7 @@ CONFIG_RTE_LIBEAL_USE_HPET=n\n CONFIG_RTE_EAL_ALLOW_INV_SOCKET_ID=n\n CONFIG_RTE_EAL_ALWAYS_PANIC_ON_ERROR=n\n CONFIG_RTE_EAL_IGB_UIO=n\n+CONFIG_RTE_EAL_IGB_UIO_RESET=n\n CONFIG_RTE_EAL_VFIO=n\n CONFIG_RTE_MALLOC_DEBUG=n\n CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n\ndiff --git a/config/common_linuxapp b/config/common_linuxapp\nindex 74c7d64ec..b3a602909 100644\n--- a/config/common_linuxapp\n+++ b/config/common_linuxapp\n@@ -37,6 +37,7 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y\n \n CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y\n CONFIG_RTE_EAL_IGB_UIO=y\n+CONFIG_RTE_EAL_IGB_UIO_RESET=y\n CONFIG_RTE_EAL_VFIO=y\n CONFIG_RTE_KNI_KMOD=y\n CONFIG_RTE_LIBRTE_KNI=y\ndiff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c\nindex fd320d87d..0325722c0 100644\n--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c\n+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c\n@@ -360,7 +360,9 @@ igbuio_pci_release(struct uio_info *info, struct inode *inode)\n \t/* stop the device from further DMA */\n \tpci_clear_master(dev);\n \n+#ifdef RTE_EAL_IGB_UIO_RESET\n \tpci_reset_function(dev);\n+#endif\n \n \treturn 0;\n }\n", "prefixes": [ "dpdk-dev", "v2" ] }