Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 30765,
    "url": "https://patches.dpdk.org/api/patches/30765/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20171024090957.114392-1-jasvinder.singh@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20171024090957.114392-1-jasvinder.singh@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20171024090957.114392-1-jasvinder.singh@intel.com",
    "date": "2017-10-24T09:09:57",
    "name": "[dpdk-dev] examples/qos_sched: fix uninitialized scalar variable",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ba7feafccf506ae137f4033e98bd4a7b7011620b",
    "submitter": {
        "id": 285,
        "url": "https://patches.dpdk.org/api/people/285/?format=api",
        "name": "Jasvinder Singh",
        "email": "jasvinder.singh@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20171024090957.114392-1-jasvinder.singh@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/30765/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/30765/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 442E31B77C;\n\tTue, 24 Oct 2017 10:57:24 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 4074C1B779;\n\tTue, 24 Oct 2017 10:57:22 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga105.jf.intel.com with ESMTP; 24 Oct 2017 01:57:20 -0700",
            "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby fmsmga002.fm.intel.com with ESMTP; 24 Oct 2017 01:57:19 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.43,427,1503385200\"; d=\"scan'208\";\n\ta=\"1234510616\"",
        "From": "Jasvinder Singh <jasvinder.singh@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com, ferruh.yigit@intel.com,\n\tjohn.mcnamara@intel.com, stable@dpdk.org",
        "Date": "Tue, 24 Oct 2017 10:09:57 +0100",
        "Message-Id": "<20171024090957.114392-1-jasvinder.singh@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20171023103600.89883-1-jasvinder.singh@intel.com>",
        "References": "<20171023103600.89883-1-jasvinder.singh@intel.com>",
        "Subject": "[dpdk-dev] [PATCH] examples/qos_sched: fix uninitialized scalar\n\tvariable",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix problem with uninitialized rx/tx deferred_start flags of the struct\nrte_eth_rxconf/txconf by initializing with 0 value (deferred start of\nthe rx/tx queues is turned off). This setting allows device rx/tx\nqueues to start with rte_eth_dev_start().\n\nCoverity issue: 194999, 195009 (Uninitialized scalar variable)\nFixes: de3cfa2c9823 (\"sched: initial import\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n examples/qos_sched/init.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c\nindex 004ac54..038f042 100644\n--- a/examples/qos_sched/init.c\n+++ b/examples/qos_sched/init.c\n@@ -118,6 +118,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)\n \trx_conf.rx_thresh.wthresh = rx_thresh.wthresh;\n \trx_conf.rx_free_thresh = 32;\n \trx_conf.rx_drop_en = 0;\n+\trx_conf.rx_deferred_start = 0;\n \n \ttx_conf.tx_thresh.pthresh = tx_thresh.pthresh;\n \ttx_conf.tx_thresh.hthresh = tx_thresh.hthresh;\n@@ -125,6 +126,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)\n \ttx_conf.tx_free_thresh = 0;\n \ttx_conf.tx_rs_thresh = 0;\n \ttx_conf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS;\n+\ttx_conf.tx_deferred_start = 0;\n \n \t/* init port */\n \tRTE_LOG(INFO, APP, \"Initializing port %\"PRIu16\"... \", portid);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}