Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30037/?format=api
{ "id": 30037, "url": "https://patches.dpdk.org/api/patches/30037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1507634341-72277-4-git-send-email-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1507634341-72277-4-git-send-email-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1507634341-72277-4-git-send-email-cristian.dumitrescu@intel.com", "date": "2017-10-10T11:18:59", "name": "[dpdk-dev,V2,3/5] test-pipeline: update due to api changes in librte_table", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7deaa9dab1df736a931fbfbe4ce33420d70b83d5", "submitter": { "id": 19, "url": "https://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1507634341-72277-4-git-send-email-cristian.dumitrescu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/30037/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/30037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7485F1B28B;\n\tTue, 10 Oct 2017 13:19:25 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 8625B1B246\n\tfor <dev@dpdk.org>; Tue, 10 Oct 2017 13:19:19 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Oct 2017 04:19:06 -0700", "from silpixa00382658.ir.intel.com ([10.237.223.29])\n\tby fmsmga006.fm.intel.com with ESMTP; 10 Oct 2017 04:19:05 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,504,1500966000\"; d=\"scan'208\";a=\"161404171\"", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 10 Oct 2017 12:18:59 +0100", "Message-Id": "<1507634341-72277-4-git-send-email-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1507634341-72277-1-git-send-email-cristian.dumitrescu@intel.com>", "References": "<1503582789-121358-2-git-send-email-cristian.dumitrescu@intel.com>\n\t<1507634341-72277-1-git-send-email-cristian.dumitrescu@intel.com>", "Subject": "[dpdk-dev] [PATCH V2 3/5] test-pipeline: update due to api changes\n\tin librte_table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\nChanges in V2:\n- None\n\n test/test-pipeline/main.h | 5 +-\n test/test-pipeline/pipeline_hash.c | 107 +++++--------------------------------\n 2 files changed, 18 insertions(+), 94 deletions(-)", "diff": "diff --git a/test/test-pipeline/main.h b/test/test-pipeline/main.h\nindex 3685849..26395a3 100644\n--- a/test/test-pipeline/main.h\n+++ b/test/test-pipeline/main.h\n@@ -131,7 +131,10 @@ enum {\n \n void app_main_loop_rx(void);\n void app_main_loop_rx_metadata(void);\n-uint64_t test_hash(void *key, uint32_t key_size, uint64_t seed);\n+uint64_t test_hash(void *key,\n+\tvoid *key_mask,\n+\tuint32_t key_size,\n+\tuint64_t seed);\n \n void app_main_loop_worker(void);\n void app_main_loop_worker_pipeline_stub(void);\ndiff --git a/test/test-pipeline/pipeline_hash.c b/test/test-pipeline/pipeline_hash.c\nindex 991e381..edc1663 100644\n--- a/test/test-pipeline/pipeline_hash.c\n+++ b/test/test-pipeline/pipeline_hash.c\n@@ -169,23 +169,23 @@ app_main_loop_worker_pipeline_hash(void) {\n \t\t\t\t\"ring %d\\n\", i);\n \t}\n \n+\tstruct rte_table_hash_params table_hash_params = {\n+\t\t.name = \"TABLE\",\n+\t\t.key_size = key_size,\n+\t\t.key_offset = APP_METADATA_OFFSET(32),\n+\t\t.key_mask = NULL,\n+\t\t.n_keys = 1 << 24,\n+\t\t.n_buckets = 1 << 22,\n+\t\t.f_hash = test_hash,\n+\t\t.seed = 0,\n+\t};\n+\n \t/* Table configuration */\n \tswitch (app.pipeline_type) {\n \tcase e_APP_PIPELINE_HASH_KEY8_EXT:\n \tcase e_APP_PIPELINE_HASH_KEY16_EXT:\n \tcase e_APP_PIPELINE_HASH_KEY32_EXT:\n \t{\n-\t\tstruct rte_table_hash_ext_params table_hash_params = {\n-\t\t\t.key_size = key_size,\n-\t\t\t.n_keys = 1 << 24,\n-\t\t\t.n_buckets = 1 << 22,\n-\t\t\t.n_buckets_ext = 1 << 21,\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_ext_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -204,16 +204,6 @@ app_main_loop_worker_pipeline_hash(void) {\n \tcase e_APP_PIPELINE_HASH_KEY16_LRU:\n \tcase e_APP_PIPELINE_HASH_KEY32_LRU:\n \t{\n-\t\tstruct rte_table_hash_lru_params table_hash_params = {\n-\t\t\t.key_size = key_size,\n-\t\t\t.n_keys = 1 << 24,\n-\t\t\t.n_buckets = 1 << 22,\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_lru_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -230,16 +220,6 @@ app_main_loop_worker_pipeline_hash(void) {\n \n \tcase e_APP_PIPELINE_HASH_SPEC_KEY8_EXT:\n \t{\n-\t\tstruct rte_table_hash_key8_ext_params table_hash_params = {\n-\t\t\t.n_entries = 1 << 24,\n-\t\t\t.n_entries_ext = 1 << 23,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t\t.key_mask = NULL,\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_key8_ext_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -256,15 +236,6 @@ app_main_loop_worker_pipeline_hash(void) {\n \n \tcase e_APP_PIPELINE_HASH_SPEC_KEY8_LRU:\n \t{\n-\t\tstruct rte_table_hash_key8_lru_params table_hash_params = {\n-\t\t\t.n_entries = 1 << 24,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t\t.key_mask = NULL,\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_key8_lru_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -281,16 +252,6 @@ app_main_loop_worker_pipeline_hash(void) {\n \n \tcase e_APP_PIPELINE_HASH_SPEC_KEY16_EXT:\n \t{\n-\t\tstruct rte_table_hash_key16_ext_params table_hash_params = {\n-\t\t\t.n_entries = 1 << 24,\n-\t\t\t.n_entries_ext = 1 << 23,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t\t.key_mask = NULL,\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_key16_ext_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -307,15 +268,6 @@ app_main_loop_worker_pipeline_hash(void) {\n \n \tcase e_APP_PIPELINE_HASH_SPEC_KEY16_LRU:\n \t{\n-\t\tstruct rte_table_hash_key16_lru_params table_hash_params = {\n-\t\t\t.n_entries = 1 << 24,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t\t.key_mask = NULL,\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_key16_lru_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -332,15 +284,6 @@ app_main_loop_worker_pipeline_hash(void) {\n \n \tcase e_APP_PIPELINE_HASH_SPEC_KEY32_EXT:\n \t{\n-\t\tstruct rte_table_hash_key32_ext_params table_hash_params = {\n-\t\t\t.n_entries = 1 << 24,\n-\t\t\t.n_entries_ext = 1 << 23,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_key32_ext_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -358,14 +301,6 @@ app_main_loop_worker_pipeline_hash(void) {\n \n \tcase e_APP_PIPELINE_HASH_SPEC_KEY32_LRU:\n \t{\n-\t\tstruct rte_table_hash_key32_lru_params table_hash_params = {\n-\t\t\t.n_entries = 1 << 24,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n \t\t\t.ops = &rte_table_hash_key32_lru_ops,\n \t\t\t.arg_create = &table_hash_params,\n@@ -390,23 +325,8 @@ app_main_loop_worker_pipeline_hash(void) {\n \tcase e_APP_PIPELINE_HASH_CUCKOO_KEY112:\n \tcase e_APP_PIPELINE_HASH_CUCKOO_KEY128:\n \t{\n-\t\tchar hash_name[RTE_HASH_NAMESIZE];\n-\n-\t\tsnprintf(hash_name, sizeof(hash_name), \"RTE_TH_CUCKOO_%d\",\n-\t\t\tapp.pipeline_type);\n-\n-\t\tstruct rte_table_hash_cuckoo_params table_hash_params = {\n-\t\t\t.key_size = key_size,\n-\t\t\t.n_keys = (1 << 24) + 1,\n-\t\t\t.f_hash = test_hash,\n-\t\t\t.seed = 0,\n-\t\t\t.signature_offset = APP_METADATA_OFFSET(0),\n-\t\t\t.key_offset = APP_METADATA_OFFSET(32),\n-\t\t\t.name = hash_name,\n-\t\t};\n-\n \t\tstruct rte_pipeline_table_params table_params = {\n-\t\t\t.ops = &rte_table_hash_cuckoo_dosig_ops,\n+\t\t\t.ops = &rte_table_hash_cuckoo_ops,\n \t\t\t.arg_create = &table_hash_params,\n \t\t\t.f_action_hit = NULL,\n \t\t\t.f_action_miss = NULL,\n@@ -477,6 +397,7 @@ app_main_loop_worker_pipeline_hash(void) {\n \n uint64_t test_hash(\n \tvoid *key,\n+\t__attribute__((unused)) void *key_mask,\n \t__attribute__((unused)) uint32_t key_size,\n \t__attribute__((unused)) uint64_t seed)\n {\n@@ -539,7 +460,7 @@ app_main_loop_rx_metadata(void) {\n \t\t\t} else\n \t\t\t\tcontinue;\n \n-\t\t\t*signature = test_hash(key, 0, 0);\n+\t\t\t*signature = test_hash(key, NULL, 0, 0);\n \t\t}\n \n \t\tdo {\n", "prefixes": [ "dpdk-dev", "V2", "3/5" ] }