Patch Comment List
List patch comments
GET /api/patches/3/comments/?format=api&order=-submitter
[ { "id": 943, "web_url": "https://patches.dpdk.org/comment/943/", "msgid": "<CAJPbnDq85CtCEreE=BrpkusV-4ZSXLQd86NdQs_k67qoe6RAxw@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJPbnDq85CtCEreE=BrpkusV-4ZSXLQd86NdQs_k67qoe6RAxw@mail.gmail.com", "date": "2014-09-24T03:37:02", "subject": "Re: [dpdk-dev] [PATCH] pcap: set in_port value in packet mbuf data\n\twhen each packet is received", "submitter": { "id": 5, "url": "https://patches.dpdk.org/api/people/5/?format=api", "name": "Saori USAMI", "email": "susami@igel.co.jp" }, "content": "Hi,\n\nHow about the following patch for the next DPDK release?\n\nThanks,\nSaori\n\n2014-09-05 19:10 GMT+09:00 Saori USAMI <susami@igel.co.jp>:\n\n> The pkt.in_port parameter in mbuf should be set with an input port id\n> because DPDK apps may use it to know where each packet came from.\n>\n> Signed-off-by: Saori USAMI <susami@igel.co.jp>\n> ---\n> lib/librte_pmd_pcap/rte_eth_pcap.c | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c\n> b/lib/librte_pmd_pcap/rte_eth_pcap.c\n> index eebe768..cfd3de4 100644\n> --- a/lib/librte_pmd_pcap/rte_eth_pcap.c\n> +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c\n> @@ -63,6 +63,7 @@ static uint64_t hz;\n>\n> struct pcap_rx_queue {\n> pcap_t *pcap;\n> + uint8_t in_port;\n> struct rte_mempool *mb_pool;\n> volatile unsigned long rx_pkts;\n> volatile unsigned long err_pkts;\n> @@ -154,6 +155,7 @@ eth_pcap_rx(void *queue,\n> rte_memcpy(mbuf->pkt.data, packet, header.len);\n> mbuf->pkt.data_len = (uint16_t)header.len;\n> mbuf->pkt.pkt_len = mbuf->pkt.data_len;\n> + mbuf->pkt.in_port = pcap_q->in_port;\n> bufs[num_rx] = mbuf;\n> num_rx++;\n> } else {\n> @@ -373,6 +375,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,\n> struct pcap_rx_queue *pcap_q = &internals->rx_queue[rx_queue_id];\n> pcap_q->mb_pool = mb_pool;\n> dev->data->rx_queues[rx_queue_id] = pcap_q;\n> + pcap_q->in_port = dev->data->port_id;\n> return 0;\n> }\n>\n> --\n> 1.9.1\n>\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4C2EB5953;\n\tWed, 24 Sep 2014 05:30:54 +0200 (CEST)", "from mail-la0-f46.google.com (mail-la0-f46.google.com\n\t[209.85.215.46]) by dpdk.org (Postfix) with ESMTP id B7AAC137D\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 05:30:51 +0200 (CEST)", "by mail-la0-f46.google.com with SMTP id q1so9305866lam.19\n\tfor <dev@dpdk.org>; Tue, 23 Sep 2014 20:37:02 -0700 (PDT)", "by 10.25.44.74 with HTTP; Tue, 23 Sep 2014 20:37:02 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:mime-version:in-reply-to:references:date\n\t:message-id:subject:from:to:content-type;\n\tbh=Dl9X9Q3KHNMLg6PF4BSsK9v5YHOqjwyjHe5NtoqDKiw=;\n\tb=SjTrjNep1il4vVdPN5pu/8josrVGSCcx5SQ9wqlvokGM6pAXzdNSxNOghnZ1dur+jC\n\tM5TRgvHkFmU2M76OqKeLb62m20i4HvKTxPhC0ofwPw963PLAqTzAxkHR+V9Osuu0bVCo\n\tlvaebGKPPefSOb7o7T0KBQKjERm2aR8kz1u3mSimKydK5NzYFkReqMe5J9Kv9vi26VJz\n\t4n/gedGUQAklHtGTp9yQqalXk152WsS1JGwizi/XNkEssZlUdebPoszMUBudW7R1n27x\n\tObgAWcf9N3+ViVlFaich29UvdYy3dhy08pQin8qCNWQrekNciaFwl3UINElgfo0VL8NA\n\t4DfA==", "X-Gm-Message-State": "ALoCoQkMMSTM46ZK67KankPpa5iQmFYKRlFq9B4JXsTrbII3lr+lhUpv4spje7iKBq/HW5fQh4c0", "MIME-Version": "1.0", "X-Received": "by 10.152.28.38 with SMTP id y6mr3534775lag.90.1411529822496;\n\tTue, 23 Sep 2014 20:37:02 -0700 (PDT)", "In-Reply-To": "<1409911836-17294-1-git-send-email-susami@igel.co.jp>", "References": "<1409911836-17294-1-git-send-email-susami@igel.co.jp>", "Date": "Wed, 24 Sep 2014 12:37:02 +0900", "Message-ID": "<CAJPbnDq85CtCEreE=BrpkusV-4ZSXLQd86NdQs_k67qoe6RAxw@mail.gmail.com>", "From": "Saori USAMI <susami@igel.co.jp>", "To": "dev@dpdk.org", "Content-Type": "text/plain; charset=UTF-8", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH] pcap: set in_port value in packet mbuf data\n\twhen each packet is received", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1237, "web_url": "https://patches.dpdk.org/comment/1237/", "msgid": "<12607741.zAISA8FkEd@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/12607741.zAISA8FkEd@xps13", "date": "2014-09-29T14:39:11", "subject": "Re: [dpdk-dev] [PATCH] pcap: set in_port value in packet mbuf data\n\twhen each packet is received", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "> The pkt.in_port parameter in mbuf should be set with an input port id\n> because DPDK apps may use it to know where each packet came from.\n> \n> Signed-off-by: Saori USAMI <susami@igel.co.jp>\n\nAcked, adapted to mbuf rework and applied.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DCDC07E1C;\n\tMon, 29 Sep 2014 16:32:37 +0200 (CEST)", "from mail-we0-f177.google.com (mail-we0-f177.google.com\n\t[74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 578BE7E18\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 16:32:36 +0200 (CEST)", "by mail-we0-f177.google.com with SMTP id t60so13180782wes.36\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 07:39:12 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tga9sm15904760wjb.45.2014.09.29.07.39.11 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 29 Sep 2014 07:39:11 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=zUnKuBLuvzL3tBNh9vKJUSByftA6rwLQILlgWVDgPDU=;\n\tb=gEBIhPHr+qSBJCdRGWziE+sDDE8gid00ga2k6iBXzZo8pHUjaPakcpKc0SBzC4rju2\n\tK5czaWKfhJG6zSAA7hrPrAcMrE3j7FgrnY7XNvTcamUJl7w0aIBPU6qIfcE5Qhrnl8JD\n\tdwCe8RvS03j0oApkj5XkO3coIjZnYpWBMPV6i1I3bnVpHq6f+zvDaqTeKR3u5AuSOqwN\n\tCBCUpCcyV0SqPdaqQXNdVsyHdEJ9Kfyy9IiCc9tcoVXnzy8r+izQgTSiG+xfNaPFruW5\n\tkic+IbdkPnq9ghlg+KKwqgsBCotm6oX1s2rQ2waIWDrrdeLAuO3PO/eVg2dSh3+c/vq8\n\tcODg==", "X-Gm-Message-State": "ALoCoQm5AEqWAOWiYfIP1NRJxgEdZ9HCx5pRyn0cISSHa6uer+XUfOO8LW/TpGc8HbrWNCq/jxkO", "X-Received": "by 10.194.158.101 with SMTP id wt5mr46120890wjb.79.1412001552629;\n\tMon, 29 Sep 2014 07:39:12 -0700 (PDT)", "Date": "Mon, 29 Sep 2014 07:39:11 -0700 (PDT)", "X-Google-Original-Date": "Mon, 29 Sep 2014 16:39 +0200", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Saori USAMI <susami@igel.co.jp>", "Message-ID": "<12607741.zAISA8FkEd@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1409911836-17294-1-git-send-email-susami@igel.co.jp>", "References": "<1409911836-17294-1-git-send-email-susami@igel.co.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] pcap: set in_port value in packet mbuf data\n\twhen each packet is received", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]