Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 29334,
    "url": "https://patches.dpdk.org/api/patches/29334/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1506606959-76230-9-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1506606959-76230-9-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1506606959-76230-9-git-send-email-jianfeng.tan@intel.com",
    "date": "2017-09-28T13:55:55",
    "name": "[dpdk-dev,v2,08/12] bus/vdev: scan and probe vdev in secondary processes",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "318339442dc050ab60f6167d92443037f8b6730f",
    "submitter": {
        "id": 313,
        "url": "https://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1506606959-76230-9-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/29334/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/29334/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 846151B206;\n\tThu, 28 Sep 2017 15:55:03 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 17DF51B1F6\n\tfor <dev@dpdk.org>; Thu, 28 Sep 2017 15:54:57 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2017 06:54:57 -0700",
            "from dpdk06.sh.intel.com ([10.67.110.196])\n\tby fmsmga006.fm.intel.com with ESMTP; 28 Sep 2017 06:54:55 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.42,450,1500966000\"; d=\"scan'208\";a=\"157117729\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "bruce.richardson@intel.com, konstantin.ananyev@intel.com,\n\tpablo.de.lara.guarch@intel.com, thomas@monjalon.net,\n\tyliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com,\n\tferruh.yigit@intel.com, Jianfeng Tan <jianfeng.tan@intel.com>",
        "Date": "Thu, 28 Sep 2017 13:55:55 +0000",
        "Message-Id": "<1506606959-76230-9-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1506606959-76230-1-git-send-email-jianfeng.tan@intel.com>",
        "References": "<1503654052-84730-1-git-send-email-jianfeng.tan@intel.com>\n\t<1506606959-76230-1-git-send-email-jianfeng.tan@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 08/12] bus/vdev: scan and probe vdev in\n\tsecondary processes",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Base on primary/secondary communication channel, we add vdev action\nto scan virtual devices in secondary processes.\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/bus/vdev/vdev.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++--\n 1 file changed, 100 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex e0ba0da..1d1690f 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -104,7 +104,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)\n \n \tname = rte_vdev_device_name(dev);\n \n-\tVDEV_LOG(DEBUG, \"Search driver %s to probe device %s\\n\", name,\n+\tVDEV_LOG(DEBUG, \"Search driver %s to probe device %s\", name,\n \t\trte_vdev_device_name(dev));\n \n \tif (vdev_parse(name, &driver))\n@@ -190,7 +190,7 @@ rte_vdev_init(const char *name, const char *args)\n \tret = vdev_probe_all_drivers(dev);\n \tif (ret) {\n \t\tif (ret > 0)\n-\t\t\tVDEV_LOG(ERR, \"no driver found for %s\\n\", name);\n+\t\t\tVDEV_LOG(ERR, \"no driver found for %s\", name);\n \t\tgoto fail;\n \t}\n \n@@ -213,7 +213,7 @@ vdev_remove_driver(struct rte_vdev_device *dev)\n \tconst struct rte_vdev_driver *driver;\n \n \tif (!dev->device.driver) {\n-\t\tVDEV_LOG(DEBUG, \"no driver attach to device %s\\n\", name);\n+\t\tVDEV_LOG(DEBUG, \"no driver attach to device %s\", name);\n \t\treturn 1;\n \t}\n \n@@ -252,12 +252,105 @@ rte_vdev_uninit(const char *name)\n \treturn 0;\n }\n \n+struct vdev_action_params {\n+#define VDEV_SCAN_REQUEST\t1\n+#define VDEV_SCAN_RESPONSE\t2\n+\tint type;\n+\tchar name[32];\n+};\n+\n+static int vdev_plug(struct rte_device *dev);\n+\n+static int\n+vdev_action(const void *params, int len,\n+\t    int fds[] __rte_unused,\n+\t    int fds_num __rte_unused)\n+{\n+\tstruct rte_vdev_device *dev;\n+\tstruct rte_devargs *devargs;\n+\tstruct vdev_action_params ou_params;\n+\tconst struct vdev_action_params *in_params = params;\n+\n+\tswitch (in_params->type) {\n+\tcase VDEV_SCAN_REQUEST:\n+\t\tou_params.type = VDEV_SCAN_RESPONSE;\n+\t\tTAILQ_FOREACH(dev, &vdev_device_list, next) {\n+\t\t\tVDEV_LOG(INFO, \"push vdev, %s\", dev->device.name);\n+\t\t\tstrncpy(ou_params.name, dev->device.name, 32);\n+\t\t\trte_eal_mp_sendmsg(\"vdev\", &ou_params,\n+\t\t\t\t\t\t\t  len, NULL, 0);\n+\t\t}\n+\t\tbreak;\n+\tcase VDEV_SCAN_RESPONSE:\n+\t\tVDEV_LOG(INFO, \"get vdev, %s\", in_params->name);\n+\n+\t\tif (strlen(in_params->name) == 0) {\n+\t\t\tVDEV_LOG(ERR, \"invalid name was passed\");\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tdev = find_vdev(in_params->name);\n+\t\tif (dev) {\n+\t\t\tVDEV_LOG(ERR, \"vdev already exists: %s\", in_params->name);\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tdevargs = alloc_devargs(in_params->name, NULL);\n+\t\tif (!devargs) {\n+\t\t\tVDEV_LOG(ERR, \"failed to allocate memory\");\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tdev = calloc(1, sizeof(*dev));\n+\t\tif (!dev) {\n+\t\t\tVDEV_LOG(ERR, \"failed to allocate memory\");\n+\t\t\tfree(devargs);\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tdev->device.devargs = devargs;\n+\t\tdev->device.numa_node = 0; /* to be corrected in probe() */\n+\t\tdev->device.name = devargs->name;\n+\n+\t\tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n+\t\tTAILQ_INSERT_TAIL(&vdev_device_list, dev, next);\n+\n+\t\tif (vdev_plug(&dev->device) < 0) {\n+\t\t\tVDEV_LOG(ERR, \"failed to plug device %s\", in_params->name);\n+\t\t\tfree(devargs);\n+\t\t\tfree(dev);\n+\t\t} else\n+\t\t\tVDEV_LOG(INFO, \"plug in device: %s\", in_params->name);\n+\n+\t\tbreak;\n+\tdefault:\n+\t\tVDEV_LOG(ERR, \"vdev cannot recognize this message\");\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n vdev_scan(void)\n {\n \tstruct rte_vdev_device *dev;\n \tstruct rte_devargs *devargs;\n \n+\tif (rte_eal_mp_action_register(\"vdev\", vdev_action) < 0) {\n+\t\tVDEV_LOG(ERR, \"vdev fails to add action\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (rte_eal_process_type() == RTE_PROC_SECONDARY) {\n+\t\tstruct vdev_action_params params;\n+\n+\t\tparams.type = VDEV_SCAN_REQUEST;\n+\t\trte_eal_mp_sendmsg(\"vdev\", &params,\n+\t\t\t\t\t\t  sizeof(params), NULL, 0);\n+\n+\t\treturn 0;\n+\t}\n+\n \t/* for virtual devices we scan the devargs_list populated via cmdline */\n \tTAILQ_FOREACH(devargs, &devargs_list, next) {\n \n@@ -287,6 +380,9 @@ vdev_probe(void)\n {\n \tstruct rte_vdev_device *dev;\n \n+\tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n+\t\treturn 0;\n+\n \t/* call the init function for each virtual device */\n \tTAILQ_FOREACH(dev, &vdev_device_list, next) {\n \n@@ -294,7 +390,7 @@ vdev_probe(void)\n \t\t\tcontinue;\n \n \t\tif (vdev_probe_all_drivers(dev)) {\n-\t\t\tVDEV_LOG(ERR, \"failed to initialize %s device\\n\",\n+\t\t\tVDEV_LOG(ERR, \"failed to initialize %s device\",\n \t\t\t\trte_vdev_device_name(dev));\n \t\t\treturn -1;\n \t\t}\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "08/12"
    ]
}