Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/29119/?format=api
{ "id": 29119, "url": "https://patches.dpdk.org/api/patches/29119/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170922075519.28342-5-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170922075519.28342-5-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170922075519.28342-5-pablo.de.lara.guarch@intel.com", "date": "2017-09-22T07:55:16", "name": "[dpdk-dev,v3,4/7] app/crypto-perf: overwrite mbuf when verifying", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "89322a7a4a7d9ad6a6149686e1b322aa6489f5ee", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170922075519.28342-5-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/29119/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/29119/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF0531B1AC;\n\tFri, 22 Sep 2017 17:55:33 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id E30011B19D\n\tfor <dev@dpdk.org>; Fri, 22 Sep 2017 17:55:28 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga105.jf.intel.com with ESMTP; 22 Sep 2017 08:55:28 -0700", "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby fmsmga005.fm.intel.com with ESMTP; 22 Sep 2017 08:55:27 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,427,1500966000\"; d=\"scan'208\";a=\"154396005\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com,\n\takhil.goyal@nxp.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Fri, 22 Sep 2017 08:55:16 +0100", "Message-Id": "<20170922075519.28342-5-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170922075519.28342-1-pablo.de.lara.guarch@intel.com>", "References": "<20170913072026.29734-1-pablo.de.lara.guarch@intel.com>\n\t<20170922075519.28342-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 4/7] app/crypto-perf: overwrite mbuf when\n\tverifying", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When running the verify test, mbufs in the pool were\npopulated with the test vector loaded from a file.\nTo avoid limiting the number of operations to the pool size,\nmbufs will be rewritten with the test vector, before\nlinking them to the crypto operations.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n app/test-crypto-perf/cperf_options_parsing.c | 7 ------\n app/test-crypto-perf/cperf_test_verify.c | 35 ++++++++++++++++++++++++++++\n 2 files changed, 35 insertions(+), 7 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c\nindex d372691..89f86a2 100644\n--- a/app/test-crypto-perf/cperf_options_parsing.c\n+++ b/app/test-crypto-perf/cperf_options_parsing.c\n@@ -944,13 +944,6 @@ cperf_options_check(struct cperf_options *options)\n \t}\n \n \tif (options->test == CPERF_TEST_TYPE_VERIFY &&\n-\t\t\toptions->total_ops > options->pool_sz) {\n-\t\tRTE_LOG(ERR, USER1, \"Total number of ops must be less than or\"\n-\t\t\t\t\" equal to the pool size.\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (options->test == CPERF_TEST_TYPE_VERIFY &&\n \t\t\t(options->inc_buffer_size != 0 ||\n \t\t\toptions->buffer_size_count > 1)) {\n \t\tRTE_LOG(ERR, USER1, \"Only one buffer size is allowed when \"\ndiff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c\nindex ba9621b..dbfa661 100644\n--- a/app/test-crypto-perf/cperf_test_verify.c\n+++ b/app/test-crypto-perf/cperf_test_verify.c\n@@ -187,6 +187,34 @@ cperf_mbuf_create(struct rte_mempool *mempool,\n \treturn NULL;\n }\n \n+static void\n+cperf_mbuf_set(struct rte_mbuf *mbuf,\n+\t\tconst struct cperf_options *options,\n+\t\tconst struct cperf_test_vector *test_vector)\n+{\n+\tuint32_t segment_sz = options->segment_sz;\n+\tuint8_t *mbuf_data;\n+\tuint8_t *test_data =\n+\t\t\t(options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) ?\n+\t\t\t\t\ttest_vector->plaintext.data :\n+\t\t\t\t\ttest_vector->ciphertext.data;\n+\tuint32_t remaining_bytes = options->max_buffer_size;\n+\n+\twhile (remaining_bytes) {\n+\t\tmbuf_data = rte_pktmbuf_mtod(mbuf, uint8_t *);\n+\n+\t\tif (remaining_bytes <= segment_sz) {\n+\t\t\tmemcpy(mbuf_data, test_data, remaining_bytes);\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tmemcpy(mbuf_data, test_data, segment_sz);\n+\t\tremaining_bytes -= segment_sz;\n+\t\ttest_data += segment_sz;\n+\t\tmbuf = mbuf->next;\n+\t}\n+}\n+\n void *\n cperf_verify_test_constructor(struct rte_mempool *sess_mp,\n \t\tuint8_t dev_id, uint16_t qp_id,\n@@ -469,6 +497,13 @@ cperf_verify_test_runner(void *test_ctx)\n \t\t\t\tops_needed, ctx->sess, ctx->options,\n \t\t\t\tctx->test_vector, iv_offset);\n \n+\n+\t\t/* Populate the mbuf with the test vector, for verification */\n+\t\tfor (i = 0; i < ops_needed; i++)\n+\t\t\tcperf_mbuf_set(ops[i]->sym->m_src,\n+\t\t\t\t\tctx->options,\n+\t\t\t\t\tctx->test_vector);\n+\n #ifdef CPERF_LINEARIZATION_ENABLE\n \t\tif (linearize) {\n \t\t\t/* PMD doesn't support scatter-gather and source buffer\n", "prefixes": [ "dpdk-dev", "v3", "4/7" ] }