Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28864/?format=api
{ "id": 28864, "url": "https://patches.dpdk.org/api/patches/28864/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170918151755.86605-13-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170918151755.86605-13-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170918151755.86605-13-ajit.khaparde@broadcom.com", "date": "2017-09-18T15:17:48", "name": "[dpdk-dev,v2,12/19] net/bnxt: fix config rss update", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "db491caca2f888c507fcd8dc889f446724e40c7d", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170918151755.86605-13-ajit.khaparde@broadcom.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28864/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/28864/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 67E081B20D;\n\tMon, 18 Sep 2017 17:18:31 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (lpdvrndsmtp01.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 4155C1B1B4\n\tfor <dev@dpdk.org>; Mon, 18 Sep 2017 17:18:16 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.224.233])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 4B3B030C01C;\n\tMon, 18 Sep 2017 08:18:15 -0700 (PDT)", "from C02PT1RBG8WP.wifi.broadcom.net (c02pt1rbg8wp.wifi.broadcom.net\n\t[10.45.51.51])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id F381381EAD;\n\tMon, 18 Sep 2017 08:18:14 -0700 (PDT)" ], "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Mon, 18 Sep 2017 10:17:48 -0500", "Message-Id": "<20170918151755.86605-13-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.10.1 (Apple Git-78)", "In-Reply-To": "<20170918151755.86605-1-ajit.khaparde@broadcom.com>", "References": "<20170918151755.86605-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 12/19] net/bnxt: fix config rss update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We are not configuring the RSS settings updated by rss_hash_update().\nFix it.\n\nFixes: cc0aa1edc10 (\"net/bnxt: add RSS hash configuration\")\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 2 ++\n drivers/net/bnxt/bnxt_ethdev.c | 4 ++++\n drivers/net/bnxt/bnxt_rxq.c | 5 +++++\n 3 files changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 405d94d..4a88210 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -176,6 +176,7 @@ struct bnxt {\n \tvoid\t\t\t\t*bar0;\n \n \tstruct rte_eth_dev\t\t*eth_dev;\n+\tstruct rte_eth_rss_conf\t\trss_conf;\n \tstruct rte_pci_device\t\t*pdev;\n \n \tuint32_t\t\tflags;\n@@ -184,6 +185,7 @@ struct bnxt {\n #define BNXT_FLAG_PORT_STATS\t(1 << 2)\n #define BNXT_FLAG_JUMBO\t\t(1 << 3)\n #define BNXT_FLAG_SHORT_CMD\t(1 << 4)\n+#define BNXT_FLAG_UPDATE_HASH\t(1 << 5)\n #define BNXT_PF(bp)\t\t(!((bp)->flags & BNXT_FLAG_VF))\n #define BNXT_VF(bp)\t\t((bp)->flags & BNXT_FLAG_VF)\n #define BNXT_NPAR_ENABLED(bp)\t((bp)->port_partition_type)\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 6eed19c..48e18ff 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -832,6 +832,10 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev,\n \t\tif (rss_conf->rss_hf & BNXT_ETH_RSS_SUPPORT)\n \t\t\treturn -EINVAL;\n \t}\n+\n+\tbp->flags |= BNXT_FLAG_UPDATE_HASH;\n+\tmemcpy(&bp->rss_conf, rss_conf, sizeof(*rss_conf));\n+\n \tif (rss_conf->rss_hf & ETH_RSS_IPV4)\n \t\thash_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV4;\n \tif (rss_conf->rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)\ndiff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex bae16da..0ae7da5 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -189,6 +189,11 @@ int bnxt_mq_rx_configure(struct bnxt *bp)\n \t\tstruct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf;\n \t\tuint16_t hash_type = 0;\n \n+\t\tif (bp->flags & BNXT_FLAG_UPDATE_HASH) {\n+\t\t\trss = &bp->rss_conf;\n+\t\t\tbp->flags &= ~BNXT_FLAG_UPDATE_HASH;\n+\t\t}\n+\n \t\tif (rss->rss_hf & ETH_RSS_IPV4)\n \t\t\thash_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV4;\n \t\tif (rss->rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)\n", "prefixes": [ "dpdk-dev", "v2", "12/19" ] }