Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28680,
    "url": "https://patches.dpdk.org/api/patches/28680/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170913141222.253688-17-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170913141222.253688-17-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170913141222.253688-17-bruce.richardson@intel.com",
    "date": "2017-09-13T14:12:21",
    "name": "[dpdk-dev,v3,16/17] build: add option to version libs using DPDK version",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "89687320362aebd981242d0773cab69db2c63cab",
    "submitter": {
        "id": 20,
        "url": "https://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 10,
        "url": "https://patches.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170913141222.253688-17-bruce.richardson@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/28680/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/28680/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 214E41B213;\n\tWed, 13 Sep 2017 17:09:00 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id CB5A81B1EE\n\tfor <dev@dpdk.org>; Wed, 13 Sep 2017 17:08:38 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Sep 2017 08:08:38 -0700",
            "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby fmsmga004.fm.intel.com with ESMTP; 13 Sep 2017 08:08:36 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.42,388,1500966000\"; d=\"scan'208\";a=\"311250735\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "nhorman@tuxdriver.com, luca.boccassi@gmail.com,\n\tharry.van.haaren@intel.com, \n\tkeith.wiles@intel.com, Bruce Richardson <bruce.richardson@intel.com>",
        "Date": "Wed, 13 Sep 2017 15:12:21 +0100",
        "Message-Id": "<20170913141222.253688-17-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.13.5",
        "In-Reply-To": "<20170913141222.253688-1-bruce.richardson@intel.com>",
        "References": "<20170912103809.140473-1-bruce.richardson@intel.com>\n\t<20170913141222.253688-1-bruce.richardson@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 16/17] build: add option to version libs using\n\tDPDK version",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Normally, each library has it's own version number based on the ABI.\nAdd an option to have all libs just use the DPDK version number as the\n.so version.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build                     | 13 ++++++++++++-\n lib/librte_eal/bsdapp/eal/meson.build   | 12 +++++++++++-\n lib/librte_eal/linuxapp/eal/meson.build | 12 +++++++++++-\n lib/meson.build                         | 12 +++++++++++-\n meson_options.txt                       |  1 +\n 5 files changed, 46 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex f19da16fb..3ea42b04b 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -92,6 +92,16 @@ foreach class:driver_classes\n \t\t\t\t\t\tdepends: [pmdinfogen, tmp_lib])\n \t\t\tendforeach\n \n+\t\t\tif get_option('per_library_versions')\n+\t\t\t\tlib_version = '@0@.1'.format(version)\n+\t\t\t\tso_version = '@0@'.format(version)\n+\t\t\telse\n+\t\t\t\tpver = meson.project_version().split('.')\n+\t\t\t\tlib_version = '@0@.@1@'.format(pver.get(0),\n+\t\t\t\t\t\tpver.get(1))\n+\t\t\t\tso_version = lib_version\n+\t\t\tendif\n+\n \t\t\t# now build the driver itself, and add to the drivers list\n \t\t\tlib_name = driver_name_fmt.format(name)\n \t\t\tversion_map = '@0@/@1@/@2@_version.map'.format(\n@@ -105,7 +115,8 @@ foreach class:driver_classes\n \t\t\t\tc_args: cflags,\n \t\t\t\tlink_args: '-Wl,--version-script=' + version_map,\n \t\t\t\tlink_depends: version_map,\n-\t\t\t\tversion: '@0@.1'.format(version),\n+\t\t\t\tversion: lib_version,\n+\t\t\t\tsoversion: so_version,\n \t\t\t\tinstall: true,\n \t\t\t\tinstall_dir: driver_install_path)\n \ndiff --git a/lib/librte_eal/bsdapp/eal/meson.build b/lib/librte_eal/bsdapp/eal/meson.build\nindex 00973122a..f6c43fd44 100644\n--- a/lib/librte_eal/bsdapp/eal/meson.build\n+++ b/lib/librte_eal/bsdapp/eal/meson.build\n@@ -46,11 +46,21 @@ sources = ['eal_alarm.c',\n \n eal_extra_link_arg = '-lexecinfo'\n \n+if get_option('per_library_versions')\n+\tlib_version = '@0@.1'.format(version)\n+\tso_version = '@0@'.format(version)\n+else\n+\tpver = meson.project_version().split('.')\n+\tlib_version = '@0@.@1@'.format(pver.get(0), pver.get(1))\n+\tso_version = lib_version\n+endif\n+\n version_map = join_paths(meson.current_source_dir(), 'rte_eal_version.map')\n eal_lib = library('rte_eal', sources, eal_common_sources, eal_common_arch_sources,\n \t\t\tdependencies: dependency('threads'),\n \t\t\tinclude_directories : eal_inc,\n-\t\t\tversion: '@0@.1'.format(version),\n+\t\t\tversion: lib_version,\n+\t\t\tsoversion: so_version,\n \t\t\tc_args: '-D_GNU_SOURCE',\n \t\t\tlink_depends: version_map,\n \t\t\tlink_args: [eal_extra_link_arg,\ndiff --git a/lib/librte_eal/linuxapp/eal/meson.build b/lib/librte_eal/linuxapp/eal/meson.build\nindex e7daed499..bffbd7e66 100644\n--- a/lib/librte_eal/linuxapp/eal/meson.build\n+++ b/lib/librte_eal/linuxapp/eal/meson.build\n@@ -51,11 +51,21 @@ sources = ['eal_alarm.c',\n \n eal_extra_link_arg = '-ldl'\n \n+if get_option('per_library_versions')\n+\tlib_version = '@0@.1'.format(version)\n+\tso_version = '@0@'.format(version)\n+else\n+\tpver = meson.project_version().split('.')\n+\tlib_version = '@0@.@1@'.format(pver.get(0), pver.get(1))\n+\tso_version = lib_version\n+endif\n+\n version_map = join_paths(meson.current_source_dir(), 'rte_eal_version.map')\n eal_lib = library('rte_eal', sources, eal_common_sources, eal_common_arch_sources,\n \t\t\tdependencies: dependency('threads'),\n \t\t\tinclude_directories : eal_inc,\n-\t\t\tversion: '@0@.1'.format(version),\n+\t\t\tversion: lib_version,\n+\t\t\tsoversion: so_version,\n \t\t\tc_args: '-D_GNU_SOURCE',\n \t\t\tlink_depends: version_map,\n \t\t\tlink_args: [eal_extra_link_arg,\ndiff --git a/lib/meson.build b/lib/meson.build\nindex d814721de..5244fe4a5 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -76,6 +76,15 @@ foreach l:libraries\n \t\t\tdep_objs += [get_variable('dep_rte_' + d)]\n \t\tendforeach\n \n+\t\tif get_option('per_library_versions')\n+\t\t\tlib_version = '@0@.1'.format(version)\n+\t\t\tso_version = '@0@'.format(version)\n+\t\telse\n+\t\t\tpver = meson.project_version().split('.')\n+\t\t\tlib_version = '@0@.@1@'.format(pver.get(0), pver.get(1))\n+\t\t\tso_version = lib_version\n+\t\tendif\n+\n \t\tversion_map = '@0@/@1@/rte_@2@_version.map'.format(\n \t\t\t\tmeson.current_source_dir(), dir_name, name)\n \t\tlibname = 'rte_' + name\n@@ -87,7 +96,8 @@ foreach l:libraries\n \t\t\t\tinclude_directories: include_directories(dir_name),\n \t\t\t\tlink_args: '-Wl,--version-script=' + version_map,\n \t\t\t\tlink_depends: version_map,\n-\t\t\t\tversion: '@0@.1'.format(version),\n+\t\t\t\tversion: lib_version,\n+\t\t\t\tsoversion: so_version,\n \t\t\t\tinstall: true)\n \t\tdep = declare_dependency(link_with: lib,\n \t\t\t\tinclude_directories: include_directories(dir_name),\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9c45b8159..636226ce8 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -6,3 +6,4 @@ option('allow_invalid_socket_id', type: 'boolean', value: false,\n \tdescription: 'allow out-of-range NUMA socket id\\'s for platforms that don\\'t report the value correctly')\n option('enable_kmods', type: 'boolean', value: true, description: 'build kernel modules')\n option('kernel_dir', type: 'string', value: '', description: 'path to the kernel for building kernel modules')\n+option('per_library_versions', type: 'boolean', value: true, description: 'true: each lib gets its own version number, false: DPDK version used for each lib')\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "16/17"
    ]
}