Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28661/?format=api
{ "id": 28661, "url": "https://patches.dpdk.org/api/patches/28661/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/05958f0c9e0a99a2ac56152a36cf15237f4d125c.1505299539.git.shahafs@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<05958f0c9e0a99a2ac56152a36cf15237f4d125c.1505299539.git.shahafs@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/05958f0c9e0a99a2ac56152a36cf15237f4d125c.1505299539.git.shahafs@mellanox.com", "date": "2017-09-13T10:50:38", "name": "[dpdk-dev,v4,3/4] net/mlx5: fix Tx stats error counter logic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "666709a89f2a7206d1bca05f16b6bbf20f7c987b", "submitter": { "id": 634, "url": "https://patches.dpdk.org/api/people/634/?format=api", "name": "Shahaf Shuler", "email": "shahafs@mellanox.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/05958f0c9e0a99a2ac56152a36cf15237f4d125c.1505299539.git.shahafs@mellanox.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28661/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/28661/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6540B1B1A1;\n\tWed, 13 Sep 2017 12:50:52 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00066.outbound.protection.outlook.com [40.107.0.66])\n\tby dpdk.org (Postfix) with ESMTP id 0F30E199B4;\n\tWed, 13 Sep 2017 12:50:50 +0200 (CEST)", "from mellanox.com (82.166.227.17) by\n\tVI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12;\n\tWed, 13 Sep 2017 10:50:47 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=2UIn0FmyZO6vZPypL8FVoxzWa4gyCKy6GTamOSJ+nqw=;\n\tb=evEmLYt0a1WmQdmOnQy811xF5JyANRNWaibBFBO+obWapwBwwVyYFZr4ujOEVIpU0gLyRNI2+zmq15KZTeH91aN5bDwafZ5ZGrjyZ4COLwEDb8mDMXKEfdbaVhjICrF5sKFtkbeq6JOY1uURzCJh05fvAx9nqwqb90157p9seLM=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shahafs@mellanox.com; ", "From": "Shahaf Shuler <shahafs@mellanox.com>", "To": "nelio.laranjeiro@6wind.com, yskoh@mellanox.com,\n\tadrien.mazarguil@6wind.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Wed, 13 Sep 2017 13:50:38 +0300", "Message-Id": "<05958f0c9e0a99a2ac56152a36cf15237f4d125c.1505299539.git.shahafs@mellanox.com>", "X-Mailer": "git-send-email 2.12.0", "In-Reply-To": "<7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com>", "References": "<7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[82.166.227.17]", "X-ClientProxiedBy": "HE1PR0401CA0079.eurprd04.prod.outlook.com\n\t(2603:10a6:3:19::47) To VI1PR05MB3151.eurprd05.prod.outlook.com\n\t(2603:10a6:802:1b::16)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "9f88cfc0-791f-44a5-19a7-08d4fa954b35", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR05MB3151; ", "X-Microsoft-Exchange-Diagnostics": [ "1; VI1PR05MB3151;\n\t3:KUMgTjMiM6pgNnxypwNNLNVRz073liiGtXtJ3bIp+Ij8jxO4phrHOywT8S0Ww4H9nPVrFgXCWc1oXxxXinuxUBRlia0e2Fut5q5D9s+Jcq1cVRw5F6A/ZMByrG8C0YBJReg8vMhdnF+IlwEytXxmjmHay0BEAnSpjM5ArrEGlmIegOT+54N2/5xTh2bBb9mkvDgAGN9tapQ8eGggjgEIu0h0uW9ZQrtqMb7oRXr6pfIoalNMiiWv1rJiYtt282v4;\n\t25:5g5FpDX2rcjbZCfZJBJQjhGWT+FOwlRbMNud9uUiBtlTDJgFEVrLBV7Vt8kbBdMhXZuhYPQOGgblCP1WV1paniHXbuHOXW2W3bJwsl5smyj2EYxYTujd+EHH6qx2YTLLmfjwCuhKPiP/GacMCqcryI0cjVEhNhcNyAru25iilhc+rCysJgIc8DoW/qgV9sqYHSF2/058Cz0lvFuvQZdpaiuz29mlyaKXLoT1HNl3+t/7ylTp5GChOAUhQY3MFqogXTtWgtB7wl37iXgl0NWO/n8H7gL/QO1CRvAFMGREWFfNiXat1NeU6i4cq5VIdYmAt1CRzbx9vb4Zj5dbSnacDg==;\n\t31:ThdWxi0Edazu86aaaMg3C5rsZIez9fITASsUGOtdeSgT1jCBeVgTHVEdRUDVjQJVxJLYDPBv5yRhH7Ld5OihkQwSi9go6n3vi6OzBsD5i2edR/7psN9zOPQ4sTOqB3X08xFod49ATyNRguzqdrV4K70m/Nb9tJfBIJb3NTW8Hsf5DTLGSntS9lWtYM8ypT6cCPLrkQNn9tr45KUqTmlbBztVtKxUzuS9gVxGfXKPm9U=", "1; VI1PR05MB3151;\n\t20:RRoC38iXAicoTKTVkjGl8YczUzEW2GrHihsuAgTKwavoAPnQ5PKmfxTlKz3lHWdNdj+uk7D4V6/VzaHiguyXmR/YmHp1TTTS6C1F0el8Jc/cgPFznqTtECFwG3RqyeNceHy3VTrbahUCcZ0mtH5po+lcnPYYXqAFy1pqL/qN5E/xyNKJ59cChZthXyfCrFpfe/9wJuL1wwDrlXaqq1a6qEdMNMrBr4OgjBO8WNWj0i7om9tJNE39CmRg4Fj6a+JjPswdzGFYnl+sTyADwWxCdCDFQbbxgLS1HLrmKsVMongSPcRQVs79biaUzT/pZor+6YKmZEImBQdcE7chpBuLY1hITbDvXlJPmpVO+09DRqnltn0qST+KTLLjg87QhpgHVWWV4y1n3g09NeHZpJlL5mAg9aSbajv71amO7fOlJg20wNd2k0bQy5P884zLKnFbbYo6R46QACEtWrBiFwA0f9LfwGAbIVyHgUPcXwNP9dsgPILxkhfu7qZ5Kk6JD+eX;\n\t4:qSdDI5mpUTmoBnwbkiFEs8HBQSdP94aWMIi9y/z3oKA9Ke+xq4PH+yYOIaT7mI+ILTfBO0ZOImKe+KUYML8pkpJg0mvFF/BLPRBbXKeeRVdY2I0Hdm7V+HamTvtJyujkJ0MKxXu+Jfnp7eaZqUfeiyk+NNpq4VFxJkczX4DMZxtDRj+8wIfrxuZeA40R3tdpsx/a3HScT9yTdLjx7bFx3xOX4EPTBWBdjKvjWC/bHWidLtHhQbqy/SdLA6mew5HN", "=?us-ascii?Q?1; VI1PR05MB3151;\n\t23:a89kGYZzrjBZ0XbHmoLFkMtd4QvkzAhKuXgfgtIiA?=\n\tS0fVkmbDT6BpiDbiw8eSz5+kJpEiSTu9j4kwn9OQZR+HeR6pJ5396TWQc89XVbjKw44AvXN0eACT75sTynxmg0TeJ1GqNaXqU8kOPwSuNUMasfnq+VxLpNwDcis9JxbWzZ0xN5hm5BMhFtTQBIn3a4wWaKmwgyUBrIdBhnvdolSIlO/Xagb5SZ9oz7ltVARRxpapiAPexN2VGgeh0yQ8Tl2mOpo5oL8QoTvrhMs809N4iyrAzq8dJDGyHfqP4OT6FkJQz6F8IwqnuVuGdYG6B1hOvyUHKcAW+gbOs6VHScpS0O8huM9OOscvVRKxhFHNrab31orYxvm8C7mmdLuVpNRBpilSv058rucjCbIKHwtzJJZp6ldTRImgZYWtJzUM0S8KXlr62E/acKyOcZ25r3l58aFiaAUDafgOfQbXOnNcRXRsRrnoBtftVV7f+iUkcLqBMgQwDD8zSi3pfyoNs4NjI2RCfuBOP17OUywXxJ9IyYmpoOsJ7VfzrdpcxofIOVjxkeAK24tfOGaC+i7NQKnf+0V7tETVbr3xt5E8ZGvqLcOo4WalOY0j9DKcPPejc++6IXB44X/BfLGEHFfhRidbWJO/lU11iD1HdIJUa5/e5m7lBJus5hbfO6Ijxe+NQAbjVQpQUCx93Tna/6zWzZJm9I2Ytm31k4J7Zt7iRz7jQ3wGr4Yz7P5HpOJxOWVcHFyADZ7Umwha3O+UqH2yeuQ2Glh9Duub5XWSt9paYWnqN0/waktreOKyVY7U7j4/P88So9urY7w0N8GkV1PbMC4ZSsibFijODm5Cy/oJ4pVpGNHkmOq7nbATuqRtE7jV3DHgOZO5KbyPWFCxY1tS+Shxy4K7XrYej6qtaiynQXS775ehhjaS7NWqc+U6dJZvmSup8MOZEYVJxY9vJZ1jyGTYumvRT9s9kU41tTQmRZKF69WqrYEWEAtDCspynZmkFBGBM8aYR0hhLk21C8AT53QmAucidR+iOzYmlIo512OWb/h0B38b5/vxEmg4mZ25BFOSwe6lMx/dV80Z/+nwVZZufw+px2mzoJMfGnOoktGkebmS7kB/Ke/ZiZb2uIprdLvPsXbx0bfc/erhpfOJyXxbwEID+ZlnNZYWhoHfqgXb/aH99mx84G7s4I5VlZvqYk=", "1; VI1PR05MB3151;\n\t6:ake3nMGo2gbzZ2Ws1M837tkQMUW+lvpSW6pIpE8ndCy/bKCd82IFUhU4CP5/wl1jRBfMHFPXSUd13Gtmrtqv0zu7S4X5ujkSRNzXqpy7ndiG+3JPos80kTWSMURMynKt9lmldgbMMUUgxzODyistczbVK5o4IVHs/h04mGG8YLKNHR1Cff8OB6zkiigbnRNlzBJJATZ0oCViCoZQd1J+Io2AL6PJjg/aG1D4VB6UVGh7cFM1zqSwFi71vi27dVwiIdnVzO5xWydk0pQIIyXn65neNjH6V5gXFVOqE+uWaV7FqPb0Rs6GS8nlgjO0dBnH1mG4r5ZMvMKLoNrutmCmWw==;\n\t5:w0lwZHut6qBsaD+JtYpsMdmbNteTXVeEwdQQjqANar0oooUF+5UTbhU4ekxjhiDyhd6Mbs+0hGRbl/+8sOynfjkMfIpBfrXgRkvoDF6yLJPhklLDOSflebfuY2ekfrzGuonhMopyUSZN/hCmMujcXQ==;\n\t24:A69qd021GbK0uc9FTF0nPpn/x2K6WyoUAz7rF8o+8wynwK6KE7Qm9840BXEPYFO3VvcLKtOkv2Mcjl/cnmpXRr6vjIB1X5I8evQS1wX6xqE=;\n\t7:cOdu5V2dqS2Tlx7GXp5xVcVOkl8jwuGsioB2Cl+78JkmGd3uyUg9EB82dY0SqI6brK8B5U7uZzajVpOkBsZQhekmAuRVd9ycFCovfbK1yb72Uxk+/oHAPOA0UBHIoF/mnJFDai0QSC/EEwm0A5sxiELU3jMiak/sPmTh2Es/py9qEK1J1rn1YlwOuHo1dNeUIPGlsZTs6qZgx5xpgPNLbiO0KNksPOL5NlVB/LzsqdM=" ], "X-MS-TrafficTypeDiagnostic": "VI1PR05MB3151:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Microsoft-Antispam-PRVS": "<VI1PR05MB3151E6F9EAE47F36996B5A5EC36E0@VI1PR05MB3151.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR05MB3151; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR05MB3151; ", "X-Forefront-PRVS": "042957ACD7", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(346002)(39860400002)(376002)(366002)(199003)(189002)(21086003)(105586002)(86362001)(48376002)(50466002)(3846002)(6116002)(7736002)(69596002)(76176999)(50986999)(118296001)(25786009)(66066001)(47776003)(478600001)(106356001)(101416001)(33026002)(55016002)(305945005)(53936002)(2950100002)(4326008)(6666003)(110136004)(5003940100001)(33646002)(50226002)(2906002)(68736007)(5660300001)(81166006)(81156014)(8676002)(189998001)(36756003)(7350300001)(316002)(97736004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Sep 2017 10:50:47.5080\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR05MB3151", "Subject": "[dpdk-dev] [PATCH v4 3/4] net/mlx5: fix Tx stats error counter logic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Tx error counter lacks the logic of incrementation, making it useless for\napplications.\n\nFixes: 87011737b715 (\"mlx5: add software counters\")\nCc: stable@dpdk.org\nCc: adrien.mazarguil@6wind.com\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 20 +++++++++++++++-----\n 1 file changed, 15 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex fe9e7eac0..7567f2329 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -406,8 +406,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n #ifdef MLX5_PMD_SOFT_COUNTERS\n \t\ttotal_length = length;\n #endif\n-\t\tif (length < (MLX5_WQE_DWORD_SIZE + 2))\n+\t\tif (length < (MLX5_WQE_DWORD_SIZE + 2)) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\t/* Update element. */\n \t\t(*txq->elts)[elts_head & elts_m] = buf;\n \t\t/* Prefetch next buffer data. */\n@@ -481,8 +483,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\t\t\t\tcs_flags |= MLX5_ETH_WQE_L4_CSUM;\n \t\t\t\t}\n \t\t\t\tif (unlikely(tso_header_sz >\n-\t\t\t\t\t MLX5_MAX_TSO_HEADER))\n+\t\t\t\t\t MLX5_MAX_TSO_HEADER)) {\n+\t\t\t\t\ttxq->stats.oerrors++;\n \t\t\t\t\tbreak;\n+\t\t\t\t}\n \t\t\t\tcopy_b = tso_header_sz - pkt_inline_sz;\n \t\t\t\t/* First seg must contain all headers. */\n \t\t\t\tassert(copy_b <= length);\n@@ -843,8 +847,10 @@ mlx5_tx_burst_mpw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\tif (max_elts < segs_n)\n \t\t\tbreak;\n \t\t/* Do not bother with large packets MPW cannot handle. */\n-\t\tif (segs_n > MLX5_MPW_DSEG_MAX)\n+\t\tif (segs_n > MLX5_MPW_DSEG_MAX) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\tmax_elts -= segs_n;\n \t\t--pkts_n;\n \t\t/* Should we enable HW CKSUM offload */\n@@ -1064,8 +1070,10 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,\n \t\tif (max_elts < segs_n)\n \t\t\tbreak;\n \t\t/* Do not bother with large packets MPW cannot handle. */\n-\t\tif (segs_n > MLX5_MPW_DSEG_MAX)\n+\t\tif (segs_n > MLX5_MPW_DSEG_MAX) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\tmax_elts -= segs_n;\n \t\t--pkts_n;\n \t\t/*\n@@ -1353,8 +1361,10 @@ mlx5_tx_burst_empw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\tif (max_elts - j < segs_n)\n \t\t\tbreak;\n \t\t/* Do not bother with large packets MPW cannot handle. */\n-\t\tif (segs_n > MLX5_MPW_DSEG_MAX)\n+\t\tif (segs_n > MLX5_MPW_DSEG_MAX) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\t/* Should we enable HW CKSUM offload. */\n \t\tif (buf->ol_flags &\n \t\t (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM))\n", "prefixes": [ "dpdk-dev", "v4", "3/4" ] }