Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28660/?format=api
{ "id": 28660, "url": "https://patches.dpdk.org/api/patches/28660/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/f27a7e9603697aeafc683aa2cbbdb81a737e0cfa.1505299539.git.shahafs@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f27a7e9603697aeafc683aa2cbbdb81a737e0cfa.1505299539.git.shahafs@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f27a7e9603697aeafc683aa2cbbdb81a737e0cfa.1505299539.git.shahafs@mellanox.com", "date": "2017-09-13T10:50:37", "name": "[dpdk-dev,v4,2/4] net/mlx5: fix Tx stats error counter definition", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5013ef9f990ae505b63f03b42aa3afeae299f52c", "submitter": { "id": 634, "url": "https://patches.dpdk.org/api/people/634/?format=api", "name": "Shahaf Shuler", "email": "shahafs@mellanox.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/f27a7e9603697aeafc683aa2cbbdb81a737e0cfa.1505299539.git.shahafs@mellanox.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28660/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/28660/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 441291B199;\n\tWed, 13 Sep 2017 12:50:51 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00078.outbound.protection.outlook.com [40.107.0.78])\n\tby dpdk.org (Postfix) with ESMTP id 5FF4D1B19A;\n\tWed, 13 Sep 2017 12:50:48 +0200 (CEST)", "from mellanox.com (82.166.227.17) by\n\tVI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12;\n\tWed, 13 Sep 2017 10:50:46 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=urBRi0EmbIJwf7vOw6dGFx0RC5HXyQTUw8xw8ZHDOh0=;\n\tb=pRaq/v2yhjQvK3nkR7OiDXLmRM8sW0uQuSI2Nm8JOxh57G7R+BZoo0UTJ22T1rhVemGuzOj+luc+QEc3Wr3HvrW0vawcj1RQjcV34SqEoeDS6BTVe3pyV/Ff3Ce/0Niy5tnTeIUXneqXN1UrXX5vYggiQ+RYuQSJqEm4y9NCRjA=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shahafs@mellanox.com; ", "From": "Shahaf Shuler <shahafs@mellanox.com>", "To": "nelio.laranjeiro@6wind.com, yskoh@mellanox.com,\n\tadrien.mazarguil@6wind.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Wed, 13 Sep 2017 13:50:37 +0300", "Message-Id": "<f27a7e9603697aeafc683aa2cbbdb81a737e0cfa.1505299539.git.shahafs@mellanox.com>", "X-Mailer": "git-send-email 2.12.0", "In-Reply-To": "<7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com>", "References": "<7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[82.166.227.17]", "X-ClientProxiedBy": "HE1PR0401CA0079.eurprd04.prod.outlook.com\n\t(2603:10a6:3:19::47) To VI1PR05MB3151.eurprd05.prod.outlook.com\n\t(2603:10a6:802:1b::16)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "7cbe58bd-6234-4d62-22f0-08d4fa954a5c", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR05MB3151; ", "X-Microsoft-Exchange-Diagnostics": [ "1; VI1PR05MB3151;\n\t3:qqo4Jed2dLHVX48Mqdb6QboENZUN/LBTqv5OzcJVL+hkG+bzd5oMgyNY2GhEtgGivdD3jltNiBC3aABgmE/dUH0Ltags+SgqLlhFOUbLi6tGFGdgwmTNWOwSN4q2ejV30HlOXkOh39k3uzvKY7nJ+Fau51smn1xy2I/Bd72ji74Mv8gjecrnlpXYZs0ewopQVv8BH3YjynMQOeKGia5D9r3R7zWFDXvMzRVoxSsKgQZ/DmwAyAlcD0tVrjGadMr8;\n\t25:FnqEiAK87XbDvJPNDqHYVNp3Q/Ew1gUkLHYVM8/zvANJSTk50lrcZMcrQ+lwvVs3pTcx18WSptvKqY2G0G9aRKkbeNK+b/g3yNzBZ00htgIy/GUp9wZ9KY6U3M+oqRBZ0bctHRrBGjQbkiSYUrcH/TnRCfybgHNPKIy1llBIDVSmNiy25oJ7FemwpQ9v3fUKXT1QXZKP6OMA3W8KOrm+QRgB9l1Nz34j7mZ+W13wr7CpXyhkpN1FzxDplg6cr1/6PTnDSTzbz3RDDENjN0xG+HLXBGf0M+PriGl6H0eSZkGNUm9TI+8CcDYNztKT37fBvXs+tX3p9JASgU8X7ypP6Q==;\n\t31:++Zf0fe7FHokCZ2ih1WEoNEnmSXQgCb3q3kWU+x7xOySymqecoBhnLWn8nVUSU4RO73nftgt42nLGgdfJaPSUJ92FFp+pSH+L/ezcXhOaVPj27OW/dP/nXiRBok6qQQslZv8J8aEFl9e/lyhmaR1IHhzyk1HVynJLwb3s8VyquxzRAcPqpY9fRWVj42baslpdOqq0tPfv6X4eZ21YjAuQGXSmKk7oMUpEoL0DZNUHq8=", "1; VI1PR05MB3151;\n\t20:uQf6+PzGLdyAiINdgYbmu1UNP3UfUp3cj6GJuMtZd6n0OzkCg0atw0sOyjmyABJD0SMHBNfbL2zlqZ4+DW14tRGCDCg+jmp+Xl5LfYV7kA8Lhh81HhuKBKovWbdBiMvoWUI1cVU+lwc9hrw2kQpcenJgfbvzKvEtNoHt6h2K2AKCcg3DN7EXQJBXL6rK/Kd7nq9MV2ni89My8fqtWJlTLXY+Z1x5GiHJED4ZjGBAQJIffMMdU+3C+TJlX2KlXZ4ztqhxFVrE5uQwQWlh60aq9ysPTp99/uXgkQ6HQgEMHuXpKxUZ/BpwdZb5Z4sjebZgvM1qz7WKDav1rRKTOAR/ovg+kpcfU83vNV3M7WeBp6qqxGg/0AbfRU/rwNQ+/x1xDMv00Q311/uTzFXqdP3X6/r8uP5t8mVBB43TH2loi9DkDh7pIi030ndeAE1ncnXGzXqQEXJX3S3t7T6WnVlfUZUCu7rj4RXd9+NXSYZfCMaMiIZtz8qS74ZcA5+tSfxU;\n\t4:EOkvo1/7WFXvXFmiQTWnj1RJfjmrm4tbGjEhB3V5NIXfqA5HgEJNoILuHkUivlSuJ4cy2SWHvq2+hikNnV/ofEAR2rt/qTeJr3W+eaC8rWfVk0NnJSE7AKBbskZHBhXueHodN0qMWv8XvPbzttxtPMQTOyFBlj2YmFEp/p//IRRSPCVAP53h1HEvOPAOEgVt6Qr0VKnOz3amv69P2t9ZFuczXtGlvAVI4l7kKuKlTdOL/zNnofKAEYdtxjj4TDDksv9PagWjoB0nG1z528cAfvMLppghcYZrJ1V1FzuGWGM=", "=?us-ascii?Q?1; VI1PR05MB3151;\n\t23:HNFrWvuiUarjVyja8wINv+a5XVFUBRB6mbDCGizE0?=\n\tkCfIAwiNT46kg1m0duWBj0qxzMBWCBQU2JDlAxwfPmEGbJHzAg4R1ZCBY71O6qpxT1ParrVpYbNhFVHXfHihnV0eoRcX/yKvFwAGJ4ms2jAeLAoCacPSRN2Qp7tq50IE65Bzpfy2y40JepzF31pgM2sE0KxWZxVVOBENL4hK7MHEDYn7A+KWCXdk+OUEvjKCMiZ+BZNRdO1ap17ajyoGugIh2GO9LL4wGIHw+UtSlZO42JW6WJ0hlLEGTlr6cS2swgglqoKhybrkf1WqbZtXNFrn908NReWlE9F4TukXIM1YkmE2zGymR6lkyH7EfiPyTLWM3JYukE6shwm5AAXxBBUhYYZxRsmMxSZGM5Dx4qPXeCh7GUmD2ThGtDWwyrxTB+pJVstL5WYx1YdcHTgnFUb82UzgrA4+AVHaxYpKYaKgqAKM5m9A4YoqiPVy/HdSThxyM1jhYxka8ZevoGIo5NzXrNzuZ2PwxRvw+zxJx73P1iT5OtDxKIy3/A4zZTDDWlRLGCCav8/mN5nYhZHla2m/LwUoSOT75D7ZoaUggB2OgYifetymbcSDO4SOO5EDbFVAaYTQ4SaAklyEbbjh2T3jDXT3VhkiXKyVQWvBZgyHD54wr0eLCZe7dUQKkhXhXM6DbBJk5W0kEgdcL1NU2xUC07D2e4F74lD1Kr2l9wv+U2fxYTPky26oh7A9yxLKeZ0ctNSzFA1oDVGGtecKiovT6RTnzfa8LEPjq0XhZQqh0aZtN2XuWA7sZ1CFu3UusJ9yHK3fJdpHC9Oak7GEHdLp9fgsapzRiuYdvR6Rp7TB973CBRfzD2gsKNHCdF08+0avspbeT+/P23YCf+maqaX4hEZCPwJjZnIpLVNT9kRz0/T+2FwlaOEk7ZJqCWVruMBVR/NHo+y9OYbGQNb2DHTe7qY6TbptEebCeGdVzuCqujRQVyPgguJht600brkqAiuysE1A4dBOqdqN2miQMIJgftLNzAl+vqDZ9rmTMxwKUOwjhbZAHKrtjVhp/g5QuLizphIjilHO5aec6UiottvV64CmwTpie34EPgit977uerEFJGQLUv4e+ItdUY+CrrXRslJy8eN1/UEnVvNeYngQBlYjZUROhSBa8aGIuR/FLnwSYqhZ+jP+n6riF0N3OzBu04k0vtg+ZiAxj11y8xj", "1; VI1PR05MB3151;\n\t6:2ThKu3ReXCiAUyTk3R29nScIy4p409GEPHpSiWbSW2WmcbcCAwoNAZuGUsw2ZyifRoaLC/WWLz1UBdc9bfPQBGr7z6BAjQP+WUlWTkgjXxSe7AWQHeibXwMSxIIwU7R2J4t7O0LoZQCiw2DedT7yD+PHBCUqSi3gf/V+lssDC31gEjQ0qKVb6K15GIirMqhyqTcL7zYP8Ll16f9iXlosqWe3uyfv9oNf7fhQbi1Aa+l5wXVZmTWCHTyBwABMC6UKfYQr+xsfEfHn2GjmHHbgJDjQ81gNyqIaKhrM88mfyzXz5gxDmuuNx0iWdq2Dz2PCOyZA6bAfkn2lToFCshTJRQ==;\n\t5:kd07w8q5GPBNZ0ukKI0sdVHfDbqcLFTxk+C4xBJHizGhPJ4vAMfbO4DXU4NH2qEiuZijjuBzX4UMjjsEZLmBL9xP7ES0DZpaSj8l9qmz77VmTRklnhSZjab0yA4TvA8zQJ+tCqdBNzovcbekwfpyBQ==;\n\t24:w9iqLxGdXywzBiwPmBnEu50tMepI9R03PP6wcM5mDoQ8kaOOJyxg1vkzhlto5PGa5rs36gs3hvDQPnTOtzQXLer9h7R6SOy8xFB644w8z20=;\n\t7:wYfPZzOYpbIFy+iW4TFAEsVA7ugU49VGxvvyWLoNXAwnMl9UrDH1vbedFdaZiiBslWXHf4nFD30E/5J+Lrh+drUhiJbvt+TGpEV9ZpR+mCGttBfzTWHl2n3gwhqsP77TbsAnqcgSNzez6icpHb+kYJ9poEyOuzyff8S9LCRw1UqI/Y171Y54FbKmYqeoo8YPouxgxib0Rc7+TWWoMiL5Qw5+VT02SpEc3ILDK1+nUpo=" ], "X-MS-TrafficTypeDiagnostic": "VI1PR05MB3151:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-Exchange-Antispam-Report-Test": "UriScan:(788757137089);", "X-Microsoft-Antispam-PRVS": "<VI1PR05MB31518BD6B432CF4492415E4BC36E0@VI1PR05MB3151.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR05MB3151; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR05MB3151; ", "X-Forefront-PRVS": "042957ACD7", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(346002)(39860400002)(376002)(366002)(199003)(189002)(21086003)(105586002)(86362001)(48376002)(50466002)(3846002)(6116002)(7736002)(69596002)(76176999)(50986999)(118296001)(25786009)(575784001)(66066001)(47776003)(478600001)(106356001)(101416001)(33026002)(55016002)(305945005)(53936002)(2950100002)(4326008)(6666003)(110136004)(5003940100001)(33646002)(50226002)(2906002)(68736007)(5660300001)(81166006)(81156014)(8676002)(189998001)(36756003)(7350300001)(316002)(97736004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Sep 2017 10:50:46.1018\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR05MB3151", "Subject": "[dpdk-dev] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter\n\tdefinition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current Tx error counter counts, according to its description,\nthe total number of packets not sent when TX ring full. It is reported\nto application as part of oerrors field.\n\nThe drop due to full ring is not the statistic that should be set on\noerrors field. Such number can be counted by the application using the\nreturn value of the Tx burst function.\nThe number that should be set there is the number of packets the device\ncould not transmit in any way, even when it has resources.\n\nTherefore, replace this counter to count the total number of failed\ntransmitted packets.\n\nFixes: 87011737b715 (\"mlx5: add software counters\")\nCc: stable@dpdk.org\nCc: adrien.mazarguil@6wind.com\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\non v4:\n - Split fix Tx stats commit into 2 seperate patches.\n---\n drivers/net/mlx5/mlx5_rxtx.h | 2 +-\n drivers/net/mlx5/mlx5_stats.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 033e70f25..107ada0f5 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -75,7 +75,7 @@ struct mlx5_txq_stats {\n \tuint64_t opackets; /**< Total of successfully sent packets. */\n \tuint64_t obytes; /**< Total of successfully sent bytes. */\n #endif\n-\tuint64_t odropped; /**< Total of packets not sent when TX ring full. */\n+\tuint64_t oerrors; /**< Total number of failed transmitted packets. */\n };\n \n /* Flow director queue structure. */\ndiff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c\nindex d443e1336..06348c8a1 100644\n--- a/drivers/net/mlx5/mlx5_stats.c\n+++ b/drivers/net/mlx5/mlx5_stats.c\n@@ -360,13 +360,13 @@ mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\t\ttmp.q_opackets[idx] += txq->stats.opackets;\n \t\t\ttmp.q_obytes[idx] += txq->stats.obytes;\n #endif\n-\t\t\ttmp.q_errors[idx] += txq->stats.odropped;\n+\t\t\ttmp.q_errors[idx] += txq->stats.oerrors;\n \t\t}\n #ifdef MLX5_PMD_SOFT_COUNTERS\n \t\ttmp.opackets += txq->stats.opackets;\n \t\ttmp.obytes += txq->stats.obytes;\n #endif\n-\t\ttmp.oerrors += txq->stats.odropped;\n+\t\ttmp.oerrors += txq->stats.oerrors;\n \t}\n #ifndef MLX5_PMD_SOFT_COUNTERS\n \t/* FIXME: retrieve and add hardware counters. */\n", "prefixes": [ "dpdk-dev", "v4", "2/4" ] }