Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28635,
    "url": "https://patches.dpdk.org/api/patches/28635/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab",
    "date": "2017-09-12T13:02:10",
    "name": "[dpdk-dev,v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "63f8b9f09695861e1c435d89d61cf66998a048ea",
    "submitter": {
        "id": 830,
        "url": "https://patches.dpdk.org/api/people/830/?format=api",
        "name": "David Harton",
        "email": "dharton@cpp-rtpbld-31.cpprtplab"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/28635/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/28635/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69C03199B4;\n\tTue, 12 Sep 2017 15:02:18 +0200 (CEST)",
            "from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75])\n\tby dpdk.org (Postfix) with ESMTP id 7436D2C2A\n\tfor <dev@dpdk.org>; Tue, 12 Sep 2017 15:02:16 +0200 (CEST)",
            "from rcdn-core-2.cisco.com ([173.37.93.153])\n\tby rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Sep 2017 13:02:15 +0000",
            "from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com\n\t[172.18.5.114])\n\tby rcdn-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v8CD2Fx4015621;\n\tTue, 12 Sep 2017 13:02:15 GMT",
            "by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087)\n\tid 47DB1595; Tue, 12 Sep 2017 09:02:15 -0400 (EDT)"
        ],
        "X-IronPort-AV": "E=Sophos;i=\"5.42,383,1500940800\"; d=\"scan'208\";a=\"294333762\"",
        "From": "David Harton <dharton@cpp-rtpbld-31.cpprtplab>",
        "To": "beilei.xing@intel.com, jingjing.wu@intel.com",
        "Cc": "dev@dpdk.org, David Harton <dharton@cisco.com>",
        "Date": "Tue, 12 Sep 2017 09:02:10 -0400",
        "Message-Id": "<20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab>",
        "X-Mailer": "git-send-email 2.10.3.dirty",
        "In-Reply-To": "<20170822222146.36912-1-dharton@cisco.com>",
        "References": "<20170822222146.36912-1-dharton@cisco.com>",
        "Subject": "[dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit\n\tmulticast addresses",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: David Harton <dharton@cisco.com>\n\nThe i40e maintains a single MAC filter table for both\nunicast and multicast addresses.  The i40e_validate_mac_addr\nfunction was preventing multicast addresses from being added\nto the table via i40evf_add_mac_addr.  Fixed the issue by\nadjusting the check in i40evf_add_mac_addr.\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\nFixes: 97ac72aa71a9 (\"i40e: support setting VF MAC address\")\n\nSigned-off-by: David Harton <dharton@cisco.com>\n---\n\nv2\n* Removed multicast check in i40evf_add_mac_addr.\n\nv1\n* Removed multicast check in i40e_validate_mac_addr.\n\n drivers/net/i40e/i40e_ethdev_vf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex f6d8293..5916d11 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -888,7 +888,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,\n \tint err;\n \tstruct vf_cmd_info args;\n \n-\tif (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {\n+\tif (is_zero_ether_addr(addr) != I40E_SUCCESS) {\n \t\tPMD_DRV_LOG(ERR, \"Invalid mac:%x:%x:%x:%x:%x:%x\",\n \t\t\t    addr->addr_bytes[0], addr->addr_bytes[1],\n \t\t\t    addr->addr_bytes[2], addr->addr_bytes[3],\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}