Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28469/?format=api
{ "id": 28469, "url": "https://patches.dpdk.org/api/patches/28469/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1504802598-27296-2-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1504802598-27296-2-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1504802598-27296-2-git-send-email-bernard.iremonger@intel.com", "date": "2017-09-07T16:43:13", "name": "[dpdk-dev,v5,1/6] librte_table: fix acl entry add and delete functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1024b1930aabc5943020a5de578a8bf7cd1002ef", "submitter": { "id": 91, "url": "https://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1504802598-27296-2-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28469/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/28469/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 04AAA199B2;\n\tThu, 7 Sep 2017 18:43:32 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id B17102BFF;\n\tThu, 7 Sep 2017 18:43:28 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Sep 2017 09:43:28 -0700", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby orsmga005.jf.intel.com with ESMTP; 07 Sep 2017 09:43:26 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,359,1500966000\"; d=\"scan'208\";a=\"146649120\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org, ferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tcristian.dumitrescu@intel.com, adrien.mazarguil@6wind.com", "Cc": "Bernard Iremonger <bernard.iremonger@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 7 Sep 2017 17:43:13 +0100", "Message-Id": "<1504802598-27296-2-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1504693668-2062-1-git-send-email-bernard.iremonger@intel.com>", "References": "<1504693668-2062-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 1/6] librte_table: fix acl entry add and\n\tdelete functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rte_table_acl_entry_add() function was returning data from\nacl_memory instead of acl_rule_memory. It was also returning data\nfrom entry instead of entry_ptr.\n\nThe rte_table_acl_entry_delete() function was returning data from\nacl_memory instead of acl_rule_memory.\n\nFixes: 166923eb2f78 (\"table: ACL\")\nCc: stable@dpdk.org\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n lib/librte_table/rte_table_acl.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_table/rte_table_acl.c b/lib/librte_table/rte_table_acl.c\nindex 3c05e4a..e84b437 100644\n--- a/lib/librte_table/rte_table_acl.c\n+++ b/lib/librte_table/rte_table_acl.c\n@@ -316,8 +316,7 @@ struct rte_table_acl {\n \t\tif (status == 0) {\n \t\t\t*key_found = 1;\n \t\t\t*entry_ptr = &acl->memory[i * acl->entry_size];\n-\t\t\tmemcpy(*entry_ptr, entry, acl->entry_size);\n-\n+\t\t\tmemcpy(entry, *entry_ptr, acl->entry_size);\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -353,8 +352,8 @@ struct rte_table_acl {\n \t\trte_acl_free(acl->ctx);\n \tacl->ctx = ctx;\n \t*key_found = 0;\n-\t*entry_ptr = &acl->memory[free_pos * acl->entry_size];\n-\tmemcpy(*entry_ptr, entry, acl->entry_size);\n+\t*entry_ptr = &acl->acl_rule_memory[free_pos * acl->entry_size];\n+\tmemcpy(entry, *entry_ptr, acl->entry_size);\n \n \treturn 0;\n }\n@@ -435,7 +434,7 @@ struct rte_table_acl {\n \tacl->ctx = ctx;\n \t*key_found = 1;\n \tif (entry != NULL)\n-\t\tmemcpy(entry, &acl->memory[pos * acl->entry_size],\n+\t\tmemcpy(entry, &acl->acl_rule_memory[pos * acl->entry_size],\n \t\t\tacl->entry_size);\n \n \treturn 0;\n", "prefixes": [ "dpdk-dev", "v5", "1/6" ] }