Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2839/?format=api
https://patches.dpdk.org/api/patches/2839/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1422544811-26385-8-git-send-email-sergio.gonzalez.monroy@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1422544811-26385-8-git-send-email-sergio.gonzalez.monroy@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1422544811-26385-8-git-send-email-sergio.gonzalez.monroy@intel.com", "date": "2015-01-29T15:20:10", "name": "[dpdk-dev,7/8] mk: update LDLIBS for app building", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fcf43244727dad971c32ff754ca5854a394d0577", "submitter": { "id": 73, "url": "https://patches.dpdk.org/api/people/73/?format=api", "name": "Sergio Gonzalez Monroy", "email": "sergio.gonzalez.monroy@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1422544811-26385-8-git-send-email-sergio.gonzalez.monroy@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2839/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2839/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<smonroy@ecsmtp.ir.intel.com>", "Received": [ "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 975245A7D\n\tfor <dev@dpdk.org>; Thu, 29 Jan 2015 16:20:17 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 29 Jan 2015 07:15:51 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 29 Jan 2015 07:12:59 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt0TFKCgh031974 for <dev@dpdk.org>; Thu, 29 Jan 2015 15:20:12 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t0TFKCgd026472\n\tfor <dev@dpdk.org>; Thu, 29 Jan 2015 15:20:12 GMT", "(from smonroy@localhost)\n\tby sivswdev02.ir.intel.com with id t0TFKCFX026468\n\tfor dev@dpdk.org; Thu, 29 Jan 2015 15:20:12 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,486,1418112000\"; d=\"scan'208\";a=\"519676273\"", "From": "Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 29 Jan 2015 15:20:10 +0000", "Message-Id": "<1422544811-26385-8-git-send-email-sergio.gonzalez.monroy@intel.com>", "X-Mailer": "git-send-email 1.8.5.4", "In-Reply-To": "<1422544811-26385-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "References": "<1422544811-26385-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "Subject": "[dpdk-dev] [PATCH 7/8] mk: update LDLIBS for app building", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 29 Jan 2015 15:20:22 -0000" }, "content": "This patch does:\n - Update the app building command to link against librte_core.\n - Set --start-group/--end-group and --whole-archive/--no-whole-archive\n flags only when linking against static DPDK libs.\n - Set --as-needed when linking against shared DPDK libs.\n - Link against EXECENV_LIBS always with --as-needed flag.\n\nSigned-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>\n---\n mk/rte.app.mk | 45 ++++++++++++++-------------------------------\n 1 file changed, 14 insertions(+), 31 deletions(-)", "diff": "diff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 4c70743..2c9a856 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -59,7 +59,14 @@ LDLIBS += -L$(RTE_SDK_BIN)/lib\n #\n ifeq ($(NO_AUTOLIBS),)\n \n-LDLIBS += --whole-archive\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n+LDLIBS += --as-needed\n+else\n+LDLIBS += --no-as-needed\n+LDLIBS += --start-group\n+endif\n+\n+LDLIBS += -lrte_core\n \n ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)\n LDLIBS += -lrte_distributor\n@@ -124,19 +131,14 @@ LDLIBS += -lpcap\n endif\n \n ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)\n+LDLIBS += -lrte_vhost\n LDLIBS += -lfuse\n endif\n \n-LDLIBS += --start-group\n-\n ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y)\n LDLIBS += -lrte_kvargs\n endif\n \n-ifeq ($(CONFIG_RTE_LIBRTE_MBUF),y)\n-LDLIBS += -lrte_mbuf\n-endif\n-\n ifeq ($(CONFIG_RTE_LIBRTE_IP_FRAG),y)\n LDLIBS += -lrte_ip_frag\n endif\n@@ -145,22 +147,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_ETHER),y)\n LDLIBS += -lethdev\n endif\n \n-ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y)\n-LDLIBS += -lrte_malloc\n-endif\n-\n-ifeq ($(CONFIG_RTE_LIBRTE_MEMPOOL),y)\n-LDLIBS += -lrte_mempool\n-endif\n-\n-ifeq ($(CONFIG_RTE_LIBRTE_RING),y)\n-LDLIBS += -lrte_ring\n-endif\n-\n-ifeq ($(CONFIG_RTE_LIBRTE_EAL),y)\n-LDLIBS += -lrte_eal\n-endif\n-\n ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y)\n LDLIBS += -lrte_cmdline\n endif\n@@ -180,6 +166,7 @@ endif\n \n ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)\n # plugins (link only if static libraries)\n+LDLIBS += --whole-archive\n \n ifeq ($(CONFIG_RTE_LIBRTE_VMXNET3_PMD),y)\n LDLIBS += -lrte_pmd_vmxnet3_uio\n@@ -189,10 +176,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_VIRTIO_PMD),y)\n LDLIBS += -lrte_pmd_virtio_uio\n endif\n \n-ifeq ($(CONFIG_RTE_LIBRTE_VHOST), y)\n-LDLIBS += -lrte_vhost\n-endif\n-\n ifeq ($(CONFIG_RTE_LIBRTE_ENIC_PMD),y)\n LDLIBS += -lrte_pmd_enic\n endif\n@@ -221,14 +204,14 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_AF_PACKET),y)\n LDLIBS += -lrte_pmd_af_packet\n endif\n \n+LDLIBS += --no-whole-archive\n+LDLIBS += --end-group\n+LDLIBS += --as-needed\n+\n endif # plugins\n \n LDLIBS += $(EXECENV_LDLIBS)\n \n-LDLIBS += --end-group\n-\n-LDLIBS += --no-whole-archive\n-\n endif # ifeq ($(NO_AUTOLIBS),)\n \n LDLIBS += $(CPU_LDLIBS)\n", "prefixes": [ "dpdk-dev", "7/8" ] }{ "id": 2839, "url": "