Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28333,
    "url": "https://patches.dpdk.org/api/patches/28333/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1504549066-11067-4-git-send-email-markus.theil@tu-ilmenau.de/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1504549066-11067-4-git-send-email-markus.theil@tu-ilmenau.de>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1504549066-11067-4-git-send-email-markus.theil@tu-ilmenau.de",
    "date": "2017-09-04T18:17:45",
    "name": "[dpdk-dev,v6,4/5] igb_uio: release in exact reverse order",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "435540fd071b411f11092b4b58b00d894ddb74e8",
    "submitter": {
        "id": 747,
        "url": "https://patches.dpdk.org/api/people/747/?format=api",
        "name": "Markus Theil",
        "email": "markus.theil@tu-ilmenau.de"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1504549066-11067-4-git-send-email-markus.theil@tu-ilmenau.de/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/28333/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/28333/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2405C7D42;\n\tMon,  4 Sep 2017 20:18:08 +0200 (CEST)",
            "from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de\n\t[141.24.186.67]) by dpdk.org (Postfix) with ESMTP id BA8697CF2\n\tfor <dev@dpdk.org>; Mon,  4 Sep 2017 20:18:03 +0200 (CEST)",
            "from thunderstorm.prakinf.tu-ilmenau.de\n\t(thunderstorm.prakinf.tu-ilmenau.de [141.24.212.108])\n\tby smail.rz.tu-ilmenau.de (Postfix) with ESMTPA id 63968580062;\n\tMon,  4 Sep 2017 20:18:03 +0200 (CEST)"
        ],
        "From": "Markus Theil <markus.theil@tu-ilmenau.de>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, stephen@networkplumber.org,\n\tMarkus Theil <markus.theil@tu-ilmenau.de>",
        "Date": "Mon,  4 Sep 2017 20:17:45 +0200",
        "Message-Id": "<1504549066-11067-4-git-send-email-markus.theil@tu-ilmenau.de>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1504549066-11067-1-git-send-email-markus.theil@tu-ilmenau.de>",
        "References": "<1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de>\n\t<1504549066-11067-1-git-send-email-markus.theil@tu-ilmenau.de>",
        "Subject": "[dpdk-dev] [PATCH v6 4/5] igb_uio: release in exact reverse order",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "For better readability throughout the module, the destruction\norder is changed to the exact inverse construction order.\n\nSigned-off-by: Markus Theil <markus.theil@tu-ilmenau.de>\n---\n lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c\nindex 6885e72..c570eed 100644\n--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c\n+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c\n@@ -482,7 +482,7 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)\n \n \terr = sysfs_create_group(&dev->dev.kobj, &dev_attr_grp);\n \tif (err != 0)\n-\t\tgoto fail_release_iomem;\n+\t\tgoto fail_disable_interrupts;\n \n \t/* register uio driver */\n \terr = uio_register_device(&dev->dev, &udev->info);\n@@ -519,9 +519,10 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)\n \n fail_remove_group:\n \tsysfs_remove_group(&dev->dev.kobj, &dev_attr_grp);\n+fail_disable_interrupts:\n+\tigbuio_pci_disable_interrupts(udev);\n fail_release_iomem:\n \tigbuio_pci_release_iomem(&udev->info);\n-\tigbuio_pci_disable_interrupts(udev);\n \tpci_disable_device(dev);\n fail_free:\n \tkfree(udev);\n@@ -536,8 +537,8 @@ igbuio_pci_remove(struct pci_dev *dev)\n \n \tsysfs_remove_group(&dev->dev.kobj, &dev_attr_grp);\n \tuio_unregister_device(&udev->info);\n-\tigbuio_pci_release_iomem(&udev->info);\n \tigbuio_pci_disable_interrupts(udev);\n+\tigbuio_pci_release_iomem(&udev->info);\n \tpci_disable_device(dev);\n \tpci_set_drvdata(dev, NULL);\n \tkfree(udev);\n",
    "prefixes": [
        "dpdk-dev",
        "v6",
        "4/5"
    ]
}