Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28269/?format=api
{ "id": 28269, "url": "https://patches.dpdk.org/api/patches/28269/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170901100416.80264-17-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170901100416.80264-17-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170901100416.80264-17-bruce.richardson@intel.com", "date": "2017-09-01T10:04:15", "name": "[dpdk-dev,16/17] build: add option to version libs using DPDK version", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2a7fda89056f5adcc815dbbde26a121f5a3c3c1e", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170901100416.80264-17-bruce.richardson@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28269/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/28269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7B4827D72;\n\tFri, 1 Sep 2017 12:18:37 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 93D057D6B\n\tfor <dev@dpdk.org>; Fri, 1 Sep 2017 12:18:35 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Sep 2017 03:18:35 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby fmsmga004.fm.intel.com with ESMTP; 01 Sep 2017 03:18:34 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.41,457,1498546800\"; d=\"scan'208\";a=\"306892647\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 1 Sep 2017 11:04:15 +0100", "Message-Id": "<20170901100416.80264-17-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170901100416.80264-1-bruce.richardson@intel.com>", "References": "<20170901100416.80264-1-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH 16/17] build: add option to version libs using\n\tDPDK version", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Normally, each library has it's own version number based on the ABI.\nAdd an option to have all libs just use the DPDK version number as the\n.so version.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 8 +++++++-\n lib/meson.build | 8 +++++++-\n meson_options.txt | 1 +\n 3 files changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex d7a614f83..76d610a5b 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -92,6 +92,12 @@ foreach class:driver_classes\n \t\t\t\t\t\tdepends: [pmdinfogen, tmp_lib])\n \t\t\tendforeach\n \n+\t\t\tif get_option('per_library_versions')\n+\t\t\t\tso_version = '@0@.1'.format(version)\n+\t\t\telse\n+\t\t\t\tso_version = meson.project_version()\n+\t\t\tendif\n+\n \t\t\t# now build the driver itself, and add to the drivers list\n \t\t\tlib_name = driver_name_fmt.format(name)\n \t\t\tversion_map = '@0@/@1@/@2@_version.map'.format(\n@@ -105,7 +111,7 @@ foreach class:driver_classes\n \t\t\t\tc_args: cflags,\n \t\t\t\tlink_args: '-Wl,--version-script=' + version_map,\n \t\t\t\tlink_depends: version_map,\n-\t\t\t\tversion: '@0@.1'.format(version),\n+\t\t\t\tversion: so_version,\n \t\t\t\tinstall: true,\n \t\t\t\tinstall_dir: driver_install_path)\n \ndiff --git a/lib/meson.build b/lib/meson.build\nindex b8c4304de..e20a9ab59 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -76,6 +76,12 @@ foreach l:libraries\n \t\t\tdep_objs += [get_variable('dep_rte_' + d)]\n \t\tendforeach\n \n+\t\tif get_option('per_library_versions')\n+\t\t\tso_version = '@0@.1'.format(version)\n+\t\telse\n+\t\t\tso_version = meson.project_version()\n+\t\tendif\n+\n \t\tversion_map = '@0@/@1@/rte_@2@_version.map'.format(\n \t\t\t\tmeson.current_source_dir(), dir_name, name)\n \t\tlibname = 'rte_' + name\n@@ -87,7 +93,7 @@ foreach l:libraries\n \t\t\t\tinclude_directories: include_directories(dir_name),\n \t\t\t\tlink_args: '-Wl,--version-script=' + version_map,\n \t\t\t\tlink_depends: version_map,\n-\t\t\t\tversion: '@0@.1'.format(version),\n+\t\t\t\tversion: so_version,\n \t\t\t\tinstall: true)\n \t\tdep = declare_dependency(link_with: lib,\n \t\t\t\tinclude_directories: include_directories(dir_name),\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9c45b8159..636226ce8 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -6,3 +6,4 @@ option('allow_invalid_socket_id', type: 'boolean', value: false,\n \tdescription: 'allow out-of-range NUMA socket id\\'s for platforms that don\\'t report the value correctly')\n option('enable_kmods', type: 'boolean', value: true, description: 'build kernel modules')\n option('kernel_dir', type: 'string', value: '', description: 'path to the kernel for building kernel modules')\n+option('per_library_versions', type: 'boolean', value: true, description: 'true: each lib gets its own version number, false: DPDK version used for each lib')\n", "prefixes": [ "dpdk-dev", "16/17" ] }