Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28069,
    "url": "https://patches.dpdk.org/api/patches/28069/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1504064593-9068-1-git-send-email-zengganghui@huawei.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1504064593-9068-1-git-send-email-zengganghui@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1504064593-9068-1-git-send-email-zengganghui@huawei.com",
    "date": "2017-08-30T03:43:13",
    "name": "[dpdk-dev] net/bonding: strengthen the judgment of lacp packets",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "794a8c517df7cde5efe038f6c3a7a1c858c749ad",
    "submitter": {
        "id": 821,
        "url": "https://patches.dpdk.org/api/people/821/?format=api",
        "name": "ZengGanghui",
        "email": "zengganghui@huawei.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1504064593-9068-1-git-send-email-zengganghui@huawei.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/28069/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/28069/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 898F229D6;\n\tWed, 30 Aug 2017 05:43:27 +0200 (CEST)",
            "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n\tby dpdk.org (Postfix) with ESMTP id BCB7AFFA\n\tfor <dev@dpdk.org>; Wed, 30 Aug 2017 05:43:24 +0200 (CEST)",
            "from 172.30.72.59 (EHLO DGGEMS414-HUB.china.huawei.com)\n\t([172.30.72.59])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DGG03455; Wed, 30 Aug 2017 11:43:21 +0800 (CST)",
            "from localhost (10.177.241.172) by DGGEMS414-HUB.china.huawei.com\n\t(10.3.19.214) with Microsoft SMTP Server id 14.3.301.0;\n\tWed, 30 Aug 2017 11:43:16 +0800"
        ],
        "From": "ZengGanghui <zengganghui@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<declan.doherty@intel.com>",
        "Date": "Wed, 30 Aug 2017 11:43:13 +0800",
        "Message-ID": "<1504064593-9068-1-git-send-email-zengganghui@huawei.com>",
        "X-Mailer": "git-send-email 1.9.5.msysgit.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.177.241.172]",
        "X-CFilter-Loop": "Reflected",
        "X-Mirapoint-Virus-RAPID-Raw": "score=unknown(0),\n\trefid=str=0001.0A020202.59A6345A.0014, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32",
        "X-Mirapoint-Loop-Id": "750641de3051c221e127aefd1b77493d",
        "Subject": "[dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp\n\tpackets",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When the nic does not support vlan rx offload may be wrong, resulting in\nlacp packets will not be processed.\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 383e27c..7feb12f 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -125,11 +125,12 @@\n }\n \n static inline uint8_t\n-is_lacp_packets(uint16_t ethertype, uint8_t subtype, uint16_t vlan_tci)\n+is_lacp_packets(uint16_t ethertype, uint8_t subtype, struct rte_mbuf *mbuf)\n {\n \tconst uint16_t ether_type_slow_be = rte_be_to_cpu_16(ETHER_TYPE_SLOW);\n \n-\treturn !vlan_tci && (ethertype == ether_type_slow_be &&\n+\treturn !((mbuf->ol_flags & PKT_RX_VLAN_PKT) ? mbuf->vlan_tci : 0) &&\n+\t\t(ethertype == ether_type_slow_be &&\n \t\t(subtype == SLOW_SUBTYPE_MARKER || subtype == SLOW_SUBTYPE_LACP));\n }\n \n@@ -444,7 +445,7 @@\n \t\t\t/* Remove packet from array if it is slow packet or slave is not\n \t\t\t * in collecting state or bonding interface is not in promiscuous\n \t\t\t * mode and packet address does not match. */\n-\t\t\tif (unlikely(is_lacp_packets(hdr->ether_type, subtype, bufs[j]->vlan_tci) ||\n+\t\t\tif (unlikely(is_lacp_packets(hdr->ether_type, subtype, bufs[j]) ||\n \t\t\t\t!collecting || (!promisc &&\n \t\t\t\t\t!is_multicast_ether_addr(&hdr->d_addr) &&\n \t\t\t\t\t!is_same_ether_addr(&bond_mac, &hdr->d_addr)))) {\n",
    "prefixes": [
        "dpdk-dev"
    ]
}