Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28008/?format=api
{ "id": 28008, "url": "https://patches.dpdk.org/api/patches/28008/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/76fe16eae3fb6f57f2272722a1d9af5a38221801.1503676587.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<76fe16eae3fb6f57f2272722a1d9af5a38221801.1503676587.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/76fe16eae3fb6f57f2272722a1d9af5a38221801.1503676587.git.gaetan.rivet@6wind.com", "date": "2017-08-25T16:07:26", "name": "[dpdk-dev,6/6] devargs: make devargs_list private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0f86a1e1f3bd2a947d86e41d57352dd8818804df", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/76fe16eae3fb6f57f2272722a1d9af5a38221801.1503676587.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28008/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/28008/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 36A3A7D97;\n\tFri, 25 Aug 2017 18:08:34 +0200 (CEST)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 1894A7D5E\n\tfor <dev@dpdk.org>; Fri, 25 Aug 2017 18:08:30 +0200 (CEST)", "by mail-wm0-f52.google.com with SMTP id y71so1769553wmd.0\n\tfor <dev@dpdk.org>; Fri, 25 Aug 2017 09:08:30 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\th190sm1351661wmd.4.2017.08.25.09.08.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 25 Aug 2017 09:08:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=lZkrYlyg7TVr16owf+RGWTOwVuOsffhGjejZhzY/EQ4=;\n\tb=1fgQNkY8BJaqQ4+TLVdaJMw5fgO68i0h12d3V9Jhr+iufX9rQarXMEifuxkdB3sJRm\n\tcK54vxrrK3w8jbiijwCVNR0CM/oBBzJOounXt3lv6kMGa2oxhTrQhqaDO0YL9Yh7oZBf\n\tqDu5zr3KDx8jLkWuVy4FoQyE2Df/16nUqKTvGLtToeEAwglWcio+NyfQaqT2JqvmqY6J\n\tk/w0Q+ZVAmheWxQ8uFT0mSM2SpWgtLW49x0IDWJ8bj7guG/OIZZBYdT7/iAuj5hftUXD\n\twMbRguS4Bz/Nw33Cug4WBN++pXJj95SG6vVtwIPAMKMliN7Q+feqpdkJAaLjoga5LbiQ\n\tsm3Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=lZkrYlyg7TVr16owf+RGWTOwVuOsffhGjejZhzY/EQ4=;\n\tb=GJqDESVzTQLPeZA02KZJSIf8rw5DXvG60Kf3105uQz+ZEJh50meeRZm7ug2Fd+5rBJ\n\tDy+fZQc3yZqlZiaHMBTMw2ytUZ+uFEYyiZcXdJ6uYTTHyLr9hYnvA1CsUHskxLK/wAeC\n\tKM/fLLsCm46rlAfXco+tM3ytaZekt8DWuOwXyTC14eSWlW8oVPa60xp9C2TiLQipD6DC\n\tvrzP6n3r9GuSyJBuEryFgRWnB4A2jNwcrMUD6XwMhZ+KBCvtOsvI0xX0Gt724CKakWcq\n\tg75b52q/5xXNVzaK5CCt7F0plQMtA/Q4708xtQwO/E95w9rlKzn5k4EsZv88P1ZZiafU\n\tRpBQ==", "X-Gm-Message-State": "AHYfb5iBXHWfshbLkJ4hunHRc0vYbJGgBV7WbQAeg/guz7NGqb22Uxek\n\ty1oEoqd/9xnHOMeML+I=", "X-Received": "by 10.28.46.9 with SMTP id u9mr1605055wmu.131.1503677309494;\n\tFri, 25 Aug 2017 09:08:29 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Fri, 25 Aug 2017 18:07:26 +0200", "Message-Id": "<76fe16eae3fb6f57f2272722a1d9af5a38221801.1503676587.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1503676587.git.gaetan.rivet@6wind.com>", "<cover.1503676587.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1503676587.git.gaetan.rivet@6wind.com>", "<cover.1503676587.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH 6/6] devargs: make devargs_list private", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Initially, rte_devargs was meant to be populated once and sometimes\naccessed, then never emptied.\n\nWith the new hotplug functionality having better standing, new usage\nappeared with repeated addition of devices and their subsequent removal.\n\nExposing devargs_list pushed bus drivers and libraries to be careless\nand inconsistent in their memory management. Making it private will\nallow to rationalize this part of the EAL and ensure that fewer memory leaks\noccur during operations.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -\n lib/librte_eal/common/eal_common_devargs.c | 3 +++\n lib/librte_eal/common/include/rte_devargs.h | 6 ------\n lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 -\n 4 files changed, 3 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\nindex 610db67..91621b1 100644\n--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n@@ -2,7 +2,6 @@ DPDK_2.0 {\n \tglobal:\n \n \t__rte_panic;\n-\tdevargs_list;\n \teal_parse_sysfs_value;\n \teal_timer_source;\n \tlcore_config;\ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex e0e47e8..2b20ce0 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -45,6 +45,9 @@\n #include <rte_tailq.h>\n #include \"eal_private.h\"\n \n+/** user device double-linked queue type definition */\n+TAILQ_HEAD(rte_devargs_list, rte_devargs);\n+\n /** Global list of user devices */\n struct rte_devargs_list devargs_list =\n \tTAILQ_HEAD_INITIALIZER(devargs_list);\ndiff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h\nindex 5ca5a32..d07810f 100644\n--- a/lib/librte_eal/common/include/rte_devargs.h\n+++ b/lib/librte_eal/common/include/rte_devargs.h\n@@ -86,12 +86,6 @@ struct rte_devargs {\n \tchar *args;\n };\n \n-/** user device double-linked queue type definition */\n-TAILQ_HEAD(rte_devargs_list, rte_devargs);\n-\n-/** Global list of user devices */\n-extern struct rte_devargs_list devargs_list;\n-\n /**\n * Parse a devargs string.\n *\ndiff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\nindex c1bc704..6595b64 100644\n--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n@@ -2,7 +2,6 @@ DPDK_2.0 {\n \tglobal:\n \n \t__rte_panic;\n-\tdevargs_list;\n \teal_parse_sysfs_value;\n \teal_timer_source;\n \tlcore_config;\n", "prefixes": [ "dpdk-dev", "6/6" ] }