Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28007/?format=api
{ "id": 28007, "url": "https://patches.dpdk.org/api/patches/28007/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/e9d62cb8d70115f61525dc390dd35013c2993be8.1503676587.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e9d62cb8d70115f61525dc390dd35013c2993be8.1503676587.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e9d62cb8d70115f61525dc390dd35013c2993be8.1503676587.git.gaetan.rivet@6wind.com", "date": "2017-08-25T16:07:25", "name": "[dpdk-dev,5/6] test: remove rte_devargs unit tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d31b8226a4623050408145b4e3035b4ea7e5808d", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/e9d62cb8d70115f61525dc390dd35013c2993be8.1503676587.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28007/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/28007/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id ACFEB7D8B;\n\tFri, 25 Aug 2017 18:08:32 +0200 (CEST)", "from mail-wm0-f53.google.com (mail-wm0-f53.google.com\n\t[74.125.82.53]) by dpdk.org (Postfix) with ESMTP id EB3A67D5E\n\tfor <dev@dpdk.org>; Fri, 25 Aug 2017 18:08:28 +0200 (CEST)", "by mail-wm0-f53.google.com with SMTP id b189so1951690wmd.0\n\tfor <dev@dpdk.org>; Fri, 25 Aug 2017 09:08:28 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\th190sm1351661wmd.4.2017.08.25.09.08.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 25 Aug 2017 09:08:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=LGvl9v6cy0e84+nPwYX4MI2Xk+26ld2LUlo+RpcykW4=;\n\tb=IEqyhHHSWv4HdkkX9+4uKgE7y6CiWBoyOEh+dq1YccCs9lcnXvCKfyqd654LvtRgDt\n\tn0PbM3tuaoPPWAJno0UHiasnMY4+EPRO39ZW+KLdvb44WjP09+b1VJDMbT0VgetODtU0\n\t8oMWWClUjDfbChfmKL3gkCDsMaVWPnATgpzCVfrmkxQyANMjLxFLk1Os1LM6Kqy9hXvJ\n\t2KXoUsJgELAMGp2kufJkz/nT1c7cCbycNPjhk1gEw03SoePjmvxi9Et30kaDxKyNwKmb\n\tN3JAqkzRswJnN9WIt2GGVcdOF8xLUxjmdcopi/afRgpewMbBXQ9GtFKvgPTQCRUR5rhy\n\tKl3A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=LGvl9v6cy0e84+nPwYX4MI2Xk+26ld2LUlo+RpcykW4=;\n\tb=bbnBddQlEJ7ULQ9llee07GcRsYAKM0YcbSfvPn/nvGVBQ/UwBo1GOnVx5ME2jSZw7R\n\trq6M3+V7fpiPu2KSyOzxozmPSiySgs2B/Fo4AB2/qB2l9tMXuI8bmJkQLeWskuCC3etC\n\twQFoImHER+N3oMmM331EuTvmH+wUptT6jhuxA8dBD8P9OQ8HeZ3ZpJuyN7gFHfcxGpDU\n\tlu2TCKVRhwOBOyPVEm9H8rfR7ObARp5a1bVp+k8WvqtU9o0ypQKqQUexvPnpdcJ+Mty4\n\tJcDWpscdACwOeZpc/QjKGcZKLW0A6OerhmJID3d7zZBl6f+QQEdPecS6T8dF7bZvwjQ/\n\tVY5w==", "X-Gm-Message-State": "AHYfb5jRkfnJeI49qimFjpqYcOiqqkrfSi7kR+hsP2U0x0uItOo23iFM\n\toRMh62nYv3nIyVY59e8=", "X-Received": "by 10.28.180.9 with SMTP id d9mr1200004wmf.167.1503677308136;\n\tFri, 25 Aug 2017 09:08:28 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Fri, 25 Aug 2017 18:07:25 +0200", "Message-Id": "<e9d62cb8d70115f61525dc390dd35013c2993be8.1503676587.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1503676587.git.gaetan.rivet@6wind.com>", "<cover.1503676587.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1503676587.git.gaetan.rivet@6wind.com>", "<cover.1503676587.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH 5/6] test: remove rte_devargs unit tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current test will not be compatible anymore with a private\ndevargs_list.\n\nMoreover, the new functions should have new tests, while the existing\nAPI will be removed.\n\nThe current unit tests are thus obsolete and hereby removed.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n MAINTAINERS | 1 -\n test/test/Makefile | 1 -\n test/test/test_devargs.c | 131 -----------------------------------------------\n 3 files changed, 133 deletions(-)\n delete mode 100644 test/test/test_devargs.c", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex a0cd75e..f6a096a 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -93,7 +93,6 @@ F: test/test/test_common.c\n F: test/test/test_cpuflags.c\n F: test/test/test_cycles.c\n F: test/test/test_debug.c\n-F: test/test/test_devargs.c\n F: test/test/test_eal*\n F: test/test/test_errno.c\n F: test/test/test_interrupts.c\ndiff --git a/test/test/Makefile b/test/test/Makefile\nindex 42d9a49..42c9cea 100644\n--- a/test/test/Makefile\n+++ b/test/test/Makefile\n@@ -180,7 +180,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += test_distributor_perf.c\n \n SRCS-$(CONFIG_RTE_LIBRTE_REORDER) += test_reorder.c\n \n-SRCS-y += test_devargs.c\n SRCS-y += virtual_pmd.c\n SRCS-y += packet_burst_generator.c\n SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c\ndiff --git a/test/test/test_devargs.c b/test/test/test_devargs.c\ndeleted file mode 100644\nindex 18f54ed..0000000\n--- a/test/test/test_devargs.c\n+++ /dev/null\n@@ -1,131 +0,0 @@\n-/*-\n- * BSD LICENSE\n- *\n- * Copyright 2014 6WIND S.A.\n- *\n- * Redistribution and use in source and binary forms, with or without\n- * modification, are permitted provided that the following conditions\n- * are met:\n- *\n- * * Redistributions of source code must retain the above copyright\n- * notice, this list of conditions and the following disclaimer.\n- * * Redistributions in binary form must reproduce the above copyright\n- * notice, this list of conditions and the following disclaimer in\n- * the documentation and/or other materials provided with the\n- * distribution.\n- * * Neither the name of 6WIND S.A nor the names of its contributors\n- * may be used to endorse or promote products derived from this\n- * software without specific prior written permission.\n- *\n- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n- * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n- */\n-\n-#include <stdio.h>\n-#include <stdlib.h>\n-#include <string.h>\n-#include <sys/queue.h>\n-\n-#include <rte_debug.h>\n-#include <rte_devargs.h>\n-\n-#include \"test.h\"\n-\n-/* clear devargs list that was modified by the test */\n-static void free_devargs_list(void)\n-{\n-\tstruct rte_devargs *devargs;\n-\n-\twhile (!TAILQ_EMPTY(&devargs_list)) {\n-\t\tdevargs = TAILQ_FIRST(&devargs_list);\n-\t\tTAILQ_REMOVE(&devargs_list, devargs, next);\n-\t\tfree(devargs->args);\n-\t\tfree(devargs);\n-\t}\n-}\n-\n-static int\n-test_devargs(void)\n-{\n-\tstruct rte_devargs_list save_devargs_list;\n-\tstruct rte_devargs *devargs;\n-\n-\t/* save the real devargs_list, it is restored at the end of the test */\n-\tsave_devargs_list = devargs_list;\n-\tTAILQ_INIT(&devargs_list);\n-\n-\t/* test valid cases */\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \"08:00.1\") < 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \"0000:5:00.0\") < 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_BLACKLISTED_PCI, \"04:00.0,arg=val\") < 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_BLACKLISTED_PCI, \"0000:01:00.1\") < 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) != 2)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_type_count(RTE_DEVTYPE_BLACKLISTED_PCI) != 2)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_type_count(RTE_DEVTYPE_VIRTUAL) != 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL, \"net_ring0\") < 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL, \"net_ring1,key=val,k2=val2\") < 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_type_count(RTE_DEVTYPE_VIRTUAL) != 2)\n-\t\tgoto fail;\n-\tfree_devargs_list();\n-\n-\t/* check virtual device with argument parsing */\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL, \"net_ring1,k1=val,k2=val2\") < 0)\n-\t\tgoto fail;\n-\tdevargs = TAILQ_FIRST(&devargs_list);\n-\tif (strncmp(devargs->name, \"net_ring1\",\n-\t\t\tsizeof(devargs->name)) != 0)\n-\t\tgoto fail;\n-\tif (!devargs->args || strcmp(devargs->args, \"k1=val,k2=val2\") != 0)\n-\t\tgoto fail;\n-\tfree_devargs_list();\n-\n-\t/* check PCI device with empty argument parsing */\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \"04:00.1\") < 0)\n-\t\tgoto fail;\n-\tdevargs = TAILQ_FIRST(&devargs_list);\n-\tif (strcmp(devargs->name, \"04:00.1\") != 0)\n-\t\tgoto fail;\n-\tif (!devargs->args || strcmp(devargs->args, \"\") != 0)\n-\t\tgoto fail;\n-\tfree_devargs_list();\n-\n-\t/* test error case: bad PCI address */\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \"08:1\") == 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \"00.1\") == 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \"foo\") == 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \",\") == 0)\n-\t\tgoto fail;\n-\tif (rte_eal_devargs_add(RTE_DEVTYPE_WHITELISTED_PCI, \"000f:0:0\") == 0)\n-\t\tgoto fail;\n-\n-\tdevargs_list = save_devargs_list;\n-\treturn 0;\n-\n- fail:\n-\tfree_devargs_list();\n-\tdevargs_list = save_devargs_list;\n-\treturn -1;\n-}\n-\n-REGISTER_TEST_COMMAND(devargs_autotest, test_devargs);\n", "prefixes": [ "dpdk-dev", "5/6" ] }