Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/280/?format=api
{ "id": 280, "url": "https://patches.dpdk.org/api/patches/280/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1409567080-27083-8-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1409567080-27083-8-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1409567080-27083-8-git-send-email-david.marchand@6wind.com", "date": "2014-09-01T10:24:30", "name": "[dpdk-dev,v2,07/17] i40e: use the right debug macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1fae8dd26f3dd3327b9d9844cca1b22660179fbe", "submitter": { "id": 3, "url": "https://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1409567080-27083-8-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/280/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/280/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<david.marchand@6wind.com>", "Received": [ "from mail-we0-f178.google.com (mail-we0-f178.google.com\n\t[74.125.82.178]) by dpdk.org (Postfix) with ESMTP id 9AC77B3C4\n\tfor <dev@dpdk.org>; Mon, 1 Sep 2014 12:20:32 +0200 (CEST)", "by mail-we0-f178.google.com with SMTP id u57so5171528wes.23\n\tfor <dev@dpdk.org>; Mon, 01 Sep 2014 03:24:59 -0700 (PDT)", "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tlm18sm24287018wic.22.2014.09.01.03.24.55 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 01 Sep 2014 03:24:58 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=JResK2Qrzp/b96amGnVErqJRyifRSrOUNwl+0T4u4B8=;\n\tb=WNzzCFtGRS3jFJD6uqOVOfnE+3eMLqVLOBYq9zDFmNJPgOH+q1PdCVO24tj4l0e8lO\n\tdA/zkWqxNCQ2UE8bTMkmEzS9vg11t4PjspL606+Hqvwxiuy/WkIExsTt5dDtX8hMF+C5\n\tYzLXO9O7nDHawCp0Zd2vK865ELIYl77m3i/rPvFSaZg/mtN9rIzpcQYe5v90yBqRKGqe\n\tp/xxPGBLvN5Gga1Gb+bii/OrwdWDCg6nuzsmO5Bx8MvODYQlPZKqKoWIp6tY0Gn40t0r\n\tbj6V4tnEO2sy2pnH4PwpSmBfJ3DcFbUrFo8X8n/lMNst8zgrPBBfqWM0cJ9cY8IuyLkr\n\t+yhw==", "X-Gm-Message-State": "ALoCoQksV7g/iC9+4IKLn22IENjSvxyjzHXEDHMd22hx9tjH8e2reO5y48pxM5InSc7ORF5laJkY", "X-Received": "by 10.180.8.230 with SMTP id u6mr6278847wia.24.1409567099494;\n\tMon, 01 Sep 2014 03:24:59 -0700 (PDT)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 1 Sep 2014 12:24:30 +0200", "Message-Id": "<1409567080-27083-8-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1409567080-27083-1-git-send-email-david.marchand@6wind.com>", "References": "<1409567080-27083-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 07/17] i40e: use the right debug macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Mon, 01 Sep 2014 10:20:32 -0000" }, "content": "- Don't use DEBUGFUNC macro in non-shared code.\n- Don't use printf for logs.\n- We should avoid calling RTE_LOG directly as pmd provides a wrapper for logs.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 146 +++++++++++++++++-----------------\n lib/librte_pmd_i40e/i40e_ethdev_vf.c | 2 +-\n lib/librte_pmd_i40e/i40e_pf.c | 6 +-\n lib/librte_pmd_i40e/i40e_rxtx.c | 64 +++++++--------\n 4 files changed, 110 insertions(+), 108 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 4e65ca4..352beb1 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -1059,24 +1059,23 @@ i40e_update_vsi_stats(struct i40e_vsi *vsi)\n \t\t\t &oes->tx_errors, &nes->tx_errors);\n \tvsi->offset_loaded = true;\n \n-#ifdef RTE_LIBRTE_I40E_DEBUG_DRIVER\n-\tprintf(\"***************** VSI[%u] stats start *******************\\n\",\n-\t\t\t\t\t\t\t\tvsi->vsi_id);\n-\tprintf(\"rx_bytes: %lu\\n\", nes->rx_bytes);\n-\tprintf(\"rx_unicast: %lu\\n\", nes->rx_unicast);\n-\tprintf(\"rx_multicast: %lu\\n\", nes->rx_multicast);\n-\tprintf(\"rx_broadcast: %lu\\n\", nes->rx_broadcast);\n-\tprintf(\"rx_discards: %lu\\n\", nes->rx_discards);\n-\tprintf(\"rx_unknown_protocol: %lu\\n\", nes->rx_unknown_protocol);\n-\tprintf(\"tx_bytes: %lu\\n\", nes->tx_bytes);\n-\tprintf(\"tx_unicast: %lu\\n\", nes->tx_unicast);\n-\tprintf(\"tx_multicast: %lu\\n\", nes->tx_multicast);\n-\tprintf(\"tx_broadcast: %lu\\n\", nes->tx_broadcast);\n-\tprintf(\"tx_discards: %lu\\n\", nes->tx_discards);\n-\tprintf(\"tx_errors: %lu\\n\", nes->tx_errors);\n-\tprintf(\"***************** VSI[%u] stats end *******************\\n\",\n-\t\t\t\t\t\t\t\tvsi->vsi_id);\n-#endif /* RTE_LIBRTE_I40E_DEBUG_DRIVER */\n+\tPMD_DRV_LOG(DEBUG, \"***************** VSI[%u] stats start *******************\\n\",\n+\t\t vsi->vsi_id);\n+\tPMD_DRV_LOG(DEBUG, \"rx_bytes: %lu\\n\", nes->rx_bytes);\n+\tPMD_DRV_LOG(DEBUG, \"rx_unicast: %lu\\n\", nes->rx_unicast);\n+\tPMD_DRV_LOG(DEBUG, \"rx_multicast: %lu\\n\", nes->rx_multicast);\n+\tPMD_DRV_LOG(DEBUG, \"rx_broadcast: %lu\\n\", nes->rx_broadcast);\n+\tPMD_DRV_LOG(DEBUG, \"rx_discards: %lu\\n\", nes->rx_discards);\n+\tPMD_DRV_LOG(DEBUG, \"rx_unknown_protocol: %lu\\n\",\n+\t\t nes->rx_unknown_protocol);\n+\tPMD_DRV_LOG(DEBUG, \"tx_bytes: %lu\\n\", nes->tx_bytes);\n+\tPMD_DRV_LOG(DEBUG, \"tx_unicast: %lu\\n\", nes->tx_unicast);\n+\tPMD_DRV_LOG(DEBUG, \"tx_multicast: %lu\\n\", nes->tx_multicast);\n+\tPMD_DRV_LOG(DEBUG, \"tx_broadcast: %lu\\n\", nes->tx_broadcast);\n+\tPMD_DRV_LOG(DEBUG, \"tx_discards: %lu\\n\", nes->tx_discards);\n+\tPMD_DRV_LOG(DEBUG, \"tx_errors: %lu\\n\", nes->tx_errors);\n+\tPMD_DRV_LOG(DEBUG, \"***************** VSI[%u] stats end *******************\\n\",\n+\t\t vsi->vsi_id);\n }\n \n /* Get all statistics of a port */\n@@ -1277,69 +1276,74 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \tif (pf->main_vsi)\n \t\ti40e_update_vsi_stats(pf->main_vsi);\n \n-#ifdef RTE_LIBRTE_I40E_DEBUG_DRIVER\n-\tprintf(\"***************** PF stats start *******************\\n\");\n-\tprintf(\"rx_bytes: %lu\\n\", ns->eth.rx_bytes);\n-\tprintf(\"rx_unicast: %lu\\n\", ns->eth.rx_unicast);\n-\tprintf(\"rx_multicast: %lu\\n\", ns->eth.rx_multicast);\n-\tprintf(\"rx_broadcast: %lu\\n\", ns->eth.rx_broadcast);\n-\tprintf(\"rx_discards: %lu\\n\", ns->eth.rx_discards);\n-\tprintf(\"rx_unknown_protocol: %lu\\n\", ns->eth.rx_unknown_protocol);\n-\tprintf(\"tx_bytes: %lu\\n\", ns->eth.tx_bytes);\n-\tprintf(\"tx_unicast: %lu\\n\", ns->eth.tx_unicast);\n-\tprintf(\"tx_multicast: %lu\\n\", ns->eth.tx_multicast);\n-\tprintf(\"tx_broadcast: %lu\\n\", ns->eth.tx_broadcast);\n-\tprintf(\"tx_discards: %lu\\n\", ns->eth.tx_discards);\n-\tprintf(\"tx_errors: %lu\\n\", ns->eth.tx_errors);\n-\n-\tprintf(\"tx_dropped_link_down: %lu\\n\", ns->tx_dropped_link_down);\n-\tprintf(\"crc_errors: %lu\\n\", ns->crc_errors);\n-\tprintf(\"illegal_bytes: %lu\\n\", ns->illegal_bytes);\n-\tprintf(\"error_bytes: %lu\\n\", ns->error_bytes);\n-\tprintf(\"mac_local_faults: %lu\\n\", ns->mac_local_faults);\n-\tprintf(\"mac_remote_faults: %lu\\n\", ns->mac_remote_faults);\n-\tprintf(\"rx_length_errors: %lu\\n\", ns->rx_length_errors);\n-\tprintf(\"link_xon_rx: %lu\\n\", ns->link_xon_rx);\n-\tprintf(\"link_xoff_rx: %lu\\n\", ns->link_xoff_rx);\n+\tPMD_DRV_LOG(DEBUG, \"***************** PF stats start *******************\\n\");\n+\tPMD_DRV_LOG(DEBUG, \"rx_bytes: %lu\\n\", ns->eth.rx_bytes);\n+\tPMD_DRV_LOG(DEBUG, \"rx_unicast: %lu\\n\", ns->eth.rx_unicast);\n+\tPMD_DRV_LOG(DEBUG, \"rx_multicast: %lu\\n\", ns->eth.rx_multicast);\n+\tPMD_DRV_LOG(DEBUG, \"rx_broadcast: %lu\\n\", ns->eth.rx_broadcast);\n+\tPMD_DRV_LOG(DEBUG, \"rx_discards: %lu\\n\", ns->eth.rx_discards);\n+\tPMD_DRV_LOG(DEBUG, \"rx_unknown_protocol: %lu\\n\",\n+\t\t ns->eth.rx_unknown_protocol);\n+\tPMD_DRV_LOG(DEBUG, \"tx_bytes: %lu\\n\", ns->eth.tx_bytes);\n+\tPMD_DRV_LOG(DEBUG, \"tx_unicast: %lu\\n\", ns->eth.tx_unicast);\n+\tPMD_DRV_LOG(DEBUG, \"tx_multicast: %lu\\n\", ns->eth.tx_multicast);\n+\tPMD_DRV_LOG(DEBUG, \"tx_broadcast: %lu\\n\", ns->eth.tx_broadcast);\n+\tPMD_DRV_LOG(DEBUG, \"tx_discards: %lu\\n\", ns->eth.tx_discards);\n+\tPMD_DRV_LOG(DEBUG, \"tx_errors: %lu\\n\", ns->eth.tx_errors);\n+\n+\tPMD_DRV_LOG(DEBUG, \"tx_dropped_link_down: %lu\\n\",\n+\t\t ns->tx_dropped_link_down);\n+\tPMD_DRV_LOG(DEBUG, \"crc_errors: %lu\\n\", ns->crc_errors);\n+\tPMD_DRV_LOG(DEBUG, \"illegal_bytes: %lu\\n\",\n+\t\t ns->illegal_bytes);\n+\tPMD_DRV_LOG(DEBUG, \"error_bytes: %lu\\n\", ns->error_bytes);\n+\tPMD_DRV_LOG(DEBUG, \"mac_local_faults: %lu\\n\",\n+\t\t ns->mac_local_faults);\n+\tPMD_DRV_LOG(DEBUG, \"mac_remote_faults: %lu\\n\",\n+\t\t ns->mac_remote_faults);\n+\tPMD_DRV_LOG(DEBUG, \"rx_length_errors: %lu\\n\",\n+\t\t ns->rx_length_errors);\n+\tPMD_DRV_LOG(DEBUG, \"link_xon_rx: %lu\\n\", ns->link_xon_rx);\n+\tPMD_DRV_LOG(DEBUG, \"link_xoff_rx: %lu\\n\", ns->link_xoff_rx);\n \tfor (i = 0; i < 8; i++) {\n-\t\tprintf(\"priority_xon_rx[%d]: %lu\\n\",\n+\t\tPMD_DRV_LOG(DEBUG, \"priority_xon_rx[%d]: %lu\\n\",\n \t\t\t\ti, ns->priority_xon_rx[i]);\n-\t\tprintf(\"priority_xoff_rx[%d]: %lu\\n\",\n+\t\tPMD_DRV_LOG(DEBUG, \"priority_xoff_rx[%d]: %lu\\n\",\n \t\t\t\ti, ns->priority_xoff_rx[i]);\n \t}\n-\tprintf(\"link_xon_tx: %lu\\n\", ns->link_xon_tx);\n-\tprintf(\"link_xoff_tx: %lu\\n\", ns->link_xoff_tx);\n+\tPMD_DRV_LOG(DEBUG, \"link_xon_tx: %lu\\n\", ns->link_xon_tx);\n+\tPMD_DRV_LOG(DEBUG, \"link_xoff_tx: %lu\\n\", ns->link_xoff_tx);\n \tfor (i = 0; i < 8; i++) {\n-\t\tprintf(\"priority_xon_tx[%d]: %lu\\n\",\n+\t\tPMD_DRV_LOG(DEBUG, \"priority_xon_tx[%d]: %lu\\n\",\n \t\t\t\ti, ns->priority_xon_tx[i]);\n-\t\tprintf(\"priority_xoff_tx[%d]: %lu\\n\",\n+\t\tPMD_DRV_LOG(DEBUG, \"priority_xoff_tx[%d]: %lu\\n\",\n \t\t\t\ti, ns->priority_xoff_tx[i]);\n-\t\tprintf(\"priority_xon_2_xoff[%d]: %lu\\n\",\n+\t\tPMD_DRV_LOG(DEBUG, \"priority_xon_2_xoff[%d]: %lu\\n\",\n \t\t\t\ti, ns->priority_xon_2_xoff[i]);\n \t}\n-\tprintf(\"rx_size_64: %lu\\n\", ns->rx_size_64);\n-\tprintf(\"rx_size_127: %lu\\n\", ns->rx_size_127);\n-\tprintf(\"rx_size_255: %lu\\n\", ns->rx_size_255);\n-\tprintf(\"rx_size_511: %lu\\n\", ns->rx_size_511);\n-\tprintf(\"rx_size_1023: %lu\\n\", ns->rx_size_1023);\n-\tprintf(\"rx_size_1522: %lu\\n\", ns->rx_size_1522);\n-\tprintf(\"rx_size_big: %lu\\n\", ns->rx_size_big);\n-\tprintf(\"rx_undersize: %lu\\n\", ns->rx_undersize);\n-\tprintf(\"rx_fragments: %lu\\n\", ns->rx_fragments);\n-\tprintf(\"rx_oversize: %lu\\n\", ns->rx_oversize);\n-\tprintf(\"rx_jabber: %lu\\n\", ns->rx_jabber);\n-\tprintf(\"tx_size_64: %lu\\n\", ns->tx_size_64);\n-\tprintf(\"tx_size_127: %lu\\n\", ns->tx_size_127);\n-\tprintf(\"tx_size_255: %lu\\n\", ns->tx_size_255);\n-\tprintf(\"tx_size_511: %lu\\n\", ns->tx_size_511);\n-\tprintf(\"tx_size_1023: %lu\\n\", ns->tx_size_1023);\n-\tprintf(\"tx_size_1522: %lu\\n\", ns->tx_size_1522);\n-\tprintf(\"tx_size_big: %lu\\n\", ns->tx_size_big);\n-\tprintf(\"mac_short_packet_dropped: %lu\\n\",\n+\tPMD_DRV_LOG(DEBUG, \"rx_size_64: %lu\\n\", ns->rx_size_64);\n+\tPMD_DRV_LOG(DEBUG, \"rx_size_127: %lu\\n\", ns->rx_size_127);\n+\tPMD_DRV_LOG(DEBUG, \"rx_size_255: %lu\\n\", ns->rx_size_255);\n+\tPMD_DRV_LOG(DEBUG, \"rx_size_511: %lu\\n\", ns->rx_size_511);\n+\tPMD_DRV_LOG(DEBUG, \"rx_size_1023: %lu\\n\", ns->rx_size_1023);\n+\tPMD_DRV_LOG(DEBUG, \"rx_size_1522: %lu\\n\", ns->rx_size_1522);\n+\tPMD_DRV_LOG(DEBUG, \"rx_size_big: %lu\\n\", ns->rx_size_big);\n+\tPMD_DRV_LOG(DEBUG, \"rx_undersize: %lu\\n\", ns->rx_undersize);\n+\tPMD_DRV_LOG(DEBUG, \"rx_fragments: %lu\\n\", ns->rx_fragments);\n+\tPMD_DRV_LOG(DEBUG, \"rx_oversize: %lu\\n\", ns->rx_oversize);\n+\tPMD_DRV_LOG(DEBUG, \"rx_jabber: %lu\\n\", ns->rx_jabber);\n+\tPMD_DRV_LOG(DEBUG, \"tx_size_64: %lu\\n\", ns->tx_size_64);\n+\tPMD_DRV_LOG(DEBUG, \"tx_size_127: %lu\\n\", ns->tx_size_127);\n+\tPMD_DRV_LOG(DEBUG, \"tx_size_255: %lu\\n\", ns->tx_size_255);\n+\tPMD_DRV_LOG(DEBUG, \"tx_size_511: %lu\\n\", ns->tx_size_511);\n+\tPMD_DRV_LOG(DEBUG, \"tx_size_1023: %lu\\n\", ns->tx_size_1023);\n+\tPMD_DRV_LOG(DEBUG, \"tx_size_1522: %lu\\n\", ns->tx_size_1522);\n+\tPMD_DRV_LOG(DEBUG, \"tx_size_big: %lu\\n\", ns->tx_size_big);\n+\tPMD_DRV_LOG(DEBUG, \"mac_short_packet_dropped: %lu\\n\",\n \t\t\tns->mac_short_packet_dropped);\n-\tprintf(\"checksum_error: %lu\\n\", ns->checksum_error);\n-\tprintf(\"***************** PF stats end ********************\\n\");\n-#endif /* RTE_LIBRTE_I40E_DEBUG_DRIVER */\n+\tPMD_DRV_LOG(DEBUG, \"checksum_error: %lu\\n\",\n+\t\t ns->checksum_error);\n+\tPMD_DRV_LOG(DEBUG, \"***************** PF stats end ********************\\n\");\n }\n \n /* Reset the statistics */\ndiff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\nindex d8552ad..9c1ae94 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n@@ -1132,7 +1132,7 @@ static int\n rte_i40evf_pmd_init(const char *name __rte_unused,\n \t\t const char *params __rte_unused)\n {\n-\tDEBUGFUNC(\"rte_i40evf_pmd_init\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \trte_eth_driver_register(&rte_i40evf_pmd);\n \ndiff --git a/lib/librte_pmd_i40e/i40e_pf.c b/lib/librte_pmd_i40e/i40e_pf.c\nindex e8b154d..eec291f 100644\n--- a/lib/librte_pmd_i40e/i40e_pf.c\n+++ b/lib/librte_pmd_i40e/i40e_pf.c\n@@ -253,10 +253,8 @@ i40e_pf_host_send_msg_to_vf(struct i40e_pf_vf *vf,\n \tret = i40e_aq_send_msg_to_vf(hw, abs_vf_id, opcode, retval,\n \t\t\t\t\t\tmsg, msglen, NULL);\n \tif (ret) {\n-\t\tPMD_DRV_LOG(ERR, \"Fail to send message to VF, err %u\\n\",\n-\t\t\thw->aq.asq_last_status);\n-\t\tprintf(\"Fail to send message to VF, err %u\\n\",\n-\t\t\t\t\thw->aq.asq_last_status);\n+\t\tPMD_INIT_LOG(ERR, \"Fail to send message to VF, err %u\\n\",\n+\t\t\t hw->aq.asq_last_status);\n \t}\n \n \treturn ret;\ndiff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c\nindex f153844..6987200 100644\n--- a/lib/librte_pmd_i40e/i40e_rxtx.c\n+++ b/lib/librte_pmd_i40e/i40e_rxtx.c\n@@ -1788,50 +1788,50 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \ttx_free_thresh = (uint16_t)((tx_conf->tx_free_thresh) ?\n \t\ttx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH);\n \tif (tx_rs_thresh >= (nb_desc - 2)) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be less than the \"\n-\t\t\t\t\"number of TX descriptors minus 2. \"\n-\t\t\t\t\"(tx_rs_thresh=%u port=%d queue=%d)\\n\",\n-\t\t\t\t\t(unsigned int)tx_rs_thresh,\n-\t\t\t\t\t(int)dev->data->port_id,\n-\t\t\t\t\t\t(int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be less than the \"\n+\t\t\t \"number of TX descriptors minus 2. \"\n+\t\t\t \"(tx_rs_thresh=%u port=%d queue=%d)\\n\",\n+\t\t\t (unsigned int)tx_rs_thresh,\n+\t\t\t (int)dev->data->port_id,\n+\t\t\t (int)queue_idx);\n \t\treturn I40E_ERR_PARAM;\n \t}\n \tif (tx_free_thresh >= (nb_desc - 3)) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be less than the \"\n-\t\t\t\t\"tx_free_thresh must be less than the \"\n-\t\t\t\t\"number of TX descriptors minus 3. \"\n-\t\t\t\t\"(tx_free_thresh=%u port=%d queue=%d)\\n\",\n-\t\t\t\t\t(unsigned int)tx_free_thresh,\n-\t\t\t\t\t\t(int)dev->data->port_id,\n-\t\t\t\t\t\t\t(int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be less than the \"\n+\t\t\t \"tx_free_thresh must be less than the \"\n+\t\t\t \"number of TX descriptors minus 3. \"\n+\t\t\t \"(tx_free_thresh=%u port=%d queue=%d)\\n\",\n+\t\t\t (unsigned int)tx_free_thresh,\n+\t\t\t (int)dev->data->port_id,\n+\t\t\t (int)queue_idx);\n \t\treturn I40E_ERR_PARAM;\n \t}\n \tif (tx_rs_thresh > tx_free_thresh) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be less than or \"\n-\t\t\t\t\"equal to tx_free_thresh. (tx_free_thresh=%u\"\n-\t\t\t\t\" tx_rs_thresh=%u port=%d queue=%d)\\n\",\n-\t\t\t\t\t\t(unsigned int)tx_free_thresh,\n-\t\t\t\t\t\t(unsigned int)tx_rs_thresh,\n-\t\t\t\t\t\t(int)dev->data->port_id,\n-\t\t\t\t\t\t\t(int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be less than or \"\n+\t\t\t \"equal to tx_free_thresh. (tx_free_thresh=%u\"\n+\t\t\t \" tx_rs_thresh=%u port=%d queue=%d)\\n\",\n+\t\t\t (unsigned int)tx_free_thresh,\n+\t\t\t (unsigned int)tx_rs_thresh,\n+\t\t\t (int)dev->data->port_id,\n+\t\t\t (int)queue_idx);\n \t\treturn I40E_ERR_PARAM;\n \t}\n \tif ((nb_desc % tx_rs_thresh) != 0) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be a divisor of the \"\n-\t\t\t\t\"number of TX descriptors. (tx_rs_thresh=%u\"\n-\t\t\t\t\t\t\" port=%d queue=%d)\\n\",\n-\t\t\t\t\t\t(unsigned int)tx_rs_thresh,\n-\t\t\t\t\t\t(int)dev->data->port_id,\n-\t\t\t\t\t\t\t(int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be a divisor of the \"\n+\t\t\t \"number of TX descriptors. (tx_rs_thresh=%u\"\n+\t\t\t \" port=%d queue=%d)\\n\",\n+\t\t\t (unsigned int)tx_rs_thresh,\n+\t\t\t (int)dev->data->port_id,\n+\t\t\t (int)queue_idx);\n \t\treturn I40E_ERR_PARAM;\n \t}\n \tif ((tx_rs_thresh > 1) && (tx_conf->tx_thresh.wthresh != 0)) {\n-\t\tRTE_LOG(ERR, PMD, \"TX WTHRESH must be set to 0 if \"\n-\t\t\t\t\"tx_rs_thresh is greater than 1. \"\n-\t\t\t\t\"(tx_rs_thresh=%u port=%d queue=%d)\\n\",\n-\t\t\t\t\t(unsigned int)tx_rs_thresh,\n-\t\t\t\t\t(int)dev->data->port_id,\n-\t\t\t\t\t\t(int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"TX WTHRESH must be set to 0 if \"\n+\t\t\t \"tx_rs_thresh is greater than 1. \"\n+\t\t\t \"(tx_rs_thresh=%u port=%d queue=%d)\\n\",\n+\t\t\t (unsigned int)tx_rs_thresh,\n+\t\t\t (int)dev->data->port_id,\n+\t\t\t (int)queue_idx);\n \t\treturn I40E_ERR_PARAM;\n \t}\n \n", "prefixes": [ "dpdk-dev", "v2", "07/17" ] }