Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27922/?format=api
{ "id": 27922, "url": "https://patches.dpdk.org/api/patches/27922/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/3312a5ecfba777436f60dbc6476851abb0c6f9d8.1503651392.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3312a5ecfba777436f60dbc6476851abb0c6f9d8.1503651392.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3312a5ecfba777436f60dbc6476851abb0c6f9d8.1503651392.git.gaetan.rivet@6wind.com", "date": "2017-08-25T09:04:23", "name": "[dpdk-dev,01/13] eal: expose rte_eal_using_phys_addrs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c8d811247789832527653b966a41514b7f662bfa", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/3312a5ecfba777436f60dbc6476851abb0c6f9d8.1503651392.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/27922/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/27922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 82F957D62;\n\tFri, 25 Aug 2017 11:04:53 +0200 (CEST)", "from mail-wm0-f46.google.com (mail-wm0-f46.google.com\n\t[74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 817787D1C\n\tfor <dev@dpdk.org>; Fri, 25 Aug 2017 11:04:52 +0200 (CEST)", "by mail-wm0-f46.google.com with SMTP id b189so6983507wmd.0\n\tfor <dev@dpdk.org>; Fri, 25 Aug 2017 02:04:52 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tq141sm782350wmb.11.2017.08.25.02.04.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 25 Aug 2017 02:04:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=sBBJLN3IaWBFwmvswcuQESiPet0D4or84wJ2+TNvoOs=;\n\tb=uarTWM+rtiNKlYgomX04OMwQXEUajP0QY2Buzn12F2TGVJ0LEfUwDGC9sIuHqtyw/3\n\tz8SYVt4P2daI18eWsIMg4rU4NRATFFs4SvWWxznmqx72ItTLp2wNVbz4g2DMQm6gOfxG\n\tvmxeAIUkmJFTgWMRnbpYBxlvCuUUDVNaodXcvmohk8Bc2uTigTh971iNV59bqjwgP1ZQ\n\tFIPXBjcxN0NT/mS98gMqfGyBthLRDFBiCnYTKFv+YEf2JBSdijJzDrCCQmU6X+Qh6F4i\n\twC2eGw1CeDXQvgp1UGCU4dm3WtBr0t8ophg3DtmuuWNISUIdKV+HhvJUiWMy6YjLf4X/\n\trDlA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=sBBJLN3IaWBFwmvswcuQESiPet0D4or84wJ2+TNvoOs=;\n\tb=Cng8dWPWnTzPC34ztSOtj2pMVlMjQM6tC9MTQ3aLY6BAZjDeBGyfMlgL76iSb0gQCG\n\tKwhVuWPn+MVbw9961fCzf6vcEva6TT0ni2Xvk42S35aDrxnWALP1iSmfB2/hpY7uTPzM\n\tAT0YmNeaN3Z25c5YZzbkVYA1xJ2X8Dz5TuK8EZiqUIUpHSXAQBpTNy50VIGr5My1N/S7\n\tqDMNoUFpMSvA4tYWQOnCfyBppDLtOqvRsMmw3c/e3os/OGBlk3OB/vMStDNQp0j4wMPA\n\t+RmGPfRedy26Nt0FldcD/NaGzIpquCfYzO5h6OA2LqfHVjl155J3h6xol6eBUpBH2tV/\n\tJYXw==", "X-Gm-Message-State": "AHYfb5hytyh3ld19qURjkuerQoVfYx9WgNe5k61uOFoE2fuXlhP7zqYw\n\tPNlecrC14Ah+aR35TKg=", "X-Received": "by 10.28.172.4 with SMTP id v4mr790758wme.72.1503651891597;\n\tFri, 25 Aug 2017 02:04:51 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Fri, 25 Aug 2017 11:04:23 +0200", "Message-Id": "<3312a5ecfba777436f60dbc6476851abb0c6f9d8.1503651392.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1503651392.git.gaetan.rivet@6wind.com>", "<cover.1503651392.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1503651392.git.gaetan.rivet@6wind.com>", "<cover.1503651392.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH 01/13] eal: expose rte_eal_using_phys_addrs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This function was previously private to the EAL layer.\nOther subsystems requires it, such as the PCI bus.\n\nThis function is only exposed for linuxapps.\n\nIn order not to force other components to include stdbool, which is\nincompatible with several NIC drivers, the return type has\nbeen changed from bool to int.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/common/eal_private.h | 11 -----\n lib/librte_eal/linuxapp/eal/Makefile | 2 +\n lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +-\n lib/librte_eal/linuxapp/eal/eal_pci.c | 1 +\n lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +\n lib/librte_eal/linuxapp/eal/rte_memory_linux.h | 64 +++++++++++++++++++++++++\n 6 files changed, 70 insertions(+), 12 deletions(-)\n create mode 100644 lib/librte_eal/linuxapp/eal/rte_memory_linux.h", "diff": "diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 597d82e..10a7078 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -333,17 +333,6 @@ int rte_eal_hugepage_init(void);\n int rte_eal_hugepage_attach(void);\n \n /**\n- * Returns true if the system is able to obtain\n- * physical addresses. Return false if using DMA\n- * addresses through an IOMMU.\n- *\n- * Drivers based on uio will not load unless physical\n- * addresses are obtainable. It is only possible to get\n- * physical addresses when running as a privileged user.\n- */\n-bool rte_eal_using_phys_addrs(void);\n-\n-/**\n * Find a bus capable of identifying a device.\n *\n * @param str\ndiff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile\nindex 90bca4d..ad7e34a 100644\n--- a/lib/librte_eal/linuxapp/eal/Makefile\n+++ b/lib/librte_eal/linuxapp/eal/Makefile\n@@ -135,4 +135,6 @@ INC := rte_interrupts.h rte_kni_common.h rte_dom0_common.h\n SYMLINK-$(CONFIG_RTE_EXEC_ENV_LINUXAPP)-include/exec-env := \\\n \t$(addprefix include/exec-env/,$(INC))\n \n+SYMLINK-$(CONFIG_RTE_EXEC_ENV_LINUXAPP)-include += rte_memory_linux.h\n+\n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex 5279128..6639670 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -72,6 +72,7 @@\n #include \"eal_internal_cfg.h\"\n #include \"eal_filesystem.h\"\n #include \"eal_hugepages.h\"\n+#include \"rte_memory_linux.h\"\n \n #define PFN_MASK_SIZE\t8\n \n@@ -1542,7 +1543,7 @@ rte_eal_hugepage_attach(void)\n \treturn -1;\n }\n \n-bool\n+int\n rte_eal_using_phys_addrs(void)\n {\n \treturn phys_addrs_available;\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c\nindex 8951ce7..8f658d6 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c\n@@ -45,6 +45,7 @@\n #include \"eal_filesystem.h\"\n #include \"eal_private.h\"\n #include \"eal_pci_init.h\"\n+#include \"rte_memory_linux.h\"\n \n /**\n * @file\ndiff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\nindex 3a8f154..5cfd934 100644\n--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n@@ -206,6 +206,7 @@ DPDK_17.08 {\n \trte_bus_find_by_device;\n \trte_bus_find_by_name;\n \trte_log_get_level;\n+\trte_eal_using_phys_addrs;\n \n } DPDK_17.05;\n \ndiff --git a/lib/librte_eal/linuxapp/eal/rte_memory_linux.h b/lib/librte_eal/linuxapp/eal/rte_memory_linux.h\nnew file mode 100644\nindex 0000000..0400711\n--- /dev/null\n+++ b/lib/librte_eal/linuxapp/eal/rte_memory_linux.h\n@@ -0,0 +1,64 @@\n+/*-\n+ * BSD LICENSE\n+ *\n+ * Copyright(c) 2017 6WIND S.A. All rights reserved.\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions\n+ * are met:\n+ *\n+ * * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ * * Redistributions in binary form must reproduce the above copyright\n+ * notice, this list of conditions and the following disclaimer in\n+ * the documentation and/or other materials provided with the\n+ * distribution.\n+ * * Neither the name of 6WIND nor the names of its\n+ * contributors may be used to endorse or promote products derived\n+ * from this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#ifndef _RTE_MEMORY_LINUX_H_\n+#define _RTE_MEMORY_LINUX_H_\n+\n+/**\n+ * @file\n+ *\n+ * Memory-related Linux-specific RTE API.\n+ */\n+\n+#include <rte_memory.h>\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+/**\n+ * Drivers based on uio will not load unless physical\n+ * addresses are obtainable. It is only possible to get\n+ * physical addresses when running as a privileged user.\n+ *\n+ * @return\n+ * 1 if the system is able to obtain physical addresses.\n+ * 0 if using DMA addresses through an IOMMU.\n+ */\n+int rte_eal_using_phys_addrs(void);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_MEMORY_LINUX_H_ */\n", "prefixes": [ "dpdk-dev", "01/13" ] }