Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 27735,
    "url": "https://patches.dpdk.org/api/patches/27735/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170823025555.19022-1-dharton@cisco.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170823025555.19022-1-dharton@cisco.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170823025555.19022-1-dharton@cisco.com",
    "date": "2017-08-23T02:55:55",
    "name": "[dpdk-dev,v2,1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "658602c29dc90356b013fa59e17098270ebfd34a",
    "submitter": {
        "id": 252,
        "url": "https://patches.dpdk.org/api/people/252/?format=api",
        "name": "David Harton",
        "email": "dharton@cisco.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170823025555.19022-1-dharton@cisco.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/27735/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/27735/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0D97A2B91;\n\tWed, 23 Aug 2017 04:56:00 +0200 (CEST)",
            "from alln-iport-3.cisco.com (alln-iport-3.cisco.com\n\t[173.37.142.90]) by dpdk.org (Postfix) with ESMTP id D601D1E2F\n\tfor <dev@dpdk.org>; Wed, 23 Aug 2017 04:55:58 +0200 (CEST)",
            "from alln-core-2.cisco.com ([173.36.13.135])\n\tby alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t23 Aug 2017 02:55:57 +0000",
            "from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com\n\t[172.18.5.114])\n\tby alln-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v7N2tvsn015309;\n\tWed, 23 Aug 2017 02:55:57 GMT",
            "by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087)\n\tid 860C6591; Tue, 22 Aug 2017 22:55:57 -0400 (EDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1014; q=dns/txt; s=iport;\n\tt=1503456959; x=1504666559;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=1fQt8vbmX5UmEtiT7dGV8uSIOuSCfJHjHNJCzpzZSmI=;\n\tb=iPwUhVXckWz9ePsCcX2e5TIPX1Nu8fPJBufaEYBEzPdP2p7A4N+MXboV\n\tnbBdGgBp6kH11x/QfqQlj58IH30hLWJJWl4lHim+hLXRQ8VHuh5PCYHXu\n\tiVzo1i2aYwWdm6iuBtw9wq03fX1ObQVjeI/VHeMCBe0ukWhWgXlO+9xkZ 8=;",
        "X-IronPort-AV": "E=Sophos;i=\"5.41,415,1498521600\"; d=\"scan'208\";a=\"474901141\"",
        "From": "David Harton <dharton@cisco.com>",
        "To": "thomas@monjalon.net",
        "Cc": "dev@dpdk.org, David Harton <dharton@cisco.com>",
        "Date": "Tue, 22 Aug 2017 22:55:55 -0400",
        "Message-Id": "<20170823025555.19022-1-dharton@cisco.com>",
        "X-Mailer": "git-send-email 2.10.3.dirty",
        "In-Reply-To": "<20170823011937.37579-1-dharton@cisco.com>",
        "References": "<20170823011937.37579-1-dharton@cisco.com>",
        "Subject": "[dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by\n\trte_eth_stats_get",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "rte_eth_stats_get() unconditonally would set rx_nombuf\neven if the device was setting the value.  A check has\nbeen added in rte_eth_stats_get() to leave the device\nvalue in-tact when non-zero.\n\nSigned-off-by: David Harton <dharton@cisco.com>\n---\n\nv2: Fixed braces complaint required by other coding standards.\n\n lib/librte_ether/rte_ethdev.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 0597641..0a1d3b8 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1336,8 +1336,11 @@ struct rte_eth_dev *\n \tmemset(stats, 0, sizeof(*stats));\n \n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->stats_get, -ENOTSUP);\n-\tstats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;\n \t(*dev->dev_ops->stats_get)(dev, stats);\n+\t/* only set rx_nombuf if not set by the device */\n+\tif (!stats->rx_nombuf)\n+\t\tstats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;\n+\n \treturn 0;\n }\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "1/2"
    ]
}