Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27697/?format=api
{ "id": 27697, "url": "https://patches.dpdk.org/api/patches/27697/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1503320296-51122-15-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1503320296-51122-15-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1503320296-51122-15-git-send-email-harry.van.haaren@intel.com", "date": "2017-08-21T12:58:15", "name": "[dpdk-dev,v2,14/15] service: clarify documentation for register", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a95ed33dbc87e2d13bf026d56d58daf4deb78613", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1503320296-51122-15-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/27697/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/27697/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 55C439105;\n\tMon, 21 Aug 2017 14:58:50 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 6A9C07D3A\n\tfor <dev@dpdk.org>; Mon, 21 Aug 2017 14:58:41 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 21 Aug 2017 05:58:41 -0700", "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Aug 2017 05:58:40 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.41,409,1498546800\"; d=\"scan'208\";\n\ta=\"1208383381\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "Harry van Haaren <harry.van.haaren@intel.com>", "Date": "Mon, 21 Aug 2017 13:58:15 +0100", "Message-Id": "<1503320296-51122-15-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503320296-51122-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1502800360-15782-1-git-send-email-harry.van.haaren@intel.com>\n\t<1503320296-51122-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 14/15] service: clarify documentation for\n\tregister", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit adds a section to the service register function\nto make it clear that registering a service, must not configure\nservice-cores (eg: adding lcores or changing mappings).\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n lib/librte_eal/common/include/rte_service_component.h | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_service_component.h b/lib/librte_eal/common/include/rte_service_component.h\nindex 5e4573b..ac965cb 100644\n--- a/lib/librte_eal/common/include/rte_service_component.h\n+++ b/lib/librte_eal/common/include/rte_service_component.h\n@@ -85,8 +85,13 @@ struct rte_service_spec {\n *\n * For example the eventdev SW PMD requires CPU cycles to perform its\n * scheduling. This can be achieved by registering it as a service, and the\n- * application can then assign CPU resources to it using\n- * *rte_service_set_coremask*.\n+ * application can then assign CPU resources to that service.\n+ *\n+ * Note that when a service component registers itself, it is not permitted to\n+ * add or remove service-core threads, or modify lcore-to-service mappings. The\n+ * only API that may be called by the service-component is\n+ * *rte_service_component_runstate_set*, which indicates that the service\n+ * component is ready to be executed.\n *\n * @param spec The specification of the service to register\n * @param[out] service_id A pointer to a uint32_t, which will be filled in\n", "prefixes": [ "dpdk-dev", "v2", "14/15" ] }