Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 27693,
    "url": "https://patches.dpdk.org/api/patches/27693/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1503320296-51122-11-git-send-email-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1503320296-51122-11-git-send-email-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1503320296-51122-11-git-send-email-harry.van.haaren@intel.com",
    "date": "2017-08-21T12:58:11",
    "name": "[dpdk-dev,v2,10/15] service: fix return values of functions to 0 or 1",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6f4a02659cf763e6ee5c8a7ed189c8a8ac1fe571",
    "submitter": {
        "id": 317,
        "url": "https://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1503320296-51122-11-git-send-email-harry.van.haaren@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/27693/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/27693/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C66B18C7E;\n\tMon, 21 Aug 2017 14:58:44 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 070C07D0F\n\tfor <dev@dpdk.org>; Mon, 21 Aug 2017 14:58:36 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 21 Aug 2017 05:58:36 -0700",
            "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Aug 2017 05:58:35 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.41,409,1498546800\"; d=\"scan'208\";\n\ta=\"1208383330\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Harry van Haaren <harry.van.haaren@intel.com>",
        "Date": "Mon, 21 Aug 2017 13:58:11 +0100",
        "Message-Id": "<1503320296-51122-11-git-send-email-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1503320296-51122-1-git-send-email-harry.van.haaren@intel.com>",
        "References": "<1502800360-15782-1-git-send-email-harry.van.haaren@intel.com>\n\t<1503320296-51122-1-git-send-email-harry.van.haaren@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 10/15] service: fix return values of functions\n\tto 0 or 1",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Previously to this commit, the return value of the following\nfunctions was the mask value, instead of a neat 0 or 1.\n\nThis commit fixes this using the \"!!\" trick, to force the\nnumber to 1 instead of the bitmask value itself, bringing\nthe return value in line with the function documentation.\n\nFixes: 21698354c832 (\"service: introduce service cores concept\")\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n lib/librte_eal/common/rte_service.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex a5fbcf9..4034130 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -163,7 +163,7 @@ service_stats_enabled(struct rte_service_spec_impl *impl)\n static inline int\n service_mt_safe(struct rte_service_spec_impl *s)\n {\n-\treturn s->spec.capabilities & RTE_SERVICE_CAP_MT_SAFE;\n+\treturn !!(s->spec.capabilities & RTE_SERVICE_CAP_MT_SAFE);\n }\n \n int32_t rte_service_set_stats_enable(uint32_t id, int32_t enabled)\n@@ -215,7 +215,7 @@ rte_service_probe_capability(uint32_t id, uint32_t capability)\n {\n \tstruct rte_service_spec_impl *s;\n \tSERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);\n-\treturn s->spec.capabilities & capability;\n+\treturn !!(s->spec.capabilities & capability);\n }\n \n int32_t\n@@ -463,7 +463,7 @@ service_update(struct rte_service_spec *service, uint32_t lcore,\n \t}\n \n \tif (enabled)\n-\t\t*enabled = (lcore_states[lcore].service_mask & (sid_mask));\n+\t\t*enabled = !!(lcore_states[lcore].service_mask & (sid_mask));\n \n \trte_smp_wmb();\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "10/15"
    ]
}