Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27689/?format=api
{ "id": 27689, "url": "https://patches.dpdk.org/api/patches/27689/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1503320296-51122-7-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1503320296-51122-7-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1503320296-51122-7-git-send-email-harry.van.haaren@intel.com", "date": "2017-08-21T12:58:07", "name": "[dpdk-dev,v2,06/15] service: rework unregister api to use integers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1f6c067bee7b306cf3f4e8beab00f8cb10036582", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1503320296-51122-7-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/27689/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/27689/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7947E7D6B;\n\tMon, 21 Aug 2017 14:58:38 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id B34EC7D42\n\tfor <dev@dpdk.org>; Mon, 21 Aug 2017 14:58:32 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 21 Aug 2017 05:58:32 -0700", "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Aug 2017 05:58:31 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.41,409,1498546800\"; d=\"scan'208\";\n\ta=\"1208383294\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "Harry van Haaren <harry.van.haaren@intel.com>", "Date": "Mon, 21 Aug 2017 13:58:07 +0100", "Message-Id": "<1503320296-51122-7-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503320296-51122-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1502800360-15782-1-git-send-email-harry.van.haaren@intel.com>\n\t<1503320296-51122-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 06/15] service: rework unregister api to use\n\tintegers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit reworks the unregister API to accept an integer.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nv2:\n- Renamed unregister to rte_service_component_unregister\n for consistency in APIs for components.\n---\n lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 +-\n .../common/include/rte_service_component.h | 4 ++--\n lib/librte_eal/common/rte_service.c | 25 ++++++----------------\n lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 +-\n test/test/test_service_cores.c | 10 +++------\n 5 files changed, 13 insertions(+), 30 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\nindex b336f54..507a38e 100644\n--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n@@ -213,6 +213,7 @@ EXPERIMENTAL {\n \trte_eal_hotplug_add;\n \trte_eal_hotplug_remove;\n \trte_service_component_register;\n+\trte_service_component_unregister;\n \trte_service_dump;\n \trte_service_get_by_id;\n \trte_service_get_by_name;\n@@ -232,6 +233,5 @@ EXPERIMENTAL {\n \trte_service_runstate_set;\n \trte_service_set_stats_enable;\n \trte_service_start_with_defaults;\n-\trte_service_unregister;\n \n } DPDK_17.08;\ndiff --git a/lib/librte_eal/common/include/rte_service_component.h b/lib/librte_eal/common/include/rte_service_component.h\nindex 6ef3ee4..af632c6 100644\n--- a/lib/librte_eal/common/include/rte_service_component.h\n+++ b/lib/librte_eal/common/include/rte_service_component.h\n@@ -103,7 +103,7 @@ int32_t rte_service_component_register(const struct rte_service_spec *spec,\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice\n *\n- * Unregister a service.\n+ * Unregister a service component.\n *\n * The service being removed must be stopped before calling this function.\n *\n@@ -111,7 +111,7 @@ int32_t rte_service_component_register(const struct rte_service_spec *spec,\n * @retval -EBUSY The service is currently running, stop the service before\n * calling unregister. No action has been taken.\n */\n-int32_t rte_service_unregister(struct rte_service_spec *service);\n+int32_t rte_service_component_unregister(uint32_t id);\n \n /**\n * @warning\ndiff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex ac1c90c..adcd860 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -260,35 +260,22 @@ rte_service_component_register(const struct rte_service_spec *spec,\n }\n \n int32_t\n-rte_service_unregister(struct rte_service_spec *spec)\n+rte_service_component_unregister(uint32_t id)\n {\n-\tstruct rte_service_spec_impl *s = NULL;\n-\tstruct rte_service_spec_impl *spec_impl =\n-\t\t(struct rte_service_spec_impl *)spec;\n-\n \tuint32_t i;\n-\tuint32_t service_id;\n-\tfor (i = 0; i < RTE_SERVICE_NUM_MAX; i++) {\n-\t\tif (&rte_services[i] == spec_impl) {\n-\t\t\ts = spec_impl;\n-\t\t\tservice_id = i;\n-\t\t\tbreak;\n-\t\t}\n-\t}\n-\n-\tif (!s)\n-\t\treturn -EINVAL;\n+\tstruct rte_service_spec_impl *s;\n+\tSERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);\n \n \trte_service_count--;\n \trte_smp_wmb();\n \n \ts->internal_flags &= ~(SERVICE_F_REGISTERED);\n \n+\t/* clear the run-bit in all cores */\n \tfor (i = 0; i < RTE_MAX_LCORE; i++)\n-\t\tlcore_states[i].service_mask &= ~(UINT64_C(1) << service_id);\n+\t\tlcore_states[i].service_mask &= ~(UINT64_C(1) << id);\n \n-\tmemset(&rte_services[service_id], 0,\n-\t\t\tsizeof(struct rte_service_spec_impl));\n+\tmemset(&rte_services[id], 0, sizeof(struct rte_service_spec_impl));\n \n \treturn 0;\n }\ndiff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\nindex b2b2235..a7431da 100644\n--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n@@ -218,6 +218,7 @@ EXPERIMENTAL {\n \trte_eal_hotplug_add;\n \trte_eal_hotplug_remove;\n \trte_service_component_register;\n+\trte_service_component_unregister;\n \trte_service_dump;\n \trte_service_get_by_id;\n \trte_service_get_by_name;\n@@ -237,6 +238,5 @@ EXPERIMENTAL {\n \trte_service_runstate_set;\n \trte_service_set_stats_enable;\n \trte_service_start_with_defaults;\n-\trte_service_unregister;\n \n } DPDK_17.08;\ndiff --git a/test/test/test_service_cores.c b/test/test/test_service_cores.c\nindex d52fe49..e650b20 100644\n--- a/test/test/test_service_cores.c\n+++ b/test/test/test_service_cores.c\n@@ -131,17 +131,13 @@ static int\n unregister_all(void)\n {\n \tuint32_t i;\n-\tstruct rte_service_spec *dead = (struct rte_service_spec *)0xdead;\n \n-\tTEST_ASSERT_EQUAL(-EINVAL, rte_service_unregister(0),\n-\t\t\t\"Unregistered NULL pointer\");\n-\tTEST_ASSERT_EQUAL(-EINVAL, rte_service_unregister(dead),\n-\t\t\t\"Unregistered invalid pointer\");\n+\tTEST_ASSERT_EQUAL(-EINVAL, rte_service_component_unregister(1000),\n+\t\t\t\"Unregistered invalid service id\");\n \n \tuint32_t c = rte_service_get_count();\n \tfor (i = 0; i < c; i++) {\n-\t\tstruct rte_service_spec *s = rte_service_get_by_id(i);\n-\t\tTEST_ASSERT_EQUAL(0, rte_service_unregister(s),\n+\t\tTEST_ASSERT_EQUAL(0, rte_service_component_unregister(i),\n \t\t\t\t\"Error unregistering a valid service\");\n \t}\n \n", "prefixes": [ "dpdk-dev", "v2", "06/15" ] }