Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27405/?format=api
{ "id": 27405, "url": "https://patches.dpdk.org/api/patches/27405/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/31be1706d1613adecd43328272f1b6f556c6110f.1501763608.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<31be1706d1613adecd43328272f1b6f556c6110f.1501763608.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/31be1706d1613adecd43328272f1b6f556c6110f.1501763608.git.gaetan.rivet@6wind.com", "date": "2017-08-03T12:34:19", "name": "[dpdk-dev] eal: fix possible segfault in hotplug add", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "deb04cb986d4ca6705b5e91df7cf7e8cab683c9c", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/31be1706d1613adecd43328272f1b6f556c6110f.1501763608.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/27405/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/27405/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CA537325D;\n\tThu, 3 Aug 2017 14:34:35 +0200 (CEST)", "from mail-wr0-f179.google.com (mail-wr0-f179.google.com\n\t[209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 0B0EC2C55\n\tfor <dev@dpdk.org>; Thu, 3 Aug 2017 14:34:34 +0200 (CEST)", "by mail-wr0-f179.google.com with SMTP id 33so5152013wrz.4\n\tfor <dev@dpdk.org>; Thu, 03 Aug 2017 05:34:34 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tc16sm1621015wmh.41.2017.08.03.05.34.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 03 Aug 2017 05:34:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=iZTKTs1cnUZTBPGb3QSIu7YVq4nLc9XLdej3BCk7VKQ=;\n\tb=OZS4vWRBlW5PTf6ORQOjQKTNtdoOE01PFbSQ1mi+C892UpSpFJx3y6OS42HaSl/jL9\n\t+ywbDLbxs0Dkel4S9Y0N3kTZLM+sXBYGsGF9x2Zd9W6GcnbFJnMKLpNGwS6GgdrcO817\n\t9h3B0HOczC4SfRZr/Cx88YAovT6vplbtX1JeCTxwOvfO1UzSt0zVcnDPnXMv5yPFTtk+\n\tgoVj40u8Wv5Ab91ToHCdvJbYTG/zZvbM0MW6YJNL8CcKtmh1QhtLGtyXbSvczZQPlCO/\n\tppknzmznW4S9FSeLSlZpwJvpSPd1nrgCH8ozUjmw+94w/23l6SX4CR/PFgmT9HZLhIqQ\n\tUBNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=iZTKTs1cnUZTBPGb3QSIu7YVq4nLc9XLdej3BCk7VKQ=;\n\tb=eeGYMkbsP2SV12NhHn5sUL7GyVCyGONothPNBhOYNlV/ShU27WM2UVfgVjFi7avOZ/\n\tei0zFER87y7PZNwBIv1ZCsJ9Aon2qoKyilX2NUUPS350mSydp4lRnpOUGtD0InK1pDow\n\tL1HiErjgj4OPCNPch4l2QXWitwgIRZnRdpC/ZadSZyooezXsOivY9icw5tT9r4AFQ7lE\n\tpsF4bZwu9DCBxswTNeu2etlBDmeaGfpxEWBcZScwWpQY4TJxPOeWMEiILNjq21B0jKy4\n\tfZa2Ce+xSQi8byzxXJPX+tT8trXp+S5GHzYbNeYLXU1B9H1s5EJRwje0BDmzcLhhcZWf\n\tKnlA==", "X-Gm-Message-State": "AIVw112W6gNyWNsVb8R5+B+whkD+6aEIGUDQ2z7tHnbDuvIErAniqUak\n\tIKj2tAAuoVlTnupvjR8=", "X-Received": "by 10.223.170.2 with SMTP id p2mr1435876wrd.22.1501763674297;\n\tThu, 03 Aug 2017 05:34:34 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 3 Aug 2017 14:34:19 +0200", "Message-Id": "<31be1706d1613adecd43328272f1b6f556c6110f.1501763608.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "Subject": "[dpdk-dev] [PATCH] eal: fix possible segfault in hotplug add", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If devargs is NULL, building the full_dev_name will segfault\nwhen using strlen on it.\n\nCoverity issue: 158630\nFixes: 7e8b26650146 (\"eal: fix hotplug add / remove\")\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/common/eal_common_dev.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex f98302d..d19232d 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -133,16 +133,13 @@ full_dev_name(const char *bus, const char *dev, const char *args)\n \tchar *name;\n \tsize_t len;\n \n-\tlen = strlen(bus) + 1 +\n-\t strlen(dev) + 1 +\n-\t strlen(args) + 1;\n+\tlen = snprintf(NULL, 0, \"%s:%s,%s\", bus, dev, args);\n \tname = calloc(1, len);\n \tif (name == NULL) {\n \t\tRTE_LOG(ERR, EAL, \"Could not allocate full device name\\n\");\n \t\treturn NULL;\n \t}\n-\tsnprintf(name, len, \"%s:%s,%s\", bus, dev,\n-\t\t args ? args : \"\");\n+\tsnprintf(name, len, \"%s:%s,%s\", bus, dev, args);\n \treturn name;\n }\n \n", "prefixes": [ "dpdk-dev" ] }