List comments

GET /api/patches/271/comments/?order=-date
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 935,
        "web_url": "https://patches.dpdk.org/comment/935/",
        "msgid": "<1411478290-28807-1-git-send-email-declan.doherty@intel.com>",
        "date": "2014-09-23T13:18:05",
        "subject": "[dpdk-dev] [PATCH v3 0/5] link bonding",
        "submitter": {
            "id": 11,
            "url": "https://patches.dpdk.org/api/people/11/",
            "name": "Doherty, Declan",
            "email": "declan.doherty@intel.com"
        },
        "content": "This patch set contains a typo fix for the bond free mbufs patch aswell\nas updates to the test app patch to rebase for changes in the mbuf patches\n. It also contains a patch to add support for slave devices which don't\nsupport link status interrupts and also a patch to tidy up the link bonding\nunit test so that all tests use the new test macros.\n\nDeclan Doherty (5):\n  bond: free mbufs if transmission fails in bonding tx_burst functions\n  test app: adding support for generating variable sized packet\n  testpmd: adding parameter to reconfig method to set socket_id when\n    adding new port to portlist\n  bond: lsc polling support\n  bond: unit test test macro refactor\n\n app/test-pmd/cmdline.c                     |    2 +-\n app/test-pmd/testpmd.c                     |    3 +-\n app/test-pmd/testpmd.h                     |    2 +-\n app/test/packet_burst_generator.c          |   25 +-\n app/test/packet_burst_generator.h          |    6 +-\n app/test/test.h                            |    7 +-\n app/test/test_link_bonding.c               | 3245 ++++++++++++++--------------\n app/test/virtual_pmd.c                     |   97 +-\n app/test/virtual_pmd.h                     |   53 +-\n lib/librte_pmd_bond/rte_eth_bond.h         |   80 +\n lib/librte_pmd_bond/rte_eth_bond_api.c     |  309 ++-\n lib/librte_pmd_bond/rte_eth_bond_args.c    |   30 +-\n lib/librte_pmd_bond/rte_eth_bond_pmd.c     |  470 +++-\n lib/librte_pmd_bond/rte_eth_bond_private.h |   71 +-\n 14 files changed, 2450 insertions(+), 1950 deletions(-)",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "X-ExtLoop1": "1",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-Mailer": "git-send-email 1.7.4.1",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F1961B34A;\n\tTue, 23 Sep 2014 15:16:24 +0200 (CEST)",
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 1BCC3B349\n\tfor <dev@dpdk.org>; Tue, 23 Sep 2014 15:16:23 +0200 (CEST)",
                "from azsmga001.ch.intel.com ([10.2.17.19])\n\tby fmsmga101.fm.intel.com with ESMTP; 23 Sep 2014 06:18:19 -0700",
                "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby azsmga001.ch.intel.com with ESMTP; 23 Sep 2014 06:18:18 -0700",
                "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts8NDIHV1001200; Tue, 23 Sep 2014 14:18:17 +0100",
                "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s8NDIGiJ031243;\n\tTue, 23 Sep 2014 14:18:16 +0100",
                "(from dwdohert@localhost)\n\tby sivswdev02.ir.intel.com with  id s8NDIGIp031235;\n\tTue, 23 Sep 2014 14:18:16 +0100"
            ],
            "References": "<1409560289-29558-5-git-send-email-declan.doherty@intel.com>",
            "Delivered-To": "patchwork@dpdk.org",
            "X-BeenThere": "dev@dpdk.org",
            "Message-Id": "<1411478290-28807-1-git-send-email-declan.doherty@intel.com>",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,580,1406617200\"; d=\"scan'208\";a=\"479438621\"",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Precedence": "list",
            "From": "Declan Doherty <declan.doherty@intel.com>",
            "X-Original-To": "patchwork@dpdk.org",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<1409560289-29558-5-git-send-email-declan.doherty@intel.com>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "dev@dpdk.org",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Date": "Tue, 23 Sep 2014 14:18:05 +0100",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Subject": "[dpdk-dev] [PATCH v3 0/5] link bonding"
        }
    },
    {
        "id": 619,
        "web_url": "https://patches.dpdk.org/comment/619/",
        "msgid": "<2319059.S7dZfdPe5P@xps13>",
        "date": "2014-09-02T09:31:52",
        "subject": "Re: [dpdk-dev] [PATCH v2 4/6] bond: free mbufs if transmission\n\tfails in bonding tx_burst functions",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "Hi Declan,\n\n2014-09-02 09:22, Doherty, Declan:\n> I've just noticed that I inserted an extra character into the patch when I was annotating this\n> patch which will cause this a fail compilation.\n> \n> > +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -s\n> > +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT);\n> \n> should have been \n> > +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -\n> > +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT);\n> \n> Thomas, do you want me to submit a V3 of this?\n\nI'd prefer to have some comments first.\nAnyone to review this patchset?",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "Date": "Tue, 02 Sep 2014 11:31:52 +0200",
            "In-Reply-To": "<345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com>",
            "Received": [
                "from mail-we0-f174.google.com (mail-we0-f174.google.com\n\t[74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 71A70B389\n\tfor <dev@dpdk.org>; Tue,  2 Sep 2014 11:27:29 +0200 (CEST)",
                "by mail-we0-f174.google.com with SMTP id u57so6606701wes.5\n\tfor <dev@dpdk.org>; Tue, 02 Sep 2014 02:32:00 -0700 (PDT)",
                "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tz5sm32475087wib.20.2014.09.02.02.31.59 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 02 Sep 2014 02:31:59 -0700 (PDT)"
            ],
            "References": "<1408456313-28812-1-git-send-email-declan.doherty@intel.com>\n\t<1409560289-29558-5-git-send-email-declan.doherty@intel.com>\n\t<345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "MIME-Version": "1.0",
            "X-Received": "by 10.180.101.129 with SMTP id fg1mr26937436wib.20.1409650320386;\n\tTue, 02 Sep 2014 02:32:00 -0700 (PDT)",
            "Message-ID": "<2319059.S7dZfdPe5P@xps13>",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=VvlKEq4Wxfqt5zTFE1qx05O4+zOJ3a7pC4sAmz/pL1Q=;\n\tb=BBJVdjSvU449YFebr6ThE4Edl7QNamYCqGCgDosmbbzUviFzjUVqXjsaLB9AoMwnw7\n\t2fknMrGMe7nFlhpjfn62DifPzxr4ryVFTxG/3dC1huvby8xo/gJoeBNdlSYbZ8PiAgzM\n\t3yofP/+MUa2RYXs2kEc5AP5c3Qi93VfxSOJDet3uDkEkIH5u8fpxlj3kCoRXhn1m4vEl\n\twnC4oAcFl6TuqtQZ/hSaRYtajSfFbSonY+doIcyMQKqJf62tsSVxV1qwxTJlrctVi6e8\n\t7jw4mibdKNz7JDN9ppvi6PMN2zMNt875wQuND4vlEn3h+I8uxInu5KoB6otEDt2WKo9Q\n\tDojA==",
            "X-List-Received-Date": "Tue, 02 Sep 2014 09:27:29 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Precedence": "list",
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Organization": "6WIND",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "\"Doherty, Declan\" <declan.doherty@intel.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-Gm-Message-State": "ALoCoQkJXf2CsLt8PNaDEgXPyoBoZYcfBM4TptcCQqjrr3vsSJtKqkcNFL42c4R4gM2gQrNj5Qwo",
            "Content-Transfer-Encoding": "7Bit",
            "Cc": "dev@dpdk.org",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-BeenThere": "dev@dpdk.org",
            "Subject": "Re: [dpdk-dev] [PATCH v2 4/6] bond: free mbufs if transmission\n\tfails in bonding tx_burst functions"
        }
    },
    {
        "id": 618,
        "web_url": "https://patches.dpdk.org/comment/618/",
        "msgid": "<345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com>",
        "date": "2014-09-02T09:22:31",
        "subject": "Re: [dpdk-dev] [PATCH v2 4/6] bond: free mbufs if transmission\n\tfails in bonding tx_burst functions",
        "submitter": {
            "id": 11,
            "url": "https://patches.dpdk.org/api/people/11/",
            "name": "Doherty, Declan",
            "email": "declan.doherty@intel.com"
        },
        "content": "> -----Original Message-----\n> From: Doherty, Declan\n> Sent: Monday, September 1, 2014 9:31 AM\n> To: dev@dpdk.org\n> Cc: thomas.monjalon@6wind.com; rsanford@akamai.com; Doherty, Declan\n> Subject: [PATCH v2 4/6] bond: free mbufs if transmission fails in bonding tx_burst\n> functions\n> \n> Fixing a number of corner cases that if transmission failed on slave devices then\n> this\n> could lead to leaked mbufs\n> \n> V2 addresses behaviouraly issues in the first version and packets are no longer\n> freed in\n> the bonding layer, except in the case of broadcast mode where in failures happen\n> on\n> more than a single slave then mbufs will be freed in all slaves except the one\n> where\n> the least errors occured. Also contains new unit tests to test the transmission\n>  failure case in slaves for\n> round-robin, balance, and broadcast modes.\n> \n> \n> Signed-off-by: Declan Doherty <declan.doherty@intel.com>\n> ---\n.....\n> --\n> 1.7.0.7\n\nI've just noticed that I inserted an extra character into the patch when I was annotating this\npatch which will cause this a fail compilation.\n\n> +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -s\n> +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT);\n\nshould have been \n> +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -\n> +\t\t\tTEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT);\n\nThomas, do you want me to submit a V3 of this?\n\nRegards\nDeclan",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "X-MS-TNEF-Correlator": "",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[PATCH v2 4/6] bond: free mbufs if transmission fails in\n\tbonding tx_burst functions",
            "x-originating-ip": "[163.33.239.180]",
            "Received": [
                "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id BABC7B388\n\tfor <dev@dpdk.org>; Tue,  2 Sep 2014 11:19:34 +0200 (CEST)",
                "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 02 Sep 2014 02:15:49 -0700",
                "from irsmsx102.ger.corp.intel.com ([163.33.3.155])\n\tby FMSMGA003.fm.intel.com with ESMTP; 02 Sep 2014 02:19:28 -0700",
                "from irsmsx109.ger.corp.intel.com (163.33.3.23) by\n\tIRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 2 Sep 2014 10:22:32 +0100",
                "from irsmsx101.ger.corp.intel.com ([169.254.1.194]) by\n\tIRSMSX109.ger.corp.intel.com ([169.254.13.200]) with mapi id\n\t14.03.0195.001; Tue, 2 Sep 2014 10:22:32 +0100"
            ],
            "References": "<1408456313-28812-1-git-send-email-declan.doherty@intel.com>\n\t<1409560289-29558-5-git-send-email-declan.doherty@intel.com>",
            "MIME-Version": "1.0",
            "Message-ID": "<345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com>",
            "Accept-Language": "en-IE, en-US",
            "X-List-Received-Date": "Tue, 02 Sep 2014 09:19:35 -0000",
            "Thread-Index": "AQHPxb8yjHa+NDtmSEWJ3xdkPx+v+Zvti0jQ",
            "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"380191698\"",
            "Content-Language": "en-US",
            "Content-Transfer-Encoding": "quoted-printable",
            "From": "\"Doherty, Declan\" <declan.doherty@intel.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Return-Path": "<declan.doherty@intel.com>",
            "X-MS-Has-Attach": "",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<1409560289-29558-5-git-send-email-declan.doherty@intel.com>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "Precedence": "list",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Tue, 2 Sep 2014 09:22:31 +0000",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Subject": "Re: [dpdk-dev] [PATCH v2 4/6] bond: free mbufs if transmission\n\tfails in bonding tx_burst functions"
        }
    }
]