Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 26514,
    "url": "https://patches.dpdk.org/api/patches/26514/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170705165533.20581-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170705165533.20581-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170705165533.20581-2-stephen@networkplumber.org",
    "date": "2017-07-05T16:55:31",
    "name": "[dpdk-dev,v3,1/3] pci: remove unnecessary casts from strtoul",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4b8ec25b0d35fea373dbc9cd5c6903d85dfc46f1",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170705165533.20581-2-stephen@networkplumber.org/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/26514/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/26514/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 33D2758EC;\n\tWed,  5 Jul 2017 18:55:45 +0200 (CEST)",
            "from mail-pf0-f176.google.com (mail-pf0-f176.google.com\n\t[209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 64C6B2C13\n\tfor <dev@dpdk.org>; Wed,  5 Jul 2017 18:55:43 +0200 (CEST)",
            "by mail-pf0-f176.google.com with SMTP id c73so132513711pfk.2\n\tfor <dev@dpdk.org>; Wed, 05 Jul 2017 09:55:43 -0700 (PDT)",
            "from xeon-e3.wavecable.com (76-14-207-240.or.wavecable.com.\n\t[76.14.207.240]) by smtp.gmail.com with ESMTPSA id\n\to1sm47900914pgq.10.2017.07.05.09.55.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Jul 2017 09:55:41 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=IW1SHmB/eSYYUA6S9qRTgDySTuT/JhBEH2rrYLsug0Y=;\n\tb=KahpCP2e7KDgUF2wg9KwPTn0cSidz07Tt4FUtx0bxj8ewz9bfm6KD9deLJFVUeJJVz\n\tZh3lqnuuJMgLAnzi+xxEUqbSnUGtczwhrysm2Mvfwn3i8biCLECVQg9d8ALR/DvOOBIe\n\to5TqTtPn4WAvQA4dGXtOWKG44YMTKThEEuAlwcPnFphDsubcjgGTRR+o7HDIxgIH6AxD\n\tQxhrCKSvWorXTDAKQXp80UokyOQ8sNpScB3OBDS6FG6ECWzDFx3lD9H1Kk6bOpGj4jBq\n\tyH4+P8pwKM+nPVAenwBVMkjA380xh2RGt8KemZLLTmtVxAHuDtAj8qbPAzVLFvuiaETu\n\tbfTw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=IW1SHmB/eSYYUA6S9qRTgDySTuT/JhBEH2rrYLsug0Y=;\n\tb=JdIQ4pVABod933Bma+Fkg+Tm9WBIe1hzyn/M290lEcHQAEnFtvc4DF5LKJVoCBJG2C\n\tVzaT7YJvemx4dCB0hoRyDb48kBIlrm5uP9uV8+nkGg/hk2J6O6fmRHayuDzpVmgBbh/M\n\tk6I5T1D1Hejk4KEav5e8epa+3/2HDvAyJyiRKFYcg/kohbUJxaw3tniaUNwChaVJisEt\n\tp1ZN9Kr8sjHLFM9je+ROcwKVBhFAmrQ4e9filxnPZ/LfM3bjErHu2QXKKdB/X5nvpB1k\n\tjXQwQtaEuGxa7UOW2wpdV3c+nmTaQkvin9J9gg2hAxJdrhX4U6qBs0ePyqA5yhVj6HOa\n\tFpLg==",
        "X-Gm-Message-State": "AIVw110FS0ZLnEwHXcZIuwlfCJx6/VIHV5Akp8l4D5kxUD24SjiIxo1v\n\tdX4dxctE8+zOzCXpKdyQPw==",
        "X-Received": "by 10.99.101.135 with SMTP id z129mr21547996pgb.66.1499273742436;\n\tWed, 05 Jul 2017 09:55:42 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Wed,  5 Jul 2017 09:55:31 -0700",
        "Message-Id": "<20170705165533.20581-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20170705165533.20581-1-stephen@networkplumber.org>",
        "References": "<20170705165533.20581-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH v3 1/3] pci: remove unnecessary casts from strtoul",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The function strtoul returns unsigned long and can be directly\nassigned to a smaller type. Removing the casts allows easier\nexpansion of PCI domain.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n lib/librte_eal/linuxapp/eal/eal_pci.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c\nindex c817b4c3954d..7d9e1a99b9c4 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c\n@@ -430,10 +430,10 @@ parse_pci_addr_format(const char *buf, int bufsize, struct rte_pci_addr *addr)\n \n \t/* now convert to int values */\n \terrno = 0;\n-\taddr->domain = (uint16_t)strtoul(splitaddr.domain, NULL, 16);\n-\taddr->bus = (uint8_t)strtoul(splitaddr.bus, NULL, 16);\n-\taddr->devid = (uint8_t)strtoul(splitaddr.devid, NULL, 16);\n-\taddr->function = (uint8_t)strtoul(splitaddr.function, NULL, 10);\n+\taddr->domain = strtoul(splitaddr.domain, NULL, 16);\n+\taddr->bus = strtoul(splitaddr.bus, NULL, 16);\n+\taddr->devid = strtoul(splitaddr.devid, NULL, 16);\n+\taddr->function = strtoul(splitaddr.function, NULL, 10);\n \tif (errno != 0)\n \t\tgoto error;\n \n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "1/3"
    ]
}