Patch Comment List
List patch comments
GET /api/patches/264/comments/?format=api
[ { "id": 662, "web_url": "https://patches.dpdk.org/comment/662/", "msgid": "<E115CCD9D858EF4F90C690B0DCB4D89722614304@IRSMSX108.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/E115CCD9D858EF4F90C690B0DCB4D89722614304@IRSMSX108.ger.corp.intel.com", "date": "2014-09-05T16:14:15", "subject": "Re: [dpdk-dev] [PATCH v2 1/6] ixgbe: put only non-zero initializer\n\tin\tdefinition", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson\n> Sent: Thursday, August 28, 2014 4:43 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH v2 1/6] ixgbe: put only non-zero initializer in\n> definition\n> \n> Since all unspecified fields in an initializer are assumed to be zero we\n> can simplify the empty mbuf definition in the vector driver to only use\n> the fields that are non-zero, i.e. just nb_segs = 1. This makes things\n> shorter and means that the structure doesn't need as many updates for\n> other fields being renamed or moved.\n> \n> The variable itself is never modified and only used by a single function\n> so it can be made const and local to the using function.\n> \n> Changes in v2:\n> * None\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAcked-by Pablo de Lara <pablo.de.lara.guarch@intel.com>", "headers": { "Return-Path": "<pablo.de.lara.guarch@intel.com>", "Received": [ "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id E9BAAA547\n\tfor <dev@dpdk.org>; Fri, 5 Sep 2014 18:09:34 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 05 Sep 2014 09:14:18 -0700", "from irsmsx102.ger.corp.intel.com ([163.33.3.155])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Sep 2014 09:14:17 -0700", "from irsmsx153.ger.corp.intel.com (163.33.192.75) by\n\tIRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Fri, 5 Sep 2014 17:14:16 +0100", "from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by\n\tIRSMSX153.ger.corp.intel.com ([169.254.9.160]) with mapi id\n\t14.03.0195.001; Fri, 5 Sep 2014 17:14:16 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,474,1406617200\"; d=\"scan'208\";a=\"595179401\"", "From": "\"De Lara Guarch, Pablo\" <pablo.de.lara.guarch@intel.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v2 1/6] ixgbe: put only non-zero initializer\n\tin\tdefinition", "Thread-Index": "AQHPwto+EuISDSUAFUeoAZSpztcD6Zvywx8A", "Date": "Fri, 5 Sep 2014 16:14:15 +0000", "Message-ID": "<E115CCD9D858EF4F90C690B0DCB4D89722614304@IRSMSX108.ger.corp.intel.com>", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-2-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409240559-14447-2-git-send-email-bruce.richardson@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 1/6] ixgbe: put only non-zero initializer\n\tin\tdefinition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Fri, 05 Sep 2014 16:09:35 -0000" }, "addressed": null }, { "id": 671, "web_url": "https://patches.dpdk.org/comment/671/", "msgid": "<540D60F0.2050403@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/540D60F0.2050403@6wind.com", "date": "2014-09-08T07:55:28", "subject": "Re: [dpdk-dev] [PATCH v2 1/6] ixgbe: put only non-zero initializer\n\tin definition", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "content": "Hello Bruce,\n\nOn 08/28/2014 05:42 PM, Bruce Richardson wrote:\n> Since all unspecified fields in an initializer are assumed to be zero we\n> can simplify the empty mbuf definition in the vector driver to only use\n> the fields that are non-zero, i.e. just nb_segs = 1. This makes things\n> shorter and means that the structure doesn't need as many updates for\n> other fields being renamed or moved.\n> \n> The variable itself is never modified and only used by a single function\n> so it can be made const and local to the using function.\n> \n> Changes in v2:\n> * None\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAcked-by: Olivier Matz <olivier.matz@6wind.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9BAAF683A;\n\tMon, 8 Sep 2014 09:50:39 +0200 (CEST)", "from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])\n\tby dpdk.org (Postfix) with ESMTP id 406CF3989\n\tfor <dev@dpdk.org>; Mon, 8 Sep 2014 09:50:39 +0200 (CEST)", "from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]\n\thelo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.80) (envelope-from <olivier.matz@6wind.com>)\n\tid 1XQtpy-0007dy-LS; Mon, 08 Sep 2014 09:58:13 +0200" ], "Message-ID": "<540D60F0.2050403@6wind.com>", "Date": "Mon, 08 Sep 2014 09:55:28 +0200", "From": "Olivier MATZ <olivier.matz@6wind.com>", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Icedove/24.5.0", "MIME-Version": "1.0", "To": "Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org", "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>\n\t<1409240559-14447-2-git-send-email-bruce.richardson@intel.com>", "In-Reply-To": "<1409240559-14447-2-git-send-email-bruce.richardson@intel.com>", "Content-Type": "text/plain; charset=ISO-8859-1", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v2 1/6] ixgbe: put only non-zero initializer\n\tin definition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]