Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26130/?format=api
https://patches.dpdk.org/api/patches/26130/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170630165140.59594-19-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170630165140.59594-19-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170630165140.59594-19-ferruh.yigit@intel.com", "date": "2017-06-30T16:51:38", "name": "[dpdk-dev,v9,18/20] ctrl_if: process ethtool messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0685a5523633b7eed4c28aa79ffe7113e54e7089", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170630165140.59594-19-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/26130/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/26130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9BE2B7CF8;\n\tFri, 30 Jun 2017 18:53:54 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id C9B37235\n\tfor <dev@dpdk.org>; Fri, 30 Jun 2017 18:52:11 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Jun 2017 09:52:11 -0700", "from silpixa00372839.ir.intel.com (HELO\n\tsilpixa00372839.ger.corp.intel.com) ([10.237.222.154])\n\tby orsmga004.jf.intel.com with ESMTP; 30 Jun 2017 09:52:10 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,287,1496127600\"; d=\"scan'208\";a=\"103233387\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "Date": "Fri, 30 Jun 2017 17:51:38 +0100", "Message-Id": "<20170630165140.59594-19-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.13.0", "In-Reply-To": "<20170630165140.59594-1-ferruh.yigit@intel.com>", "References": "<20170621110651.75299-1-ferruh.yigit@intel.com>\n\t<20170630165140.59594-1-ferruh.yigit@intel.com>", "Subject": "[dpdk-dev] [PATCH v9 18/20] ctrl_if: process ethtool messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Process ethtool messages and rend response back to kernel.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n lib/librte_ctrl_if/rte_ctrl_process.c | 223 ++++++++++++++++++++++++++++++++++\n lib/librte_ctrl_if/rte_ctrl_process.h | 4 +\n lib/librte_ctrl_if/rte_nl.c | 4 +\n 3 files changed, 231 insertions(+)", "diff": "diff --git a/lib/librte_ctrl_if/rte_ctrl_process.c b/lib/librte_ctrl_if/rte_ctrl_process.c\nindex cfb243f64..55fd54351 100644\n--- a/lib/librte_ctrl_if/rte_ctrl_process.c\n+++ b/lib/librte_ctrl_if/rte_ctrl_process.c\n@@ -38,8 +38,231 @@\n \n #include <rte_version.h>\n #include <rte_ethdev.h>\n+#include <rte_ethtool.h>\n #include \"rte_ctrl_process.h\"\n \n+#define ETHTOOL_GEEPROM_LEN 99\n+#define ETHTOOL_GREGS_LEN 98\n+#define ETHTOOL_GSSET_COUNT 97\n+\n+static int\n+get_settings(uint8_t port_id __rte_unused, void *data, size_t *data_len)\n+{\n+\tstruct ethtool_cmd *ecmd = data;\n+\n+\t/* No PMD equivalent, added to make get pauseparam work */\n+\tmemset(ecmd, 0, sizeof(struct ethtool_cmd));\n+\n+\t*data_len = sizeof(struct ethtool_cmd);\n+\treturn 0;\n+}\n+\n+static int\n+get_drvinfo(uint8_t port_id, void *data, size_t *data_len)\n+{\n+\tstruct ethtool_drvinfo *info = data;\n+\tint ret;\n+\n+\tret = rte_ethtool_get_drvinfo(port_id, info);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\t*data_len = sizeof(struct ethtool_drvinfo);\n+\n+\treturn 0;\n+}\n+\n+static int\n+get_reg_len(uint8_t port_id, void *data, size_t *data_len)\n+{\n+\tint reg_length = 0;\n+\n+\treg_length = rte_ethtool_get_regs_len(port_id);\n+\tif (reg_length < 0)\n+\t\treturn reg_length;\n+\n+\t*(int *)data = reg_length;\n+\t*data_len = sizeof(int);\n+\n+\treturn 0;\n+}\n+\n+static int\n+get_reg_len_internal(uint8_t port_id, size_t *reg_length)\n+{\n+\tsize_t reg_length_out_len;\n+\n+\treturn get_reg_len(port_id, reg_length, ®_length_out_len);\n+}\n+\n+static int\n+get_reg(uint8_t port_id, void *in_data, void *out_data, size_t *out_data_len)\n+{\n+\tsize_t reg_length;\n+\tstruct ethtool_regs *ethtool_regs = in_data;\n+\tint ret;\n+\n+\tret = get_reg_len_internal(port_id, ®_length);\n+\t/* not enough space in out data buffer */\n+\tif (ret < 0 || reg_length > ethtool_regs->len)\n+\t\treturn -1;\n+\n+\tret = rte_ethtool_get_regs(port_id, ethtool_regs, out_data);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\t*out_data_len = reg_length;\n+\n+\treturn 0;\n+}\n+\n+static int\n+get_link(uint8_t port_id, void *data, size_t *data_len)\n+{\n+\tint ret;\n+\n+\tret = rte_ethtool_get_link(port_id);\n+\n+\t*(int *)data = ret;\n+\t*data_len = sizeof(size_t);\n+\n+\treturn 0;\n+}\n+\n+static int\n+get_eeprom_length(uint8_t port_id, void *data, size_t *data_len)\n+{\n+\tint eeprom_length = 0;\n+\n+\teeprom_length = rte_ethtool_get_eeprom_len(port_id);\n+\tif (eeprom_length < 0)\n+\t\treturn eeprom_length;\n+\n+\t*(int *)data = eeprom_length;\n+\t*data_len = sizeof(int);\n+\n+\treturn 0;\n+}\n+\n+static int\n+get_eeprom(uint8_t port_id, void *in_data, void *out_data,\n+\t\tsize_t *out_data_len)\n+{\n+\tstruct ethtool_eeprom *eeprom = in_data;\n+\tint ret;\n+\n+\tret = rte_ethtool_get_eeprom(port_id, eeprom, out_data);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\t*out_data_len = eeprom->len;\n+\n+\treturn 0;\n+}\n+\n+static int\n+set_eeprom(uint8_t port_id, void *in_data)\n+{\n+\tstruct ethtool_eeprom *eeprom = in_data;\n+\tint ret;\n+\n+\tret = rte_ethtool_set_eeprom(port_id, eeprom, eeprom->data);\n+\tif (ret != 0)\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n+static int\n+get_ringparam(uint8_t port_id, void *data, size_t *data_len)\n+{\n+\tstruct ethtool_ringparam *ringparam = data;\n+\tint ret;\n+\n+\tret = rte_ethtool_get_ringparam(port_id, ringparam);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\t*data_len = sizeof(struct ethtool_ringparam);\n+\n+\treturn 0;\n+}\n+\n+static int\n+set_ringparam(uint8_t port_id, void *data)\n+{\n+\tstruct ethtool_ringparam *ringparam = data;\n+\tint ret;\n+\n+\tret = rte_ethtool_set_ringparam(port_id, ringparam);\n+\tif (ret != 0)\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n+static int\n+get_pauseparam(uint8_t port_id, void *data, size_t *data_len)\n+{\n+\tstruct ethtool_pauseparam *pauseparam = data;\n+\tint ret;\n+\n+\tret = rte_ethtool_get_pauseparam(port_id, pauseparam);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\t*data_len = sizeof(struct ethtool_pauseparam);\n+\n+\treturn 0;\n+}\n+\n+static int\n+set_pauseparam(uint8_t port_id, void *data)\n+{\n+\tstruct ethtool_pauseparam *pauseparam = data;\n+\n+\treturn rte_ethtool_set_pauseparam(port_id, pauseparam);\n+}\n+\n+int\n+rte_eth_dev_ethtool_process(uint32_t cmd_id, uint8_t port_id, void *in_data,\n+\t\tvoid *out_data, size_t *out_data_len)\n+{\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -ENODEV;\n+\n+\tswitch (cmd_id) {\n+\tcase ETHTOOL_GSET:\n+\t\treturn get_settings(port_id, out_data, out_data_len);\n+\tcase ETHTOOL_GDRVINFO:\n+\t\treturn get_drvinfo(port_id, out_data, out_data_len);\n+\tcase ETHTOOL_GREGS_LEN:\n+\t\treturn get_reg_len(port_id, out_data, out_data_len);\n+\tcase ETHTOOL_GREGS:\n+\t\treturn get_reg(port_id, in_data, out_data, out_data_len);\n+\tcase ETHTOOL_GLINK:\n+\t\treturn get_link(port_id, out_data, out_data_len);\n+\tcase ETHTOOL_GEEPROM_LEN:\n+\t\treturn get_eeprom_length(port_id, out_data, out_data_len);\n+\tcase ETHTOOL_GEEPROM:\n+\t\treturn get_eeprom(port_id, in_data, out_data, out_data_len);\n+\tcase ETHTOOL_SEEPROM:\n+\t\treturn set_eeprom(port_id, in_data);\n+\tcase ETHTOOL_GRINGPARAM:\n+\t\treturn get_ringparam(port_id, out_data, out_data_len);\n+\tcase ETHTOOL_SRINGPARAM:\n+\t\treturn set_ringparam(port_id, in_data);\n+\tcase ETHTOOL_GPAUSEPARAM:\n+\t\treturn get_pauseparam(port_id, out_data, out_data_len);\n+\tcase ETHTOOL_SPAUSEPARAM:\n+\t\treturn set_pauseparam(port_id, in_data);\n+\tdefault:\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n set_mtu(uint8_t port_id, void *in_data)\n {\ndiff --git a/lib/librte_ctrl_if/rte_ctrl_process.h b/lib/librte_ctrl_if/rte_ctrl_process.h\nindex f67c60107..caa4f15f3 100644\n--- a/lib/librte_ctrl_if/rte_ctrl_process.h\n+++ b/lib/librte_ctrl_if/rte_ctrl_process.h\n@@ -38,8 +38,12 @@\n extern \"C\" {\n #endif\n \n+#include <linux/ethtool.h>\n+\n #include <exec-env/rte_unci_common.h>\n \n+int rte_eth_dev_ethtool_process(uint32_t cmd_id, uint8_t port_id, void *in_data,\n+\t\tvoid *out_data, size_t *out_data_len);\n int rte_eth_dev_control_process(uint32_t cmd_id, uint8_t port_id, void *in_data,\n \t\tvoid *out_data, size_t *out_data_len);\n \ndiff --git a/lib/librte_ctrl_if/rte_nl.c b/lib/librte_ctrl_if/rte_nl.c\nindex 920d123a9..d00a242d2 100644\n--- a/lib/librte_ctrl_if/rte_nl.c\n+++ b/lib/librte_ctrl_if/rte_nl.c\n@@ -123,6 +123,10 @@ process_msg(struct unci_nl_msg *msg)\n \t\tmsg->err = rte_eth_dev_control_process(msg->cmd_id,\n \t\t\t\tmsg->port_id, msg->input_buffer,\n \t\t\t\tmsg->output_buffer, &msg->output_buffer_len);\n+\t} else {\n+\t\tmsg->err = rte_eth_dev_ethtool_process(msg->cmd_id,\n+\t\t\t\tmsg->port_id, msg->input_buffer,\n+\t\t\t\tmsg->output_buffer, &msg->output_buffer_len);\n \t}\n \n \tif (msg->err)\n", "prefixes": [ "dpdk-dev", "v9", "18/20" ] }{ "id": 26130, "url": "