Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26096/?format=api
{ "id": 26096, "url": "https://patches.dpdk.org/api/patches/26096/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170630142021.50855-4-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170630142021.50855-4-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170630142021.50855-4-ajit.khaparde@broadcom.com", "date": "2017-06-30T14:20:15", "name": "[dpdk-dev,v2,3/9] net/bnxt: fix calculation of VNICs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b5a3ae00f4887707508a519f744ad8185464793b", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170630142021.50855-4-ajit.khaparde@broadcom.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/26096/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/26096/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 776E37CAF;\n\tFri, 30 Jun 2017 16:20:38 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (lpdvrndsmtp01.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 95CA65905\n\tfor <dev@dpdk.org>; Fri, 30 Jun 2017 16:20:30 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.224.233])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 4B4B630C01E;\n\tFri, 30 Jun 2017 07:20:29 -0700 (PDT)", "from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.85.248.104])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id D75CA81EA4;\n\tFri, 30 Jun 2017 07:20:28 -0700 (PDT)" ], "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tStephen Hurd <stephen.hurd@broadcom.com>", "Date": "Fri, 30 Jun 2017 09:20:15 -0500", "Message-Id": "<20170630142021.50855-4-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.10.1 (Apple Git-78)", "In-Reply-To": "<20170630142021.50855-1-ajit.khaparde@broadcom.com>", "References": "<096daf46-dd9f-f84b-de0d-9a4e87a8d461@intel.com>\n\t<20170630142021.50855-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 3/9] net/bnxt: fix calculation of VNICs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We used the default as a work-around for the 4-byte MTU VNICs,\nbut we filter those out now. So fix the calculation of VNICs\naccordingly.\n\nFixes: ff63ebbb67a7 (\"net/bnxt: determine the Rx status of VF\")\n\nSigned-off-by: Stephen Hurd <stephen.hurd@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n--\nv1->v2: Fix the commit log.\n---\n drivers/net/bnxt/bnxt_hwrm.c | 10 +++++-----\n drivers/net/bnxt/bnxt_hwrm.h | 2 +-\n drivers/net/bnxt/rte_pmd_bnxt.c | 2 +-\n 3 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 580b2d8..7fb9800 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -2740,12 +2740,12 @@ int bnxt_hwrm_port_led_cfg(struct bnxt *bp, bool led_on)\n \treturn rc;\n }\n \n-static void bnxt_vnic_count(struct bnxt_vnic_info *vnic, void *cbdata)\n+static void\n+bnxt_vnic_count(struct bnxt_vnic_info *vnic __rte_unused, void *cbdata)\n {\n \tuint32_t *count = cbdata;\n \n-\tif (vnic->func_default)\n-\t\t*count = *count + 1;\n+\t*count = *count + 1;\n }\n \n static int bnxt_vnic_count_hwrm_stub(struct bnxt *bp __rte_unused,\n@@ -2754,7 +2754,7 @@ static int bnxt_vnic_count_hwrm_stub(struct bnxt *bp __rte_unused,\n \treturn 0;\n }\n \n-int bnxt_vf_default_vnic_count(struct bnxt *bp, uint16_t vf)\n+int bnxt_vf_vnic_count(struct bnxt *bp, uint16_t vf)\n {\n \tuint32_t count = 0;\n \n@@ -2837,7 +2837,7 @@ int bnxt_hwrm_func_vf_vnic_query_and_config(struct bnxt *bp, uint16_t vf,\n \t\trc = bnxt_hwrm_vnic_qcfg(bp, &vnic, bp->pf.first_vf_id + vf);\n \t\tif (rc)\n \t\t\tbreak;\n-\t\tif (vnic.mru == 4)\t/* Indicates unallocated */\n+\t\tif (vnic.mru <= 4)\t/* Indicates unallocated */\n \t\t\tcontinue;\n \n \t\tvnic_cb(&vnic, cbdata);\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex a603dda..82cca3a 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -145,7 +145,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp);\n int bnxt_hwrm_func_cfg_vf_set_flags(struct bnxt *bp, uint16_t vf);\n void vf_vnic_set_rxmask_cb(struct bnxt_vnic_info *vnic, void *flagp);\n int bnxt_set_rx_mask_no_vlan(struct bnxt *bp, struct bnxt_vnic_info *vnic);\n-int bnxt_vf_default_vnic_count(struct bnxt *bp, uint16_t vf);\n+int bnxt_vf_vnic_count(struct bnxt *bp, uint16_t vf);\n int bnxt_hwrm_func_vf_vnic_query_and_config(struct bnxt *bp, uint16_t vf,\n \tvoid (*vnic_cb)(struct bnxt_vnic_info *, void *), void *cbdata,\n \tint (*hwrm_cb)(struct bnxt *bp, struct bnxt_vnic_info *vnic));\ndiff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c\nindex faeb6f4..1bd5aee 100644\n--- a/drivers/net/bnxt/rte_pmd_bnxt.c\n+++ b/drivers/net/bnxt/rte_pmd_bnxt.c\n@@ -610,7 +610,7 @@ int rte_pmd_bnxt_get_vf_rx_status(uint8_t port, uint16_t vf_id)\n \t\treturn -ENOTSUP;\n \t}\n \n-\treturn bnxt_vf_default_vnic_count(bp, vf_id);\n+\treturn bnxt_vf_vnic_count(bp, vf_id);\n }\n \n int rte_pmd_bnxt_get_vf_tx_drop_count(uint8_t port, uint16_t vf_id,\n", "prefixes": [ "dpdk-dev", "v2", "3/9" ] }