Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2605/?format=api
{ "id": 2605, "url": "https://patches.dpdk.org/api/patches/2605/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1422379175-10004-1-git-send-email-michalx.k.jastrzebski@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1422379175-10004-1-git-send-email-michalx.k.jastrzebski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1422379175-10004-1-git-send-email-michalx.k.jastrzebski@intel.com", "date": "2015-01-27T17:19:35", "name": "[dpdk-dev,v2] testpmd check return value of rte_eth_dev_vlan_filter()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7ae2d7d8cad221a59f749305d6479e1149471eae", "submitter": { "id": 74, "url": "https://patches.dpdk.org/api/people/74/?format=api", "name": "Michal Jastrzebski", "email": "michalx.k.jastrzebski@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1422379175-10004-1-git-send-email-michalx.k.jastrzebski@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2605/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2605/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7E1705AE1;\n\tTue, 27 Jan 2015 18:20:05 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 1C4035ABE\n\tfor <dev@dpdk.org>; Tue, 27 Jan 2015 18:20:02 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 27 Jan 2015 09:20:01 -0800", "from unknown (HELO Sent) ([10.217.248.194])\n\tby orsmga001.jf.intel.com with SMTP; 27 Jan 2015 09:19:59 -0800", "by Sent (sSMTP sendmail emulation); Tue, 27 Jan 2015 18:19:57 +0200" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,475,1418112000\"; d=\"scan'208\";a=\"643360033\"", "From": "Michal Jastrzebski <michalx.k.jastrzebski@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 27 Jan 2015 18:19:35 +0100", "Message-Id": "<1422379175-10004-1-git-send-email-michalx.k.jastrzebski@intel.com>", "X-Mailer": "git-send-email 2.1.1", "Subject": "[dpdk-dev] [PATCH v2] testpmd check return value of\n\trte_eth_dev_vlan_filter()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch modifies testpmd behavior when setting:\nrx_vlan add all vf_port (enabling all vlanids\nto be passed thru rx filter on VF).\nRx_vlan_all_filter_set() function,\nchecks if the next vlanid can be enabled by the driver.\nNumber of vlanids is limited by the NIC and thus the NIC\ndo not allow to enable more vlanids than it can allocate\nin VFTA table.\n\nv2 - fix formatting errors\n\nSigned-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>\n---\n app/test-pmd/config.c | 15 +++++++++------\n app/test-pmd/testpmd.h | 2 +-\n lib/librte_ether/rte_ethdev.c | 4 ++--\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex c40f819..eda737e 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -1643,21 +1643,22 @@ rx_vlan_filter_set(portid_t port_id, int on)\n \t \"diag=%d\\n\", port_id, on, diag);\n }\n \n-void\n+int\n rx_vft_set(portid_t port_id, uint16_t vlan_id, int on)\n {\n \tint diag;\n \n \tif (port_id_is_invalid(port_id))\n-\t\treturn;\n+\t\treturn 1;\n \tif (vlan_id_is_invalid(vlan_id))\n-\t\treturn;\n+\t\treturn 1;\n \tdiag = rte_eth_dev_vlan_filter(port_id, vlan_id, on);\n \tif (diag == 0)\n-\t\treturn;\n+\t\treturn 0;\n \tprintf(\"rte_eth_dev_vlan_filter(port_pi=%d, vlan_id=%d, on=%d) failed \"\n \t \"diag=%d\\n\",\n \t port_id, vlan_id, on, diag);\n+\treturn -1;\n }\n \n void\n@@ -1667,8 +1668,10 @@ rx_vlan_all_filter_set(portid_t port_id, int on)\n \n \tif (port_id_is_invalid(port_id))\n \t\treturn;\n-\tfor (vlan_id = 0; vlan_id < 4096; vlan_id++)\n-\t\trx_vft_set(port_id, vlan_id, on);\n+\tfor (vlan_id = 0; vlan_id < 4096; vlan_id++)\t{\n+\t\tif (rx_vft_set(port_id, vlan_id, on))\n+\t\t\tbreak;\n+\t}\n }\n \n void\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 8f5e6c7..e0186b9 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -492,7 +492,7 @@ void rx_vlan_strip_set_on_queue(portid_t port_id, uint16_t queue_id, int on);\n \n void rx_vlan_filter_set(portid_t port_id, int on);\n void rx_vlan_all_filter_set(portid_t port_id, int on);\n-void rx_vft_set(portid_t port_id, uint16_t vlan_id, int on);\n+int rx_vft_set(portid_t port_id, uint16_t vlan_id, int on);\n void vlan_extend_set(portid_t port_id, int on);\n void vlan_tpid_set(portid_t port_id, uint16_t tp_id);\n void tx_vlan_set(portid_t port_id, uint16_t vlan_id);\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex ea3a1fb..064b5d6 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1519,8 +1519,8 @@ rte_eth_dev_vlan_filter(uint8_t port_id, uint16_t vlan_id, int on)\n \t\treturn (-EINVAL);\n \t}\n \tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_filter_set, -ENOTSUP);\n-\t(*dev->dev_ops->vlan_filter_set)(dev, vlan_id, on);\n-\treturn (0);\n+\n+\treturn (*dev->dev_ops->vlan_filter_set)(dev, vlan_id, on);\n }\n \n int\n", "prefixes": [ "dpdk-dev", "v2" ] }