Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2600,
    "url": "https://patches.dpdk.org/api/patches/2600/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1422360978-16954-1-git-send-email-michael.qiu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1422360978-16954-1-git-send-email-michael.qiu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1422360978-16954-1-git-send-email-michael.qiu@intel.com",
    "date": "2015-01-27T12:16:18",
    "name": "[dpdk-dev,v2] librte_pmd_ixgbe: Add queue start failure check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "375e748bb577f498c75bcdd5f9ea72ea8b573dd1",
    "submitter": {
        "id": 101,
        "url": "https://patches.dpdk.org/api/people/101/?format=api",
        "name": "Michael Qiu",
        "email": "michael.qiu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1422360978-16954-1-git-send-email-michael.qiu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/2600/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/2600/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D8A2E5F81;\n\tTue, 27 Jan 2015 13:16:32 +0100 (CET)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 7EC275F80\n\tfor <dev@dpdk.org>; Tue, 27 Jan 2015 13:16:30 +0100 (CET)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 27 Jan 2015 04:10:23 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 27 Jan 2015 04:09:22 -0800",
            "from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com\n\t[10.239.29.90])\n\tby shvmail01.sh.intel.com with ESMTP id t0RCGPO5020932;\n\tTue, 27 Jan 2015 20:16:25 +0800",
            "from shecgisg003.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0RCGNWU016988; Tue, 27 Jan 2015 20:16:25 +0800",
            "(from dayuqiu@localhost)\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t0RCGJeG016984; \n\tTue, 27 Jan 2015 20:16:19 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.09,474,1418112000\"; d=\"scan'208\";a=\"518287383\"",
        "From": "Michael Qiu <michael.qiu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 27 Jan 2015 20:16:18 +0800",
        "Message-Id": "<1422360978-16954-1-git-send-email-michael.qiu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1421333111-22136-1-git-send-email-michael.qiu@intel.com>",
        "References": "<1421333111-22136-1-git-send-email-michael.qiu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2] librte_pmd_ixgbe: Add queue start failure\n\tcheck",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "For ixgbe, when queue start failure, for example, mbuf allocate\nfailure, the device will still start success, which could be\nan issue.\n\nAdd return status check of queue start to avoid this issue.\n\nSigned-off-by: Michael Qiu <michael.qiu@intel.com>\n---\nv2 --> v1\n\t. remove duplicated error message in ixgbe_dev_rxtx_start()\n\t. remove '\\n' in PMD_INIT_LOG()\n\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c |  6 +++++-\n lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  2 +-\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c   | 20 +++++++++++++++-----\n 3 files changed, 21 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\nindex b58ec45..ede8706 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n@@ -1495,7 +1495,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev)\n \t\tgoto error;\n \t}\n \n-\tixgbe_dev_rxtx_start(dev);\n+\terr = ixgbe_dev_rxtx_start(dev);\n+\tif (err < 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Unable to start rxtx queues\");\n+\t\tgoto error;\n+\t}\n \n \tif (ixgbe_is_sfp(hw) && hw->phy.multispeed_fiber) {\n \t\terr = hw->mac.ops.setup_sfp(hw);\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h\nindex 677c257..1383194 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h\n+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h\n@@ -265,7 +265,7 @@ int ixgbe_dev_rx_init(struct rte_eth_dev *dev);\n \n void ixgbe_dev_tx_init(struct rte_eth_dev *dev);\n \n-void ixgbe_dev_rxtx_start(struct rte_eth_dev *dev);\n+int ixgbe_dev_rxtx_start(struct rte_eth_dev *dev);\n \n int ixgbe_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n \ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex 840bc07..0224ed0 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -3806,7 +3806,7 @@ ixgbe_setup_loopback_link_82599(struct ixgbe_hw *hw)\n /*\n  * Start Transmit and Receive Units.\n  */\n-void\n+int\n ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw     *hw;\n@@ -3816,6 +3816,7 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)\n \tuint32_t dmatxctl;\n \tuint32_t rxctrl;\n \tuint16_t i;\n+\tint ret = 0;\n \n \tPMD_INIT_FUNC_TRACE();\n \thw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -3838,14 +3839,22 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)\n \n \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n \t\ttxq = dev->data->tx_queues[i];\n-\t\tif (!txq->tx_deferred_start)\n-\t\t\tixgbe_dev_tx_queue_start(dev, i);\n+\t\tif (!txq->tx_deferred_start) {\n+\t\t\tret = ixgbe_dev_tx_queue_start(dev, i);\n+\t\t\tif (ret < 0) {\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n \t}\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\trxq = dev->data->rx_queues[i];\n-\t\tif (!rxq->rx_deferred_start)\n-\t\t\tixgbe_dev_rx_queue_start(dev, i);\n+\t\tif (!rxq->rx_deferred_start) {\n+\t\t\tret = ixgbe_dev_rx_queue_start(dev, i);\n+\t\t\tif (ret < 0) {\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n \t}\n \n \t/* Enable Receive engine */\n@@ -3860,6 +3869,7 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)\n \t\t\tdev->data->dev_conf.lpbk_mode == IXGBE_LPBK_82599_TX_RX)\n \t\tixgbe_setup_loopback_link_82599(hw);\n \n+\treturn 0;\n }\n \n /*\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}