Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 25567,
    "url": "https://patches.dpdk.org/api/patches/25567/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170621063020.22002-1-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170621063020.22002-1-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170621063020.22002-1-pablo.de.lara.guarch@intel.com",
    "date": "2017-06-21T06:30:20",
    "name": "[dpdk-dev,v2,11/12] cryptodev: remove unused PCI probe/remove",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fcabd9bddea7a58eee85c3933dbcc3925cae5487",
    "submitter": {
        "id": 9,
        "url": "https://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170621063020.22002-1-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/25567/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/25567/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2A0285A3E;\n\tWed, 21 Jun 2017 16:30:07 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id C4EEE5A6E\n\tfor <dev@dpdk.org>; Wed, 21 Jun 2017 16:30:05 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Jun 2017 07:30:03 -0700",
            "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Jun 2017 07:30:02 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.39,369,1493708400\"; d=\"scan'208\";\n\ta=\"1185288800\"",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "declan.doherty@intel.com,\n\tthomas@monjalon.net",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Date": "Wed, 21 Jun 2017 07:30:20 +0100",
        "Message-Id": "<20170621063020.22002-1-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 2.9.4",
        "In-Reply-To": "<1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>",
        "References": "<1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 11/12] cryptodev: remove unused PCI\n\tprobe/remove",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nAcked-by: Declan Doherty <declan.doherty@intel.com>\n---\n lib/librte_cryptodev/rte_cryptodev.c           | 103 -------------------------\n lib/librte_cryptodev/rte_cryptodev_pmd.h       |  13 ----\n lib/librte_cryptodev/rte_cryptodev_version.map |  10 +--\n 3 files changed, 1 insertion(+), 125 deletions(-)",
    "diff": "diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex d02a4d0..3d118b5 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -47,7 +47,6 @@\n #include <rte_debug.h>\n #include <rte_dev.h>\n #include <rte_interrupts.h>\n-#include <rte_pci.h>\n #include <rte_memory.h>\n #include <rte_memcpy.h>\n #include <rte_memzone.h>\n@@ -553,108 +552,6 @@ rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev)\n \treturn 0;\n }\n \n-int\n-rte_cryptodev_pci_probe(struct rte_pci_driver *pci_drv,\n-\t\t\tstruct rte_pci_device *pci_dev)\n-{\n-\tstruct rte_cryptodev_driver *cryptodrv;\n-\tstruct rte_cryptodev *cryptodev;\n-\n-\tchar cryptodev_name[RTE_CRYPTODEV_NAME_MAX_LEN];\n-\n-\tint retval;\n-\n-\tcryptodrv = (struct rte_cryptodev_driver *)pci_drv;\n-\tif (cryptodrv == NULL)\n-\t\treturn -ENODEV;\n-\n-\trte_pci_device_name(&pci_dev->addr, cryptodev_name,\n-\t\t\tsizeof(cryptodev_name));\n-\n-\tcryptodev = rte_cryptodev_pmd_allocate(cryptodev_name, rte_socket_id());\n-\tif (cryptodev == NULL)\n-\t\treturn -ENOMEM;\n-\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\tcryptodev->data->dev_private =\n-\t\t\t\trte_zmalloc_socket(\n-\t\t\t\t\t\t\"cryptodev private structure\",\n-\t\t\t\t\t\tcryptodrv->dev_private_size,\n-\t\t\t\t\t\tRTE_CACHE_LINE_SIZE,\n-\t\t\t\t\t\trte_socket_id());\n-\n-\t\tif (cryptodev->data->dev_private == NULL)\n-\t\t\trte_panic(\"Cannot allocate memzone for private \"\n-\t\t\t\t\t\"device data\");\n-\t}\n-\n-\tcryptodev->device = &pci_dev->device;\n-\tcryptodev->driver = cryptodrv;\n-\n-\t/* init user callbacks */\n-\tTAILQ_INIT(&(cryptodev->link_intr_cbs));\n-\n-\t/* Invoke PMD device initialization function */\n-\tretval = (*cryptodrv->cryptodev_init)(cryptodrv, cryptodev);\n-\tif (retval == 0)\n-\t\treturn 0;\n-\n-\tCDEV_LOG_ERR(\"driver %s: crypto_dev_init(vendor_id=0x%x device_id=0x%x)\"\n-\t\t\t\" failed\", pci_drv->driver.name,\n-\t\t\t(unsigned) pci_dev->id.vendor_id,\n-\t\t\t(unsigned) pci_dev->id.device_id);\n-\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\trte_free(cryptodev->data->dev_private);\n-\n-\t/* free crypto device */\n-\trte_cryptodev_pmd_release_device(cryptodev);\n-\n-\treturn -ENXIO;\n-}\n-\n-int\n-rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev)\n-{\n-\tconst struct rte_cryptodev_driver *cryptodrv;\n-\tstruct rte_cryptodev *cryptodev;\n-\tchar cryptodev_name[RTE_CRYPTODEV_NAME_MAX_LEN];\n-\tint ret;\n-\n-\tif (pci_dev == NULL)\n-\t\treturn -EINVAL;\n-\n-\trte_pci_device_name(&pci_dev->addr, cryptodev_name,\n-\t\t\tsizeof(cryptodev_name));\n-\n-\tcryptodev = rte_cryptodev_pmd_get_named_dev(cryptodev_name);\n-\tif (cryptodev == NULL)\n-\t\treturn -ENODEV;\n-\n-\tcryptodrv = (const struct rte_cryptodev_driver *)pci_dev->driver;\n-\tif (cryptodrv == NULL)\n-\t\treturn -ENODEV;\n-\n-\t/* Invoke PMD device uninit function */\n-\tif (*cryptodrv->cryptodev_uninit) {\n-\t\tret = (*cryptodrv->cryptodev_uninit)(cryptodrv, cryptodev);\n-\t\tif (ret)\n-\t\t\treturn ret;\n-\t}\n-\n-\t/* free crypto device */\n-\trte_cryptodev_pmd_release_device(cryptodev);\n-\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\trte_free(cryptodev->data->dev_private);\n-\n-\tcryptodev->device = NULL;\n-\tcryptodev->driver = NULL;\n-\tcryptodev->data = NULL;\n-\n-\treturn 0;\n-}\n-\n uint16_t\n rte_cryptodev_queue_pair_count(uint8_t dev_id)\n {\ndiff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h\nindex 0efe282..6579170 100644\n--- a/lib/librte_cryptodev/rte_cryptodev_pmd.h\n+++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h\n@@ -482,19 +482,6 @@ void rte_cryptodev_pmd_callback_process(struct rte_cryptodev *dev,\n \t\t\t\tenum rte_cryptodev_event_type event);\n \n /**\n- * Wrapper for use by pci drivers as a .probe function to attach to a crypto\n- * interface.\n- */\n-int rte_cryptodev_pci_probe(struct rte_pci_driver *pci_drv,\n-\t\t\t    struct rte_pci_device *pci_dev);\n-\n-/**\n- * Wrapper for use by pci drivers as a .remove function to detach a crypto\n- * interface.\n- */\n-int rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev);\n-\n-/**\n  * @internal\n  * Create unique device name\n  */\ndiff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map\nindex d519234..b6c8ab8 100644\n--- a/lib/librte_cryptodev/rte_cryptodev_version.map\n+++ b/lib/librte_cryptodev/rte_cryptodev_version.map\n@@ -31,14 +31,6 @@ DPDK_16.04 {\n \tlocal: *;\n };\n \n-DPDK_16.11 {\n-\tglobal:\n-\n-\trte_cryptodev_pci_probe;\n-\trte_cryptodev_pci_remove;\n-\n-} DPDK_16.04;\n-\n DPDK_17.02 {\n \tglobal:\n \n@@ -55,7 +47,7 @@ DPDK_17.02 {\n \trte_crypto_cipher_algorithm_strings;\n \trte_crypto_cipher_operation_strings;\n \n-} DPDK_16.11;\n+} DPDK_16.04;\n \n DPDK_17.05 {\n \tglobal:\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "11/12"
    ]
}