Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2533/?format=api
{ "id": 2533, "url": "https://patches.dpdk.org/api/patches/2533/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1422326164-13697-9-git-send-email-changchun.ouyang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1422326164-13697-9-git-send-email-changchun.ouyang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1422326164-13697-9-git-send-email-changchun.ouyang@intel.com", "date": "2015-01-27T02:35:48", "name": "[dpdk-dev,v2,08/24] virtio: Remove redundant vq_alignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3bc21004cf1df9911be1efe7be89884acc8a49fa", "submitter": { "id": 31, "url": "https://patches.dpdk.org/api/people/31/?format=api", "name": "Ouyang Changchun", "email": "changchun.ouyang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1422326164-13697-9-git-send-email-changchun.ouyang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2533/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2533/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6ADD2282;\n\tTue, 27 Jan 2015 03:46:57 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id E016A5A3F\n\tfor <dev@dpdk.org>; Tue, 27 Jan 2015 03:36:35 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 26 Jan 2015 18:36:31 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 26 Jan 2015 18:29:26 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0R2aR8c014925;\n\tTue, 27 Jan 2015 10:36:27 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0R2aPr6013786; Tue, 27 Jan 2015 10:36:27 +0800", "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0R2aPdh013782; \n\tTue, 27 Jan 2015 10:36:25 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,471,1418112000\"; d=\"scan'208\";a=\"518014930\"", "From": "Ouyang Changchun <changchun.ouyang@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 27 Jan 2015 10:35:48 +0800", "Message-Id": "<1422326164-13697-9-git-send-email-changchun.ouyang@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1422326164-13697-1-git-send-email-changchun.ouyang@intel.com>", "References": "<1421298930-15210-1-git-send-email-changchun.ouyang@intel.com>\n\t<1422326164-13697-1-git-send-email-changchun.ouyang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 08/24] virtio: Remove redundant vq_alignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since vq_alignment is constant (always 4K), it does not\nneed to be part of the vring struct.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\n---\n lib/librte_pmd_virtio/virtio_ethdev.c | 1 -\n lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-\n lib/librte_pmd_virtio/virtqueue.h | 3 +--\n 3 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c\nindex 59b74b7..0d41e7f 100644\n--- a/lib/librte_pmd_virtio/virtio_ethdev.c\n+++ b/lib/librte_pmd_virtio/virtio_ethdev.c\n@@ -294,7 +294,6 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,\n \tvq->port_id = dev->data->port_id;\n \tvq->queue_id = queue_idx;\n \tvq->vq_queue_index = vtpci_queue_idx;\n-\tvq->vq_alignment = VIRTIO_PCI_VRING_ALIGN;\n \tvq->vq_nentries = vq_size;\n \tvq->vq_free_cnt = vq_size;\n \ndiff --git a/lib/librte_pmd_virtio/virtio_rxtx.c b/lib/librte_pmd_virtio/virtio_rxtx.c\nindex a82d5ff..b6d6832 100644\n--- a/lib/librte_pmd_virtio/virtio_rxtx.c\n+++ b/lib/librte_pmd_virtio/virtio_rxtx.c\n@@ -258,7 +258,7 @@ virtio_dev_vring_start(struct virtqueue *vq, int queue_type)\n \t * Reinitialise since virtio port might have been stopped and restarted\n \t */\n \tmemset(vq->vq_ring_virt_mem, 0, vq->vq_ring_size);\n-\tvring_init(vr, size, ring_mem, vq->vq_alignment);\n+\tvring_init(vr, size, ring_mem, VIRTIO_PCI_VRING_ALIGN);\n \tvq->vq_used_cons_idx = 0;\n \tvq->vq_desc_head_idx = 0;\n \tvq->vq_avail_idx = 0;\ndiff --git a/lib/librte_pmd_virtio/virtqueue.h b/lib/librte_pmd_virtio/virtqueue.h\nindex f6ad98d..5b8a255 100644\n--- a/lib/librte_pmd_virtio/virtqueue.h\n+++ b/lib/librte_pmd_virtio/virtqueue.h\n@@ -138,8 +138,7 @@ struct virtqueue {\n \tuint8_t port_id; /**< Device port identifier. */\n \n \tvoid *vq_ring_virt_mem; /**< linear address of vring*/\n-\tint vq_alignment;\n-\tint vq_ring_size;\n+\tunsigned int vq_ring_size;\n \tphys_addr_t vq_ring_mem; /**< physical address of vring */\n \n \tstruct vring vq_ring; /**< vring keeping desc, used and avail */\n", "prefixes": [ "dpdk-dev", "v2", "08/24" ] }