Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 25315,
    "url": "https://patches.dpdk.org/api/patches/25315/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/37ec2564e00fa96d8be9455949f799b179272093.1497439616.git.adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<37ec2564e00fa96d8be9455949f799b179272093.1497439616.git.adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/37ec2564e00fa96d8be9455949f799b179272093.1497439616.git.adrien.mazarguil@6wind.com",
    "date": "2017-06-14T11:49:15",
    "name": "[dpdk-dev,5/7] net/mlx5: fix Rx interrupts support checks",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ff398af275819e5f73bdc46c9f9793c4bb6bbd29",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/37ec2564e00fa96d8be9455949f799b179272093.1497439616.git.adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/25315/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/25315/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5890D7D18;\n\tWed, 14 Jun 2017 13:49:45 +0200 (CEST)",
            "from mail-wr0-f177.google.com (mail-wr0-f177.google.com\n\t[209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 6B8327D05\n\tfor <dev@dpdk.org>; Wed, 14 Jun 2017 13:49:35 +0200 (CEST)",
            "by mail-wr0-f177.google.com with SMTP id 77so38723741wrb.1\n\tfor <dev@dpdk.org>; Wed, 14 Jun 2017 04:49:35 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t62sm973634wrs.18.2017.06.14.04.49.33\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tWed, 14 Jun 2017 04:49:34 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=SN+LY2EFjP/eeAJLJR5fexJVRayh51QfSRIHCIc3/0I=;\n\tb=JsE++BgtH+LeT+cIDLRDMcL2cpE6zBp5j7V4IqkqK/ckcPUUVrUF/YY2BXdCptRSez\n\t59ySW4/NqnjfwEwszPRM8gXffw+YHcvo2+F+7wxoFrZ2EkRfRAZCn5JP39bhEyOkMqNr\n\tskF6Ox25AYdFMH+yvUH1Fbxzd/6OaKNGh1a2/l0pgYzilkrxBoqs6bbCejeRMO7BBC1E\n\tfHuBa4boKS9Dod/biCQSWQBKTBD1OvXKIgCms0UT4TVQ91bTceXM094x/CQ0ryLaEYnA\n\tgIbiqbMIgX2Syzfe1LhBN/9SC3Hvd/EQTEfai2rgP57pcePUF0o6MuI/wb5aB7lRhJqp\n\t5YBw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=SN+LY2EFjP/eeAJLJR5fexJVRayh51QfSRIHCIc3/0I=;\n\tb=W24zcCz0C1xQR5veGLclKo7i1/qUO36P/qY0xuGCK8ZuZ2MkJgTmSVAmrrZ4vpvu6b\n\tEwZi8hvaVPp/ICqVV7Mfow4PILj1e5nL5xpMy+i5W4SVENsrhWzy4ydRIW+vEnPqUM7S\n\tS1o4UTCHgSpza56z1b/PmqEMbacDB2Rr6LZFwSv7hXc4B9+rEXdneo5UQ5X64Ckp1zaa\n\t+8ejbgVFEtqebk5A2EA4d3vEo+17uG+TqjU9fbV5vd2GQbXqjZ2jAZhQcDUMmrxZmy8W\n\tyqhHQ0MQpy3+D7XaKBZ3SJD8rIwKQg2YH4fB8hwfXXI0ul2H8u/beI14ZhDKK57omuFa\n\t9UzQ==",
        "X-Gm-Message-State": "AKS2vOyOrAszGqI3rW089NHTaTRRK0WSi9jgMUxFPjZTLo1ErGoJBh5M\n\tecOukcItOipeFdrPde0=",
        "X-Received": "by 10.223.152.196 with SMTP id w62mr213568wrb.118.1497440974974; \n\tWed, 14 Jun 2017 04:49:34 -0700 (PDT)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org",
        "Date": "Wed, 14 Jun 2017 13:49:15 +0200",
        "Message-Id": "<37ec2564e00fa96d8be9455949f799b179272093.1497439616.git.adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<cover.1497439616.git.adrien.mazarguil@6wind.com>",
        "References": "<cover.1497439616.git.adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 5/7] net/mlx5: fix Rx interrupts support checks",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Not exposing Rx interrupts callbacks when this feature is unsupported is\nless intrusive than having two different versions for these functions.\n\nFixes: 3c7d44af252a (\"net/mlx5: support user space Rx interrupt event\")\n\nCc: stable@dpdk.org\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5.c      |  2 ++\n drivers/net/mlx5/mlx5_rxq.c  | 16 ++++------------\n drivers/net/mlx5/mlx5_rxtx.h |  2 ++\n 3 files changed, 8 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex bcb2c1b..49d4dba 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -246,8 +246,10 @@ static const struct eth_dev_ops mlx5_dev_ops = {\n \t.filter_ctrl = mlx5_dev_filter_ctrl,\n \t.rx_descriptor_status = mlx5_rx_descriptor_status,\n \t.tx_descriptor_status = mlx5_tx_descriptor_status,\n+#ifdef HAVE_UPDATE_CQ_CI\n \t.rx_queue_intr_enable = mlx5_rx_intr_enable,\n \t.rx_queue_intr_disable = mlx5_rx_intr_disable,\n+#endif\n };\n \n static struct {\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 5421d1f..fa350bf 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1419,6 +1419,8 @@ priv_destroy_intr_vec(struct priv *priv)\n \trte_free(intr_handle->intr_vec);\n }\n \n+#ifdef HAVE_UPDATE_CQ_CI\n+\n /**\n  * DPDK callback for rx queue interrupt enable.\n  *\n@@ -1433,7 +1435,6 @@ priv_destroy_intr_vec(struct priv *priv)\n int\n mlx5_rx_intr_enable(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n {\n-#ifdef HAVE_UPDATE_CQ_CI\n \tstruct priv *priv = mlx5_get_priv(dev);\n \tstruct rxq *rxq = (*priv->rxqs)[rx_queue_id];\n \tstruct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);\n@@ -1443,11 +1444,6 @@ mlx5_rx_intr_enable(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \n \tibv_mlx5_exp_update_cq_ci(cq, ci);\n \tret = ibv_req_notify_cq(cq, 0);\n-#else\n-\tint ret = -1;\n-\t(void)dev;\n-\t(void)rx_queue_id;\n-#endif\n \tif (ret)\n \t\tWARN(\"unable to arm interrupt on rx queue %d\", rx_queue_id);\n \treturn ret;\n@@ -1467,7 +1463,6 @@ mlx5_rx_intr_enable(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n int\n mlx5_rx_intr_disable(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n {\n-#ifdef HAVE_UPDATE_CQ_CI\n \tstruct priv *priv = mlx5_get_priv(dev);\n \tstruct rxq *rxq = (*priv->rxqs)[rx_queue_id];\n \tstruct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);\n@@ -1481,13 +1476,10 @@ mlx5_rx_intr_disable(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\tret = -1;\n \telse\n \t\tibv_ack_cq_events(cq, 1);\n-#else\n-\tint ret = -1;\n-\t(void)dev;\n-\t(void)rx_queue_id;\n-#endif\n \tif (ret)\n \t\tWARN(\"unable to disable interrupt on rx queue %d\",\n \t\t     rx_queue_id);\n \treturn ret;\n }\n+\n+#endif /* HAVE_UPDATE_CQ_CI */\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex cd79b5d..1a3ede4 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -311,8 +311,10 @@ int priv_intr_efd_enable(struct priv *priv);\n void priv_intr_efd_disable(struct priv *priv);\n int priv_create_intr_vec(struct priv *priv);\n void priv_destroy_intr_vec(struct priv *priv);\n+#ifdef HAVE_UPDATE_CQ_CI\n int mlx5_rx_intr_enable(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n int mlx5_rx_intr_disable(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n+#endif /* HAVE_UPDATE_CQ_CI */\n \n /* mlx5_txq.c */\n \n",
    "prefixes": [
        "dpdk-dev",
        "5/7"
    ]
}