Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 252,
    "url": "https://patches.dpdk.org/api/patches/252/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1409154628-30825-2-git-send-email-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1409154628-30825-2-git-send-email-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1409154628-30825-2-git-send-email-bruce.richardson@intel.com",
    "date": "2014-08-27T15:50:23",
    "name": "[dpdk-dev,1/6] ixgbe: put only non-zero initializer in definition",
    "commit_ref": "",
    "pull_url": "",
    "state": "superseded",
    "archived": true,
    "hash": "730d1d353c979b7164b21d276abc8d5d4b2635fb",
    "submitter": {
        "id": 20,
        "url": "https://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1409154628-30825-2-git-send-email-bruce.richardson@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/252/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/252/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<bricha3@ecsmtp.ir.intel.com>",
        "Received": [
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\r\n\tby dpdk.org (Postfix) with ESMTP id 6F44BB379\r\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 17:46:42 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\r\n\tby fmsmga101.fm.intel.com with ESMTP; 27 Aug 2014 08:50:31 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\r\n\tby fmsmga002.fm.intel.com with ESMTP; 27 Aug 2014 08:50:29 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\r\n\t[10.237.217.46])\r\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\r\n\ts7RFoSfX026035; Wed, 27 Aug 2014 16:50:29 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\r\n\tby sivswdev02.ir.intel.com with ESMTP id s7RFoSuh031296;\r\n\tWed, 27 Aug 2014 16:50:28 +0100",
            "(from bricha3@localhost)\r\n\tby sivswdev02.ir.intel.com with  id s7RFoSTJ031292;\r\n\tWed, 27 Aug 2014 16:50:28 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.04,412,1406617200\"; d=\"scan'208\";a=\"590649274\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 27 Aug 2014 16:50:23 +0100",
        "Message-Id": "<1409154628-30825-2-git-send-email-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "In-Reply-To": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>",
        "References": "<1409154628-30825-1-git-send-email-bruce.richardson@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 1/6] ixgbe: put only non-zero initializer in\r\n\tdefinition",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-List-Received-Date": "Wed, 27 Aug 2014 15:46:42 -0000"
    },
    "content": "Since all unspecified fields in an initializer are assumed to be zero we\ncan simplify the empty mbuf definition in the vector driver to only use\nthe fields that are non-zero, i.e. just nb_segs = 1. This makes things\nshorter and means that the structure doesn't need as many updates for\nother fields being renamed or moved.\n\nThe variable itself is never modified and only used by a single function\nso it can be made const and local to the using function.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 29 +++++------------------------\n 1 file changed, 5 insertions(+), 24 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\r\nindex 92e07de..56dce23 100644\r\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\r\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\r\n@@ -44,33 +44,14 @@\r\n #pragma GCC diagnostic ignored \"-Wcast-qual\"\r\n #endif\r\n \r\n-static struct rte_mbuf mb_def = {\r\n-\r\n-\t.ol_flags = 0,\r\n-\t{\r\n-\t\t.pkt = {\r\n-\t\t\t.data_len = 0,\r\n-\t\t\t.pkt_len = 0,\r\n-\r\n-\t\t\t.vlan_macip = {\r\n-\t\t\t\t.data = 0,\r\n-\t\t\t},\r\n-\t\t\t.hash = {\r\n-\t\t\t\t.rss = 0,\r\n-\t\t\t},\r\n-\r\n-\t\t\t.nb_segs = 1,\r\n-\t\t\t.in_port = 0,\r\n-\r\n-\t\t\t.next = NULL,\r\n-\t\t\t.data = NULL,\r\n-\t\t},\r\n-\t},\r\n-};\r\n-\r\n static inline void\r\n ixgbe_rxq_rearm(struct igb_rx_queue *rxq)\r\n {\r\n+\tstatic const struct rte_mbuf mb_def = {\r\n+\t\t.pkt = {\r\n+\t\t\t.nb_segs = 1,\r\n+\t\t},\r\n+\t};\r\n \tint i;\r\n \tuint16_t rx_id;\r\n \tvolatile union ixgbe_adv_rx_desc *rxdp;\r\n",
    "prefixes": [
        "dpdk-dev",
        "1/6"
    ]
}