List comments

GET /api/patches/251/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 511,
        "web_url": "https://patches.dpdk.org/comment/511/",
        "msgid": "<8438692.KHYKcsiDRz@xps13>",
        "date": "2014-08-27T14:35:37",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "Hi Jingjing,\n\n2014-08-27 10:13, Jingjing Wu:\n> add structure definition to construct programming packet.\n\nWhat is a \"programming packet\"?\n\n> +#ifdef RTE_LIBRTE_I40E_PMD\n> +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> +\t\t\t\" flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)\"\n> +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> +\t\t\t\"    Add/Del a IP type flow director filter for i40e NIC.\\n\\n\"\n> +\n> +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> +\t\t\t\" flow (udp4|tcp4|udp6|tcp6)\"\n> +\t\t\t\" src (src_ip_address) (src_port)\"\n> +\t\t\t\" dst (dst_ip_address) (dst_port)\"\n> +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> +\t\t\t\"    Add/Del a UDP/TCP type flow director filter for i40e NIC.\\n\\n\"\n> +\n> +\t\t\t\"i40e_flush_flow_diretor (port_id)\\n\"\n> +\t\t\t\"    Flush all flow director entries of a device on i40e NIC.\\n\\n\"\n> +#endif /* RTE_LIBRTE_I40E_PMD */\n\nI'd really like to stop seeing this kind of thing.\nWe cannot add some ifdef for each PMD in generic code.\n\nI stopped reading after that.\n\nSorry, I don't want to be rude but my feeling is that adding such feature\nwith global picture in mind is not easy. I know you want to offer all i40e\ncapabilities but you should think at future evolutions and how other drivers\nwill be integrated with yours.\n\nThanks",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=waXkh/K+JEAYDQmG98yrV0yG4PxaV3j6C5SnJ1mYvYU=;\n\tb=DwSmt7/P3qXWgIQE1LFkXac7FdnD5SBkALt7FzpX/AX8I8P3k2AfcHvQQsZhC9KV9p\n\t39cPUgQX7QY1QC/brH4nWHkLDZ+79L3BK1XB3CVf1jiaQWqHs0CZiVX4YzrSzIqeDYTR\n\tfcKmF9EB885cDAfms4YnBp+MIksZ58eUzvmWOxNsRSiEimZeLjlek/bY3NUJl6DIowaq\n\tjyBgIjSHgC7ekByQ9XdVeqnUKL/mSCZVKYEKxS+k0SGRXg/RQOXC6dRj2uiC34BwnUey\n\twUKNNx+sCs9we7wJoUtC0mSOXuOutlpIO2fzr6WzE385hNS75mcAxUyF8jMkOdeoNZtn\n\tzwbA==",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Wed, 27 Aug 2014 16:35:37 +0200",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<1409105634-29980-8-git-send-email-jingjing.wu@intel.com>",
            "In-Reply-To": "<1409105634-29980-8-git-send-email-jingjing.wu@intel.com>",
            "X-Gm-Message-State": "ALoCoQlrbOj8juRqbiLACPFa6cQyT/lzFnCB1VhaiyuPPGGwP+5ipIm/wcofyQn+0/ToM52NdZLt",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "To": "Jingjing Wu <jingjing.wu@intel.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "MIME-Version": "1.0",
            "Received": [
                "from mail-wi0-f178.google.com (mail-wi0-f178.google.com\n\t[209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 431386A98\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 16:31:39 +0200 (CEST)",
                "by mail-wi0-f178.google.com with SMTP id hi2so535377wib.5\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 07:35:42 -0700 (PDT)",
                "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tbt9sm1474044wjc.44.2014.08.27.07.35.41 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Aug 2014 07:35:41 -0700 (PDT)"
            ],
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Message-ID": "<8438692.KHYKcsiDRz@xps13>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Transfer-Encoding": "7Bit",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Wed, 27 Aug 2014 14:31:39 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "Organization": "6WIND",
            "X-Received": "by 10.194.179.73 with SMTP id de9mr23618787wjc.87.1409150142556; \n\tWed, 27 Aug 2014 07:35:42 -0700 (PDT)",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 524,
        "web_url": "https://patches.dpdk.org/comment/524/",
        "msgid": "<53FE0D5C.8070102@intel.com>",
        "date": "2014-08-27T16:54:52",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
        "submitter": {
            "id": 28,
            "url": "https://patches.dpdk.org/api/people/28/",
            "name": "Venkatesan, Venky",
            "email": "venky.venkatesan@intel.com"
        },
        "content": "On 8/27/2014 7:35 AM, Thomas Monjalon wrote:\n> Hi Jingjing,\n>\n> 2014-08-27 10:13, Jingjing Wu:\n>> add structure definition to construct programming packet.\n> What is a \"programming packet\"?\n>\n>> +#ifdef RTE_LIBRTE_I40E_PMD\n>> +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n>> +\t\t\t\" flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)\"\n>> +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n>> +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n>> +\t\t\t\"    Add/Del a IP type flow director filter for i40e NIC.\\n\\n\"\n>> +\n>> +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n>> +\t\t\t\" flow (udp4|tcp4|udp6|tcp6)\"\n>> +\t\t\t\" src (src_ip_address) (src_port)\"\n>> +\t\t\t\" dst (dst_ip_address) (dst_port)\"\n>> +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n>> +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n>> +\t\t\t\"    Add/Del a UDP/TCP type flow director filter for i40e NIC.\\n\\n\"\n>> +\n>> +\t\t\t\"i40e_flush_flow_diretor (port_id)\\n\"\n>> +\t\t\t\"    Flush all flow director entries of a device on i40e NIC.\\n\\n\"\n>> +#endif /* RTE_LIBRTE_I40E_PMD */\n> I'd really like to stop seeing this kind of thing.\n> We cannot add some ifdef for each PMD in generic code.\n>\n> I stopped reading after that.\n>\n> Sorry, I don't want to be rude but my feeling is that adding such feature\n> with global picture in mind is not easy. I know you want to offer all i40e\n> capabilities but you should think at future evolutions and how other drivers\n> will be integrated with yours.\n>\n> Thanks\nSecond that. Any PMD-specifics need to be contained within the PMD \nitself, and not in generic code. Please rework this.\n-Venky",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Transfer-Encoding": "7bit",
            "Content-Type": "text/plain; charset=ISO-8859-1; format=flowed",
            "Date": "Wed, 27 Aug 2014 09:54:52 -0700",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<8438692.KHYKcsiDRz@xps13>",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<1409105634-29980-8-git-send-email-jingjing.wu@intel.com>\n\t<8438692.KHYKcsiDRz@xps13>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "To": "dev@dpdk.org",
            "User-Agent": "Mozilla/5.0 (Windows NT 6.2; WOW64;\n\trv:24.0) Gecko/20100101 Thunderbird/24.6.0",
            "MIME-Version": "1.0",
            "Received": [
                "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 7B65AB361\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 18:50:50 +0200 (CEST)",
                "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 27 Aug 2014 09:46:52 -0700",
                "from nvenkate-mobl1.amr.corp.intel.com (HELO [10.24.25.27])\n\t([10.24.25.27])\n\tby fmsmga001.fm.intel.com with ESMTP; 27 Aug 2014 09:54:52 -0700"
            ],
            "From": "\"Venkatesan, Venky\" <venky.venkatesan@intel.com>",
            "Message-ID": "<53FE0D5C.8070102@intel.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "X-List-Received-Date": "Wed, 27 Aug 2014 16:50:51 -0000",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<venky.venkatesan@intel.com>",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,412,1406617200\"; d=\"scan'208\";a=\"582460994\"",
            "X-ExtLoop1": "1",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 536,
        "web_url": "https://patches.dpdk.org/comment/536/",
        "msgid": "<9BB6961774997848B5B42BEC655768F8ADBF4E@SHSMSX104.ccr.corp.intel.com>",
        "date": "2014-08-28T03:51:29",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
        "submitter": {
            "id": 47,
            "url": "https://patches.dpdk.org/api/people/47/",
            "name": "Wu, Jingjing",
            "email": "jingjing.wu@intel.com"
        },
        "content": "Hi, Thomas\n\n> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Wednesday, August 27, 2014 10:36 PM\n> To: Wu, Jingjing\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for\n> i40e flow director support\n> \n> Hi Jingjing,\n> \n> 2014-08-27 10:13, Jingjing Wu:\n> > add structure definition to construct programming packet.\n> \n> What is a \"programming packet\"?\nFor Fortville, we need to set a flow director filter by sending a packet which contains the input set values through the queue belonging to flow director.\n> \n> > +#ifdef RTE_LIBRTE_I40E_PMD\n> > +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> > +\t\t\t\" flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)\"\n> > +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> > +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> > +\t\t\t\"    Add/Del a IP type flow director filter for i40e NIC.\\n\\n\"\n> > +\n> > +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> > +\t\t\t\" flow (udp4|tcp4|udp6|tcp6)\"\n> > +\t\t\t\" src (src_ip_address) (src_port)\"\n> > +\t\t\t\" dst (dst_ip_address) (dst_port)\"\n> > +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> > +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> > +\t\t\t\"    Add/Del a UDP/TCP type flow director filter for i40e NIC.\\n\\n\"\n> > +\n> > +\t\t\t\"i40e_flush_flow_diretor (port_id)\\n\"\n> > +\t\t\t\"    Flush all flow director entries of a device on i40e NIC.\\n\\n\"\n> > +#endif /* RTE_LIBRTE_I40E_PMD */\n> \n> I'd really like to stop seeing this kind of thing.\n> We cannot add some ifdef for each PMD in generic code.\n> \n> I stopped reading after that.\n> \n> Sorry, I don't want to be rude but my feeling is that adding such feature\n> with global picture in mind is not easy. I know you want to offer all i40e\n> capabilities but you should think at future evolutions and how other drivers\n> will be integrated with yours.\n> \n\nSorry to make you feel uncomfortable for such code. Just as you say, I want to offer more i40e capabilities. I will rework code in testpmd. \n\n> Thanks\n> --\n> Thomas",
        "headers": {
            "Thread-Index": "AQHPwZyuUuNR6DPrqUGFqFfP1yAUpJvj/v+AgAFhSpA=",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "X-MS-Has-Attach": "",
            "Date": "Thu, 28 Aug 2014 03:51:29 +0000",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<8438692.KHYKcsiDRz@xps13>",
            "Message-ID": "<9BB6961774997848B5B42BEC655768F8ADBF4E@SHSMSX104.ccr.corp.intel.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Accept-Language": "en-US",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<1409105634-29980-8-git-send-email-jingjing.wu@intel.com>\n\t<8438692.KHYKcsiDRz@xps13>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<jingjing.wu@intel.com>",
            "x-originating-ip": "[10.239.127.40]",
            "MIME-Version": "1.0",
            "Received": [
                "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 923173975\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 05:47:26 +0200 (CEST)",
                "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 27 Aug 2014 20:51:32 -0700",
                "from fmsmsx106.amr.corp.intel.com ([10.18.124.204])\n\tby FMSMGA003.fm.intel.com with ESMTP; 27 Aug 2014 20:47:18 -0700",
                "from fmsmsx118.amr.corp.intel.com (10.18.116.18) by\n\tFMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 27 Aug 2014 20:51:32 -0700",
                "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n\tfmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 27 Aug 2014 20:51:32 -0700",
                "from shsmsx104.ccr.corp.intel.com ([169.254.5.17]) by\n\tSHSMSX151.ccr.corp.intel.com ([169.254.3.174]) with mapi id\n\t14.03.0195.001; Thu, 28 Aug 2014 11:51:30 +0800"
            ],
            "From": "\"Wu, Jingjing\" <jingjing.wu@intel.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Transfer-Encoding": "quoted-printable",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Thu, 28 Aug 2014 03:47:27 -0000",
            "To": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "X-Mailman-Version": "2.1.15",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"377963622\""
        }
    },
    {
        "id": 539,
        "web_url": "https://patches.dpdk.org/comment/539/",
        "msgid": "<6406194.6E43HquPHH@xps13>",
        "date": "2014-08-28T08:50:37",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-08-28 03:51, Wu, Jingjing:\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > 2014-08-27 10:13, Jingjing Wu:\n> > > add structure definition to construct programming packet.\n> > \n> > What is a \"programming packet\"?\n> \n> For Fortville, we need to set a flow director filter by sending a\n> packet which contains the input set values through the queue\n> belonging to flow director.\n\nOK. To be more clear, some detailed explanations are required in the\ncommit log. Please try to be very descriptive.\nYou can think comments like this:\n- if comments are absolutely needed to understand the code, you should\nput comments in the code (or write the code differently)\n- if some feature context can help for the review, you should explain\ncontext and design in the commit log\n\n> > > +#ifdef RTE_LIBRTE_I40E_PMD\n> > > +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> > > +\t\t\t\" flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)\"\n> > > +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> > > +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> > > +\t\t\t\"    Add/Del a IP type flow director filter for i40e NIC.\\n\\n\"\n> > > +\n> > > +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> > > +\t\t\t\" flow (udp4|tcp4|udp6|tcp6)\"\n> > > +\t\t\t\" src (src_ip_address) (src_port)\"\n> > > +\t\t\t\" dst (dst_ip_address) (dst_port)\"\n> > > +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> > > +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> > > +\t\t\t\"    Add/Del a UDP/TCP type flow director filter for i40e NIC.\\n\\n\"\n> > > +\n> > > +\t\t\t\"i40e_flush_flow_diretor (port_id)\\n\"\n> > > +\t\t\t\"    Flush all flow director entries of a device on i40e NIC.\\n\\n\"\n> > > +#endif /* RTE_LIBRTE_I40E_PMD */\n> > \n> > I'd really like to stop seeing this kind of thing.\n> > We cannot add some ifdef for each PMD in generic code.\n> > \n> > I stopped reading after that.\n> > \n> > Sorry, I don't want to be rude but my feeling is that adding such feature\n> > with global picture in mind is not easy. I know you want to offer all i40e\n> > capabilities but you should think at future evolutions and how other drivers\n> > will be integrated with yours.\n> > \n> \n> Sorry to make you feel uncomfortable for such code. Just as you say,\n> I want to offer more i40e capabilities. I will rework code in testpmd. \n\nThanks",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=Z4Kdwu+nRn1Doc7ybzi7vxPl1D3CS8XXwiyi229cl+M=;\n\tb=NG8+hH8o27WJp2jC5J+4qFVUjwNodvbexU3vg8n9NcEts86/+73J9F6dtayvGXhtuK\n\tf1bcCT4guOXa5Xj+3vVOHI+3p5t4YKY4lzkOl7PWIjW3elDxvbmuOX1yALV5cmsUiAgN\n\tYmNXYWAnorqT42QUk9CKY4onIbn2L/CCCkm+Ssbmt2O2//n2n9eo9hS6ax6O2DvqOPtH\n\tlTnuVqHSmrXj0jr9XM3iCMkS74TXIPEZrhfUX63onx4LWacnuBMFq3He7T6G+qWuS9I5\n\t6LJFFFP/2cE4NMeCLFH5zFUP15nrFW9Moikx8V21EGv4M8RnCrrFLsD2RZzOgkqSKgTP\n\tVWkQ==",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Thu, 28 Aug 2014 10:50:37 +0200",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<8438692.KHYKcsiDRz@xps13>\n\t<9BB6961774997848B5B42BEC655768F8ADBF4E@SHSMSX104.ccr.corp.intel.com>",
            "In-Reply-To": "<9BB6961774997848B5B42BEC655768F8ADBF4E@SHSMSX104.ccr.corp.intel.com>",
            "X-Gm-Message-State": "ALoCoQmYWBbSrdNCGWTKa+OEql06Fi9QURvw24PJVoaPuUkP6TEFbOtTDOPD2kATo6LdjZfEJwxe",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "To": "\"Wu, Jingjing\" <jingjing.wu@intel.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "MIME-Version": "1.0",
            "Received": [
                "from mail-wg0-f47.google.com (mail-wg0-f47.google.com\n\t[74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 22501682E\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 10:46:37 +0200 (CEST)",
                "by mail-wg0-f47.google.com with SMTP id z12so415802wgg.6\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 01:50:44 -0700 (PDT)",
                "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tpm6sm8099956wjb.36.2014.08.28.01.50.42 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 01:50:42 -0700 (PDT)"
            ],
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Message-ID": "<6406194.6E43HquPHH@xps13>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Transfer-Encoding": "7Bit",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Thu, 28 Aug 2014 08:46:37 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "Organization": "6WIND",
            "X-Received": "by 10.194.71.11 with SMTP id q11mr3147672wju.33.1409215843315;\n\tThu, 28 Aug 2014 01:50:43 -0700 (PDT)",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 541,
        "web_url": "https://patches.dpdk.org/comment/541/",
        "msgid": "<9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com>",
        "date": "2014-08-28T09:01:26",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
        "submitter": {
            "id": 47,
            "url": "https://patches.dpdk.org/api/people/47/",
            "name": "Wu, Jingjing",
            "email": "jingjing.wu@intel.com"
        },
        "content": "Hi, Thomas\n\nThanks for your tips.\n\nI have another question:\nIf we use the way 'rx_classification_filter_ctl' works, the specific structures defined in rte_i40e.h will be visible in user's application, such as testpmd.\nI know I shouldn't make commands linked with i40e like what I did before. But will the i40e specific structures become visible be acceptable?\n\n\n\n> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Thursday, August 28, 2014 4:51 PM\n> To: Wu, Jingjing\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for\n> i40e flow director support\n> \n> 2014-08-28 03:51, Wu, Jingjing:\n> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > > 2014-08-27 10:13, Jingjing Wu:\n> > > > add structure definition to construct programming packet.\n> > >\n> > > What is a \"programming packet\"?\n> >\n> > For Fortville, we need to set a flow director filter by sending a\n> > packet which contains the input set values through the queue\n> > belonging to flow director.\n> \n> OK. To be more clear, some detailed explanations are required in the\n> commit log. Please try to be very descriptive.\n> You can think comments like this:\n> - if comments are absolutely needed to understand the code, you should\n> put comments in the code (or write the code differently)\n> - if some feature context can help for the review, you should explain\n> context and design in the commit log\n> \n> > > > +#ifdef RTE_LIBRTE_I40E_PMD\n> > > > +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> > > > +\t\t\t\" flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)\"\n> > > > +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> > > > +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> > > > +\t\t\t\"    Add/Del a IP type flow director filter for i40e NIC.\\n\\n\"\n> > > > +\n> > > > +\t\t\t\"i40e_flow_director_filter (port_id) (add|del)\"\n> > > > +\t\t\t\" flow (udp4|tcp4|udp6|tcp6)\"\n> > > > +\t\t\t\" src (src_ip_address) (src_port)\"\n> > > > +\t\t\t\" dst (dst_ip_address) (dst_port)\"\n> > > > +\t\t\t\" flexwords (flexwords_value) (drop|fwd)\"\n> > > > +\t\t\t\" queue (queue_id) fd_id (fd_id_value)\\n\"\n> > > > +\t\t\t\"    Add/Del a UDP/TCP type flow director filter for i40e NIC.\\n\\n\"\n> > > > +\n> > > > +\t\t\t\"i40e_flush_flow_diretor (port_id)\\n\"\n> > > > +\t\t\t\"    Flush all flow director entries of a device on i40e NIC.\\n\\n\"\n> > > > +#endif /* RTE_LIBRTE_I40E_PMD */\n> > >\n> > > I'd really like to stop seeing this kind of thing.\n> > > We cannot add some ifdef for each PMD in generic code.\n> > >\n> > > I stopped reading after that.\n> > >\n> > > Sorry, I don't want to be rude but my feeling is that adding such feature\n> > > with global picture in mind is not easy. I know you want to offer all i40e\n> > > capabilities but you should think at future evolutions and how other drivers\n> > > will be integrated with yours.\n> > >\n> >\n> > Sorry to make you feel uncomfortable for such code. Just as you say,\n> > I want to offer more i40e capabilities. I will rework code in testpmd.\n> \n> Thanks\n> --\n> Thomas",
        "headers": {
            "Thread-Index": "AQHPwZyuUuNR6DPrqUGFqFfP1yAUpJvj/v+AgAFhSpD//9CngIAAh5tQ",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "X-MS-Has-Attach": "",
            "Date": "Thu, 28 Aug 2014 09:01:26 +0000",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<6406194.6E43HquPHH@xps13>",
            "Message-ID": "<9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Accept-Language": "en-US",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<8438692.KHYKcsiDRz@xps13>\n\t<9BB6961774997848B5B42BEC655768F8ADBF4E@SHSMSX104.ccr.corp.intel.com>\n\t<6406194.6E43HquPHH@xps13>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<jingjing.wu@intel.com>",
            "x-originating-ip": "[10.239.127.40]",
            "MIME-Version": "1.0",
            "Received": [
                "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id B2579B372\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 10:57:23 +0200 (CEST)",
                "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 28 Aug 2014 02:01:30 -0700",
                "from fmsmsx104.amr.corp.intel.com ([10.18.124.202])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Aug 2014 02:01:30 -0700",
                "from fmsmsx119.amr.corp.intel.com (10.19.9.28) by\n\tfmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 28 Aug 2014 02:01:29 -0700",
                "from shsmsx101.ccr.corp.intel.com (10.239.4.153) by\n\tFMSMSX119.amr.corp.intel.com (10.19.9.28) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Thu, 28 Aug 2014 02:01:29 -0700",
                "from shsmsx104.ccr.corp.intel.com ([169.254.5.17]) by\n\tSHSMSX101.ccr.corp.intel.com ([169.254.1.198]) with mapi id\n\t14.03.0195.001; Thu, 28 Aug 2014 17:01:27 +0800"
            ],
            "From": "\"Wu, Jingjing\" <jingjing.wu@intel.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Transfer-Encoding": "quoted-printable",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Thu, 28 Aug 2014 08:57:24 -0000",
            "To": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "X-Mailman-Version": "2.1.15",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,416,1406617200\"; d=\"scan'208\";a=\"594448886\""
        }
    },
    {
        "id": 545,
        "web_url": "https://patches.dpdk.org/comment/545/",
        "msgid": "<32773310.iMGaa2PpNO@xps13>",
        "date": "2014-08-28T11:00:33",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-08-28 09:01, Wu, Jingjing:\n> I have another question:\n> If we use the way 'rx_classification_filter_ctl' works, the specific\n> structures defined in rte_i40e.h will be visible in user's application,\n> such as testpmd.\n> I know I shouldn't make commands linked with i40e like what I did before.\n> But will the i40e specific structures become visible be acceptable?\n\nI think testpmd should be limited to generic API.\nSo it wouldn't be acceptable to be dependent of i40e files.\nBut having some specific i40e tests in examples or app/test is OK.",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=DbRyUfD5h/aQyn3IcCodZdz9U20z41JBGtJt6S0W97g=;\n\tb=KgthdCxp2iFsWeH7Vp0/pxaWj88h9lhKPx9sUz+K9HfYdCg0h9NoPWNfXy56lyw+Gp\n\tcK2CMoLH6OMfipX5pszBYYMOn3GgotP6cCAIrojb23tXoxKHdJplhNWfQuLMwWRcO7d1\n\tLjV2cDUtCELlO6cFpmbf2iCJYYpVZCLfOvEuR0DaOIJdziYYghHAG5an2t3H4C0dFOBs\n\tgPH28LXPTxuI2AUi8KWhOtSV8wK5gNAGinn8Ooit8906xIfTvAkXXcjthZ7M/J43qRde\n\tMHirKnkGvPMQ3Xtij/tcNqr4hAvC91K3zMGgiIZzFrDPZIaA4Dc/KVkiiWXl85ZMpl4r\n\t8Heg==",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Thu, 28 Aug 2014 13:00:33 +0200",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<6406194.6E43HquPHH@xps13>\n\t<9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com>",
            "In-Reply-To": "<9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com>",
            "X-Gm-Message-State": "ALoCoQkngxa+2G0IIaq+2P18NaHMtSnkPropzlmzt2cWeA+b8tZw4eVPOwn0WcGD3JLJMB3v5hr9",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "To": "\"Wu, Jingjing\" <jingjing.wu@intel.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "MIME-Version": "1.0",
            "Received": [
                "from mail-wg0-f46.google.com (mail-wg0-f46.google.com\n\t[74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 1DE865946\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 12:56:31 +0200 (CEST)",
                "by mail-wg0-f46.google.com with SMTP id x13so558849wgg.29\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 04:00:39 -0700 (PDT)",
                "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tl1sm13585033wia.8.2014.08.28.04.00.38 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 04:00:38 -0700 (PDT)"
            ],
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Message-ID": "<32773310.iMGaa2PpNO@xps13>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Transfer-Encoding": "7Bit",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Thu, 28 Aug 2014 10:56:31 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "Organization": "6WIND",
            "X-Received": "by 10.180.186.98 with SMTP id fj2mr5740331wic.32.1409223639287; \n\tThu, 28 Aug 2014 04:00:39 -0700 (PDT)",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 547,
        "web_url": "https://patches.dpdk.org/comment/547/",
        "msgid": "<2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com>",
        "date": "2014-08-28T11:30:14",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and\n\tconfig\tfunctions for i40e flow director support",
        "submitter": {
            "id": 33,
            "url": "https://patches.dpdk.org/api/people/33/",
            "name": "Konstantin Ananyev",
            "email": "konstantin.ananyev@intel.com"
        },
        "content": "> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon\n> Sent: Thursday, August 28, 2014 12:01 PM\n> To: Wu, Jingjing\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support\n> \n> 2014-08-28 09:01, Wu, Jingjing:\n> > I have another question:\n> > If we use the way 'rx_classification_filter_ctl' works, the specific\n> > structures defined in rte_i40e.h will be visible in user's application,\n> > such as testpmd.\n> > I know I shouldn't make commands linked with i40e like what I did before.\n> > But will the i40e specific structures become visible be acceptable?\n> \n> I think testpmd should be limited to generic API.\n> So it wouldn't be acceptable to be dependent of i40e files.\n> But having some specific i40e tests in examples or app/test is OK.\n> \n\nProbably I didn't get you right:\nAre you suggesting to have a new clone of testpmd for any new device we are going to support?\nThat seems like too much hassle to me.\nPlus what to do if someone would like to test configuration with two different devices involved: ixgbe and i40e for example? \nI suggest we keep one testpmd for all devices we support.\nOf course we'll probably have to make some rework to avoid if (strncmp(drv_name, \"xxx\") spread all over it.\nWe need to find some better way to discover/setup HW specific features.\nThanks\nKonstantin",
        "headers": {
            "Thread-Index": "AQHPwq9v/yc0emyiC0ePLIgHQ1gySZvl31gw",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "X-MS-Has-Attach": "",
            "Date": "Thu, 28 Aug 2014 11:30:14 +0000",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<32773310.iMGaa2PpNO@xps13>",
            "Message-ID": "<2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Accept-Language": "en-IE, en-US",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<6406194.6E43HquPHH@xps13>\n\t<9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com>\n\t<32773310.iMGaa2PpNO@xps13>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<konstantin.ananyev@intel.com>",
            "x-originating-ip": "[163.33.239.180]",
            "MIME-Version": "1.0",
            "Received": [
                "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 47B43B379\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 13:26:14 +0200 (CEST)",
                "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 28 Aug 2014 04:22:18 -0700",
                "from irsmsx101.ger.corp.intel.com ([163.33.3.153])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 Aug 2014 04:30:15 -0700",
                "from irsmsx154.ger.corp.intel.com (163.33.192.96) by\n\tIRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 28 Aug 2014 12:30:15 +0100",
                "from irsmsx105.ger.corp.intel.com ([169.254.7.158]) by\n\tIRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id\n\t14.03.0195.001; Thu, 28 Aug 2014 12:30:15 +0100"
            ],
            "From": "\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Transfer-Encoding": "quoted-printable",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and\n\tconfig\tfunctions for i40e flow director support",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Thu, 28 Aug 2014 11:26:14 -0000",
            "To": "Thomas Monjalon <thomas.monjalon@6wind.com>, \"Wu, Jingjing\"\n\t<jingjing.wu@intel.com>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "X-Mailman-Version": "2.1.15",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,417,1406617200\"; d=\"scan'208\";a=\"582840643\""
        }
    },
    {
        "id": 549,
        "web_url": "https://patches.dpdk.org/comment/549/",
        "msgid": "<3064205.9pGcLqH4SI@xps13>",
        "date": "2014-08-28T12:02:06",
        "subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-08-28 11:30, Ananyev, Konstantin:\n> From: Thomas Monjalon\n> > 2014-08-28 09:01, Wu, Jingjing:\n> > > I have another question:\n> > > If we use the way 'rx_classification_filter_ctl' works, the specific\n> > > structures defined in rte_i40e.h will be visible in user's application,\n> > > such as testpmd.\n> > > I know I shouldn't make commands linked with i40e like what I did before.\n> > > But will the i40e specific structures become visible be acceptable?\n> > \n> > I think testpmd should be limited to generic API.\n> > So it wouldn't be acceptable to be dependent of i40e files.\n> > But having some specific i40e tests in examples or app/test is OK.\n> > \n> \n> Probably I didn't get you right:\n\nIndeed ;)\n\n> Are you suggesting to have a new clone of testpmd for any new device\n> we are going to support?\n\nNo. I say there shouldn't be any PMD dependency on testpmd.\nIt means we should use only generic API.\n\n> That seems like too much hassle to me.\n> Plus what to do if someone would like to test configuration with two\n> different devices involved: ixgbe and i40e for example?\n\nixgbe and i40e features should use the same generic API for flow director.\n\n> I suggest we keep one testpmd for all devices we support.\n> Of course we'll probably have to make some rework to avoid\n> if (strncmp(drv_name, \"xxx\") spread all over it.\n> We need to find some better way to discover/setup HW specific features.\n\nAgreed",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=qrVG/uknP1eE8SxMp//0BtqDs0Yi5yJ1W+GwIVWS2/c=;\n\tb=XooDyJn3ZzgIn3uM3JK0zJUH7ASZhotOftL2645M4CHx//cyTwG/hojQHWuqSLCPSU\n\tveLdhTTxOo8q8gMWjmyjcKvSCxBvWm/r0ixvw8QI8n87UdVrqtyuRTO23PM7F8st2FtJ\n\tRh49f+rmaKYUxIm+DReRM+ytLY9jHbTdxjdIJxWairYS41L8C0kIwLUqBUGUWhNnyejE\n\t4zizWw+PEwFW5wpz16l2l19oTlp8C7Ojnp0kp4B1Co2uy+zjL3somgZM4Xb/jBPDdXCS\n\t12gp5effUGPz/MbclPsfPLghAXhZaJfL5GgtLIBXiPUNfD5xpzjklltPoUwFgfymkFG0\n\tXkJA==",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Thu, 28 Aug 2014 14:02:06 +0200",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1409105634-29980-1-git-send-email-jingjing.wu@intel.com>\n\t<32773310.iMGaa2PpNO@xps13>\n\t<2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com>",
            "In-Reply-To": "<2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com>",
            "X-Gm-Message-State": "ALoCoQlJZfKtH8/x06GK1c/lCNFRaSJC7eC9rQAuXIUFAVklLonxPu0N/hngZxXPxlLHgriMXJD6",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "To": "\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "MIME-Version": "1.0",
            "Received": [
                "from mail-wg0-f48.google.com (mail-wg0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 041E03975\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 13:58:06 +0200 (CEST)",
                "by mail-wg0-f48.google.com with SMTP id n12so628122wgh.19\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 05:02:12 -0700 (PDT)",
                "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tu5sm34874379wia.17.2014.08.28.05.02.11 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 05:02:11 -0700 (PDT)"
            ],
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Message-ID": "<3064205.9pGcLqH4SI@xps13>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Transfer-Encoding": "7Bit",
            "Subject": "Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config\n\tfunctions for i40e flow director support",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Thu, 28 Aug 2014 11:58:06 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "Organization": "6WIND",
            "X-Received": "by 10.194.89.200 with SMTP id bq8mr4730253wjb.52.1409227332456; \n\tThu, 28 Aug 2014 05:02:12 -0700 (PDT)",
            "X-Mailman-Version": "2.1.15"
        }
    }
]