Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 25013,
    "url": "https://patches.dpdk.org/api/patches/25013/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1496338605-7338-2-git-send-email-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1496338605-7338-2-git-send-email-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1496338605-7338-2-git-send-email-qi.z.zhang@intel.com",
    "date": "2017-06-01T17:36:43",
    "name": "[dpdk-dev,v3,1/3] net/ixgbe: remove reduandent code",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "732c3ffb523410729d38324eacb294a2562c7c89",
    "submitter": {
        "id": 504,
        "url": "https://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1496338605-7338-2-git-send-email-qi.z.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/25013/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/25013/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C71D87CF5;\n\tFri,  2 Jun 2017 02:43:29 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 1AA4A7CE3\n\tfor <dev@dpdk.org>; Fri,  2 Jun 2017 02:43:25 +0200 (CEST)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jun 2017 17:43:25 -0700",
            "from zhangqi.sh.intel.com ([10.239.129.189])\n\tby orsmga004.jf.intel.com with ESMTP; 01 Jun 2017 17:43:24 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.39,282,1493708400\"; d=\"scan'208\";a=\"93818925\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "wenzhuo.lu@intel.com,\n\thelin.zhang@intel.com",
        "Cc": "dev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>",
        "Date": "Thu,  1 Jun 2017 13:36:43 -0400",
        "Message-Id": "<1496338605-7338-2-git-send-email-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1496338605-7338-1-git-send-email-qi.z.zhang@intel.com>",
        "References": "<1496259940-15547-1-git-send-email-qi.z.zhang@intel.com>\n\t<1496338605-7338-1-git-send-email-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 1/3] net/ixgbe: remove reduandent code",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Remove reduandent code.\nitem->type != RTE_FLOW_ITEM_TYPE_END already cover\nitem->type == RTE_FLOW_ITEM_TYPE_VLAN.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n\nv3:\n-fix comments.\n\n drivers/net/ixgbe/ixgbe_flow.c | 12 ++----------\n 1 file changed, 2 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c\nindex da7b1cc..60ca8d8 100644\n--- a/drivers/net/ixgbe/ixgbe_flow.c\n+++ b/drivers/net/ixgbe/ixgbe_flow.c\n@@ -1544,18 +1544,10 @@ ixgbe_parse_fdir_filter_normal(const struct rte_flow_attr *attr,\n \t\trule->mask.vlan_tci_mask &= rte_cpu_to_be_16(0xEFFF);\n \t\t/* More than one tags are not supported. */\n \n-\t\t/**\n-\t\t * Check if the next not void item is not vlan.\n-\t\t */\n+\t\t/* Next not void item must be END */\n \t\tindex++;\n \t\tNEXT_ITEM_OF_PATTERN(item, pattern, index);\n-\t\tif (item->type == RTE_FLOW_ITEM_TYPE_VLAN) {\n-\t\t\tmemset(rule, 0, sizeof(struct ixgbe_fdir_rule));\n-\t\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\titem, \"Not supported by fdir filter\");\n-\t\t\treturn -rte_errno;\n-\t\t} else if (item->type != RTE_FLOW_ITEM_TYPE_END) {\n+\t\tif (item->type != RTE_FLOW_ITEM_TYPE_END) {\n \t\t\tmemset(rule, 0, sizeof(struct ixgbe_fdir_rule));\n \t\t\trte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "1/3"
    ]
}