Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2497/?format=api
https://patches.dpdk.org/api/patches/2497/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1ED644BD7E0A5F4091CF203DAFB8E4CC01DB63D6@SHSMSX101.ccr.corp.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01DB63D6@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1ED644BD7E0A5F4091CF203DAFB8E4CC01DB63D6@SHSMSX101.ccr.corp.intel.com", "date": "2015-01-23T11:03:00", "name": "[dpdk-dev,RFC,09/16] testpmd: move csum_show in a function", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "d48ab4ec9751157843b9065493e4c5ec6addaedf", "submitter": { "id": 52, "url": "https://patches.dpdk.org/api/people/52/?format=api", "name": "Jijiang Liu", "email": "jijiang.liu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1ED644BD7E0A5F4091CF203DAFB8E4CC01DB63D6@SHSMSX101.ccr.corp.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2497/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2497/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B59A55AF7;\n\tFri, 23 Jan 2015 12:03:10 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id EE6EA5AF5\n\tfor <dev@dpdk.org>; Fri, 23 Jan 2015 12:03:07 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 23 Jan 2015 03:00:03 -0800", "from pgsmsx103.gar.corp.intel.com ([10.221.44.82])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Jan 2015 03:03:05 -0800", "from shsmsx104.ccr.corp.intel.com (10.239.110.15) by\n\tPGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Fri, 23 Jan 2015 19:03:03 +0800", "from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by\n\tSHSMSX104.ccr.corp.intel.com ([169.254.5.231]) with mapi id\n\t14.03.0195.001; Fri, 23 Jan 2015 19:03:00 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,453,1418112000\"; d=\"scan'208\";a=\"674725178\"", "From": "\"Liu, Jijiang\" <jijiang.liu@intel.com>", "To": "Olivier Matz <olivier.matz@6wind.com>", "Thread-Topic": "[RFC 09/16] testpmd: move csum_show in a function", "Thread-Index": "AQHQNdMrYwHJb32R/kGd3AsU3lWz15zNi5iw", "Date": "Fri, 23 Jan 2015 11:03:00 +0000", "Message-ID": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01DB63D6@SHSMSX101.ccr.corp.intel.com>", "References": "<1421883395-27235-1-git-send-email-olivier.matz@6wind.com>\n\t<1421883395-27235-10-git-send-email-olivier.matz@6wind.com>", "In-Reply-To": "<1421883395-27235-10-git-send-email-olivier.matz@6wind.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [RFC 09/16] testpmd: move csum_show in a function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi,\n\n-----Original Message-----\nFrom: Olivier Matz [mailto:olivier.matz@6wind.com] \nSent: Thursday, January 22, 2015 7:36 AM\nTo: dev@dpdk.org\nCc: olivier.matz@6wind.com; Ananyev, Konstantin; Liu, Jijiang\nSubject: [RFC 09/16] testpmd: move csum_show in a function\n\nNo functional changes in this commit, we just move the code that displays the csum forward engine configuration in a function.\n\nThis makes the next commit easier to read as it will also use this function.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n app/test-pmd/cmdline.c | 82 +++++++++++++++++++++++++++-----------------------\n 1 file changed, 45 insertions(+), 37 deletions(-)\n\n \t\tprintf(\"invalid port %d\\n\", res->port_id); @@ -2903,41 +2945,7 @@ cmd_csum_parsed(void *parsed_result,\n \t\telse\n \t\t\tports[res->port_id].tx_ol_flags &= (~mask);\n \t}\n-\n-\tol_flags = ports[res->port_id].tx_ol_flags;\n-\tprintf(\"IP checksum offload is %s\\n\",\n-\t\t(ol_flags & TESTPMD_TX_OFFLOAD_IP_CKSUM) ? \"hw\" : \"sw\");\n-\tprintf(\"UDP checksum offload is %s\\n\",\n-\t\t(ol_flags & TESTPMD_TX_OFFLOAD_UDP_CKSUM) ? \"hw\" : \"sw\");\n-\tprintf(\"TCP checksum offload is %s\\n\",\n-\t\t(ol_flags & TESTPMD_TX_OFFLOAD_TCP_CKSUM) ? \"hw\" : \"sw\");\n-\tprintf(\"SCTP checksum offload is %s\\n\",\n-\t\t(ol_flags & TESTPMD_TX_OFFLOAD_SCTP_CKSUM) ? \"hw\" : \"sw\");\n-\tprintf(\"VxLAN checksum offload is %s\\n\",\n-\t\t(ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) ? \"hw\" : \"sw\");\n-\n-\t/* display warnings if configuration is not supported by the NIC */\n-\trte_eth_dev_info_get(res->port_id, &dev_info);\n-\tif ((ol_flags & TESTPMD_TX_OFFLOAD_IP_CKSUM) &&\n-\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IPV4_CKSUM) == 0) {\n-\t\tprintf(\"Warning: hardware IP checksum enabled but not \"\n-\t\t\t\"supported by port %d\\n\", res->port_id);\n-\t}\n-\tif ((ol_flags & TESTPMD_TX_OFFLOAD_UDP_CKSUM) &&\n-\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_CKSUM) == 0) {\n-\t\tprintf(\"Warning: hardware UDP checksum enabled but not \"\n-\t\t\t\"supported by port %d\\n\", res->port_id);\n-\t}\n-\tif ((ol_flags & TESTPMD_TX_OFFLOAD_TCP_CKSUM) &&\n-\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_CKSUM) == 0) {\n-\t\tprintf(\"Warning: hardware TCP checksum enabled but not \"\n-\t\t\t\"supported by port %d\\n\", res->port_id);\n-\t}\n-\tif ((ol_flags & TESTPMD_TX_OFFLOAD_SCTP_CKSUM) &&\n-\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_SCTP_CKSUM) == 0) {\n-\t\tprintf(\"Warning: hardware SCTP checksum enabled but not \"\n-\t\t\t\"supported by port %d\\n\", res->port_id);\n-\t}\n+\tcsum_show(res->port_id);\n }\n \n cmdline_parse_token_string_t cmd_csum_csum =\n--\n2.1.3", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 1aecbbb..260a273 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -2867,14 +2867,56 @@ struct cmd_csum_result { };\n \n static void\n+csum_show(int port_id)\n+{\n+\tstruct rte_eth_dev_info dev_info;\n+\tuint16_t ol_flags;\n+\n+\tol_flags = ports[port_id].tx_ol_flags;\n+\tprintf(\"IP checksum offload is %s\\n\",\n+\t\t(ol_flags & TESTPMD_TX_OFFLOAD_IP_CKSUM) ? \"hw\" : \"sw\");\n+\tprintf(\"UDP checksum offload is %s\\n\",\n+\t\t(ol_flags & TESTPMD_TX_OFFLOAD_UDP_CKSUM) ? \"hw\" : \"sw\");\n+\tprintf(\"TCP checksum offload is %s\\n\",\n+\t\t(ol_flags & TESTPMD_TX_OFFLOAD_TCP_CKSUM) ? \"hw\" : \"sw\");\n+\tprintf(\"SCTP checksum offload is %s\\n\",\n+\t\t(ol_flags & TESTPMD_TX_OFFLOAD_SCTP_CKSUM) ? \"hw\" : \"sw\");\n+\tprintf(\"VxLAN checksum offload is %s\\n\",\n+\t\t(ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) ? \"hw\" : \"sw\");\n+\n+\t/* display warnings if configuration is not supported by the NIC */\n+\trte_eth_dev_info_get(port_id, &dev_info);\n+\tif ((ol_flags & TESTPMD_TX_OFFLOAD_IP_CKSUM) &&\n+\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IPV4_CKSUM) == 0) {\n+\t\tprintf(\"Warning: hardware IP checksum enabled but not \"\n+\t\t\t\"supported by port %d\\n\", port_id);\n+\t}\n+\tif ((ol_flags & TESTPMD_TX_OFFLOAD_UDP_CKSUM) &&\n+\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_CKSUM) == 0) {\n+\t\tprintf(\"Warning: hardware UDP checksum enabled but not \"\n+\t\t\t\"supported by port %d\\n\", port_id);\n+\t}\n+\tif ((ol_flags & TESTPMD_TX_OFFLOAD_TCP_CKSUM) &&\n+\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_CKSUM) == 0) {\n+\t\tprintf(\"Warning: hardware TCP checksum enabled but not \"\n+\t\t\t\"supported by port %d\\n\", port_id);\n+\t}\n+\tif ((ol_flags & TESTPMD_TX_OFFLOAD_SCTP_CKSUM) &&\n+\t\t(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_SCTP_CKSUM) == 0) {\n+\t\tprintf(\"Warning: hardware SCTP checksum enabled but not \"\n+\t\t\t\"supported by port %d\\n\", port_id);\n+\t}\n\nThe ESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM check is missed here.\n \n+\n+}\n+\n+static void\n cmd_csum_parsed(void *parsed_result,\n \t\t __attribute__((unused)) struct cmdline *cl,\n \t\t __attribute__((unused)) void *data) {\n \tstruct cmd_csum_result *res = parsed_result;\n \tint hw = 0;\n-\tuint16_t ol_flags, mask = 0;\n-\tstruct rte_eth_dev_info dev_info;\n+\tuint16_t mask = 0;\n \n \tif (port_id_is_invalid(res->port_id)) {\n", "prefixes": [ "dpdk-dev", "RFC", "09/16" ] }{ "id": 2497, "url": "